From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 1/2] pcm_file: do not disrupt playback on output file write fail Date: Tue, 11 Jun 2019 18:03:47 +0200 Message-ID: References: <1559910203-29795-1-git-send-email-amiartus@de.adit-jv.com> <1559910203-29795-2-git-send-email-amiartus@de.adit-jv.com> <4418bd15-24a0-401a-9d86-709fc99d7b49@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 20D78F80791 for ; Tue, 11 Jun 2019 18:03:48 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: "Miartus, Adam (Arion Recruitment; ADITG/ESM)" Cc: Cezary Rojewski , "alsa-devel@alsa-project.org" List-Id: alsa-devel@alsa-project.org On Tue, 11 Jun 2019 09:52:19 +0200, Miartus, Adam (Arion Recruitment; ADITG/ESM) wrote: > > Thank you for the review, I removed the whitespace, brackets and moved the log to be printed at first error occurrence. > > Should I send a new patch request or copy paste here is ok? Please resubmit the patchset as v2 later. But it's better if you guys take internal reviews and get reviewed-by tag before resubmission. thanks, Takashi