From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 979BCC54E67 for ; Thu, 28 Mar 2024 14:31:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpqmQ-0001Jt-N7; Thu, 28 Mar 2024 10:30:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpqmL-0001Iz-R6 for qemu-devel@nongnu.org; Thu, 28 Mar 2024 10:30:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpqmB-0001Cg-FD for qemu-devel@nongnu.org; Thu, 28 Mar 2024 10:30:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711636235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P7/J3WnBgIvpFN92PE8KC7e6PRR+hYM4ACdSTDuhmKU=; b=RO30nS80nme1x8qYhHadrPNrvA+moKs56FQrUhBnW2UUv/YzlgN8VjhJ0fuxa2epaJBDSo VxyYEZ/DBg4PwtYl9jzbPTQhLXEbKKCZpfuTQ7HvxQKAglRTvO5B+8OdauZrgDrYWfKnSE HsQNWL+6OLnrL6cIJq/+i+ooPMJx7So= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-6QZ8aaqWOtmIlb-rV-plig-1; Thu, 28 Mar 2024 10:30:29 -0400 X-MC-Unique: 6QZ8aaqWOtmIlb-rV-plig-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5F2882800EA2; Thu, 28 Mar 2024 14:30:28 +0000 (UTC) Received: from redhat.com (unknown [10.2.16.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BB592024517; Thu, 28 Mar 2024 14:30:23 +0000 (UTC) Date: Thu, 28 Mar 2024 09:30:17 -0500 From: Eric Blake To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, Hyman Huang , Vladimir Sementsov-Ogievskiy , Paolo Bonzini , Gerd Hoffmann , qemu-block@nongnu.org, Kevin Wolf , Fabiano Rosas , Mahmoud Mandour , John Snow , Klaus Jensen , Fam Zheng , Eugenio =?utf-8?B?UMOpcmV6?= , Bin Meng , Hanna Reitz , "Michael S. Tsirkin" , Stefan Hajnoczi , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Yuval Shaia , Alex =?utf-8?Q?Benn=C3=A9e?= , Jesper Devantier , Pierrick Bouvier , Keith Busch , Marcel Apfelbaum , Alexandre Iooss , Peter Xu Subject: Re: [PATCH 04/19] nbd: with -Werror=maybe-uninitialized false-positive Message-ID: References: <20240328102052.3499331-1-marcandre.lureau@redhat.com> <20240328102052.3499331-5-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240328102052.3499331-5-marcandre.lureau@redhat.com> User-Agent: NeoMutt/20240201 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.08, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Mar 28, 2024 at 02:20:37PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > ../nbd/client-connection.c:419:8: error: ‘wait_co’ may be used uninitialized [-Werror=maybe-uninitialized] > > Signed-off-by: Marc-André Lureau > --- > nbd/client-connection.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/nbd/client-connection.c b/nbd/client-connection.c > index f9da67c87e..b11e266807 100644 > --- a/nbd/client-connection.c > +++ b/nbd/client-connection.c > @@ -410,7 +410,7 @@ nbd_co_establish_connection(NBDClientConnection *conn, NBDExportInfo *info, > */ > void nbd_co_establish_connection_cancel(NBDClientConnection *conn) > { > - Coroutine *wait_co; > + Coroutine *wait_co = NULL; > > WITH_QEMU_LOCK_GUARD(&conn->mutex) { > wait_co = g_steal_pointer(&conn->wait_co); > -- > 2.44.0 > -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org