* [U-Boot] [RFC] general ULPI support
@ 2011-10-15 13:19 Jana Rapava
2011-10-15 17:57 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Jana Rapava @ 2011-10-15 13:19 UTC (permalink / raw
To: u-boot
Hi all,
my patch, which added USB support for Efika, needed som ULPI functions. I
was suggested to write general ULPI support code rather than implenent
demanded functionality in the driver.
However, I've encountered following problems:
1. Where should I put this code? Linux kernel has it in ./drivers/usb/otg/
together with OTG utility code. Use this name looks a bit deceiving for me.
Should I create some directory named like ./drivers/usb/ulpi/, or is there
better place?
2. I don't know what to add to the Makefile. Should I create a new config
option (named CONFIG_ULPI I suppose) or simply add rule for new files?
Regards,
Jana Rapava
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [RFC] general ULPI support
2011-10-15 13:19 [U-Boot] [RFC] general ULPI support Jana Rapava
@ 2011-10-15 17:57 ` Marek Vasut
2011-10-18 10:21 ` Detlev Zundel
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2011-10-15 17:57 UTC (permalink / raw
To: u-boot
On Saturday, October 15, 2011 03:19:45 PM Jana Rapava wrote:
> Hi all,
Dear Jana Rapava,
please Cc respective custodians if you want to get _ANY_ feedback at all.
> my patch, which added USB support for Efika, needed som ULPI functions. I
> was suggested to write general ULPI support code rather than implenent
> demanded functionality in the driver.
> However, I've encountered following problems:
> 1. Where should I put this code? Linux kernel has it in ./drivers/usb/otg/
> together with OTG utility code. Use this name looks a bit deceiving for me.
> Should I create some directory named like ./drivers/usb/ulpi/, or is there
> better place?
drivers/usb/ulpi looks ok
> 2. I don't know what to add to the Makefile. Should I create a new config
> option (named CONFIG_ULPI I suppose) or simply add rule for new files?
You definitelly don't want to compile the code in unconditionally.
Anyway, do you really need the linux ulpi code as is or can you implement more
lightweight thing?
Cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [RFC] general ULPI support
2011-10-15 17:57 ` Marek Vasut
@ 2011-10-18 10:21 ` Detlev Zundel
0 siblings, 0 replies; 3+ messages in thread
From: Detlev Zundel @ 2011-10-18 10:21 UTC (permalink / raw
To: u-boot
Hi Marek,
[...]
> Anyway, do you really need the linux ulpi code as is or can you implement more
> lightweight thing?
Especially with respect to usb I'd like to encourage code sharing. The
first USB implementation in U-Boot was such a "we do it ourself" thing
and effectively cut us off from the hepful of bugfixes/new features that
Linux saw in the meantime. Let's try to share as much as possible in
such areas of complex code (with that I mean not algorithmic complexity
but work-arounds and special cases).
Cheers
Detlev
--
Man against god... God against Man... Man against nature... Nature against
man... God against nature... Nature against god... a very, very funny
religion. -- Zen Master D.T. Suzuki commenting on Christianity
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-18 10:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-15 13:19 [U-Boot] [RFC] general ULPI support Jana Rapava
2011-10-15 17:57 ` Marek Vasut
2011-10-18 10:21 ` Detlev Zundel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.