From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9CEFC48BE8 for ; Sat, 12 Jun 2021 09:22:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A140A611CC for ; Sat, 12 Jun 2021 09:22:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbhFLJYf (ORCPT ); Sat, 12 Jun 2021 05:24:35 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:44615 "EHLO mail-wr1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbhFLJYe (ORCPT ); Sat, 12 Jun 2021 05:24:34 -0400 Received: by mail-wr1-f47.google.com with SMTP id f2so8543459wri.11; Sat, 12 Jun 2021 02:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=VPyfpqUMlxaWdAzLxId3Zh5R6JorORKQlcjlpTdHelo=; b=WBu1HCdi/S31eLGZ4097FPwjEU+DY8GX9ch7FcVF2Pku3eCw7UKY2MgUUFvTO0Hj9X 894JgYQx//cwhbtezHsqIc1BJGPSTQrtn2+Yhg+wxoaKClgGrAMDpAHmMwRgFw9Trjdr HPy/wMVkrzY604BmPMAU7OFsHXEPHKBB8xAuckjfNdDfwFXhyMZJjwWdTaGNSL6MCbrI PP6dlsn+/rfnyp6jBmillGqFo7DLgFxG2CrH1eSCiXQyoGiuwd5kxuibpMdpLblENOef V6Ao2+gcqT+1ZSv475obc0Fxso5cIxHVidPjwFnahKQedOMhCsTQUG43c9OD6rwZjE+f JWNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=VPyfpqUMlxaWdAzLxId3Zh5R6JorORKQlcjlpTdHelo=; b=HCQ7HWwsa+VlUBZ9tzFDSHyOJNyZV/swU/89r7zfn2bwA4x/fnVpWuI+gihUaCVfLm /D9VUeGfvGp0nkWTtvqejeex9QZ44Si/kYqtIF6Q7qobLptL+7NqAAMHGgjW01TwWpvU 9pVxQCpqaVaJzRg2h5flpYCwLFJGqHeeCDEaIuz6+b/D+RDoY8cEnZGXeohfAjUQoEud yQhnZt3+Y5xr8veugE3yLm87zIyh2z4nRUKwfdVJ1PidlUKYHgyf7WlQCDYWNiOQGugj 23ZOenV3j00GrD7D79nhvh4xQ3OPBvkmkSl0Di91DRU2ZMccd16xpuWlLm1Zq+9GDOJv NsVg== X-Gm-Message-State: AOAM5324gJzYhl4cnkdR0ZfY3YggsLIRvReauWQlldf05BBSCpqrR/Oq 7YYyOpl2Y7pGNFQwsb9o/65bQaNWq46kZQ== X-Google-Smtp-Source: ABdhPJx1SmIKt8DQjEBrnkm86h9UTaK5hGf5oK2W6pHvVhU3I/3Rp6viczcAtjNXXOl91Mjt/XRPZQ== X-Received: by 2002:a5d:64c7:: with SMTP id f7mr8237318wri.36.1623489694024; Sat, 12 Jun 2021 02:21:34 -0700 (PDT) Received: from localhost.localdomain (haganm.plus.com. [212.159.108.31]) by smtp.gmail.com with ESMTPSA id l10sm9562095wrs.11.2021.06.12.02.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Jun 2021 02:21:33 -0700 (PDT) Subject: Re: [PATCH v2 1/5] dt-bindings: arm: bcm: NSP: add Meraki MX64/MX65 To: Vladimir Oltean List-Id: Cc: Florian Fainelli , Andrew Lunn , Rob Herring , Arnd Bergmann , Olof Johansson , soc@kernel.org, Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Geert Uytterhoeven , Krzysztof Kozlowski , Sam Ravnborg , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210610232727.1383117-1-mnhagan88@gmail.com> <20210610232727.1383117-2-mnhagan88@gmail.com> <20210611194644.64lvhvp76wy6guqp@skbuf> From: Matthew Hagan Message-ID: Date: Sat, 12 Jun 2021 10:21:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210611194644.64lvhvp76wy6guqp@skbuf> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vladimir, Many thanks for taking the time to review the submission. On 11/06/2021 20:46, Vladimir Oltean wrote: > On Fri, Jun 11, 2021 at 12:27:13AM +0100, Matthew Hagan wrote: >> Add bindings for the Meraki MX64/MX65 series. Note this patch should be >> applied on top of "dt-bindings: arm: bcm: add NSP devices to SoCs". >> >> Signed-off-by: Matthew Hagan >> --- >> Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml >> index 78dfa315f3d0..7d184ba7d180 100644 >> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml >> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml >> @@ -62,6 +62,12 @@ properties: >> - enum: >> - brcm,bcm958625hr >> - brcm,bcm958625k >> + - meraki,mx64 >> + - meraki,mx64-a0 >> + - meraki,mx64w >> + - meraki,mx64w-a0 >> + - meraki,mx65 >> + - meraki,mx65w >> - const: brcm,bcm58625 >> - const: brcm,nsp >> >> -- >> 2.26.3 >> > I think these compatibles describe SoCs, whereas Meraki MX64/MX65 are > boards, so this is a miscategorization. Can you not just describe the > Northstar Plus SoC that you are using in your compatible string? My understanding is that the bcm958625hr and bcm958625k are dev boards using the BCM58625 SoC variant of NSP. For reference, a close example can be found in brcm,bcm4708.yaml in the same directory: - description: BCM53012 based boards items: - enum: - brcm,bcm953012er - brcm,bcm953012hr - brcm,bcm953012k - meraki,mr32 - const: brcm,brcm53012 - const: brcm,brcm53016 - const: brcm,bcm4708 For the compatible string we would definitely need to specify a unique device name for identification by the OS, rather than just the SoC. Of course I could be mistaken. Will await confirmation on this. Matthew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7A2EC48BE5 for ; Sat, 12 Jun 2021 09:24:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6784611CC for ; Sat, 12 Jun 2021 09:24:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6784611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=2w5iZ0WUc1WCGxemDMXRMCQDJzBjGNz/mRuGj8zF6XY=; b=l1fHrz9Cg+jCiDl6ZvqVlrQKR4 RysCJljmgGYKSuhHSsE71aJ+yjsn3sCkJ/HCNg90xPUKN2h9F6J8Vy1SdIccgs09XkEfCJYwOyJA5 3buyc/F3FU0P0Te9B1SFCGAfKOfCT87mQVJWNCXTddvB1p/rO/xx9YQQI04HbjczqMDeR6xXoBefj LKuaDuPWSR5FXLKWct6DeBWNq3BKeQreVLIkNGtJkNxAbHLdWToqmlkvd7XbhVU+VL1SGW/Qqu6+c cqbdzyH67rYyDgZQoJDGmWl+xFzi3z76Jspxt7HyEbVOTYxZU9eDoIY2vGPl8rAYvsVB46zO4YuGr 4ADIWToA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrzqi-008Bue-Hn; Sat, 12 Jun 2021 09:22:40 +0000 Received: from mail-wr1-f51.google.com ([209.85.221.51]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrzqf-008Btb-F9 for linux-arm-kernel@lists.infradead.org; Sat, 12 Jun 2021 09:22:38 +0000 Received: by mail-wr1-f51.google.com with SMTP id c5so8543873wrq.9 for ; Sat, 12 Jun 2021 02:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=VPyfpqUMlxaWdAzLxId3Zh5R6JorORKQlcjlpTdHelo=; b=WBu1HCdi/S31eLGZ4097FPwjEU+DY8GX9ch7FcVF2Pku3eCw7UKY2MgUUFvTO0Hj9X 894JgYQx//cwhbtezHsqIc1BJGPSTQrtn2+Yhg+wxoaKClgGrAMDpAHmMwRgFw9Trjdr HPy/wMVkrzY604BmPMAU7OFsHXEPHKBB8xAuckjfNdDfwFXhyMZJjwWdTaGNSL6MCbrI PP6dlsn+/rfnyp6jBmillGqFo7DLgFxG2CrH1eSCiXQyoGiuwd5kxuibpMdpLblENOef V6Ao2+gcqT+1ZSv475obc0Fxso5cIxHVidPjwFnahKQedOMhCsTQUG43c9OD6rwZjE+f JWNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=VPyfpqUMlxaWdAzLxId3Zh5R6JorORKQlcjlpTdHelo=; b=imch1Chi/JZaMyLYk5yCcTK0ESGHE6HwAHVYczgvaM5LPCgKq5MYfrSD5FmJT0IHQy g29w5gVFqAvjH94P2uzxdlaD81KM3Dnev7ANYQAgNuWrwA0ynHHTTlzcSs49edD3uUeG wbetQefzf9HzBYvg29dAWmud55PMUb6Z+PKUek/thpbHOjac3dNGiUTzbWZuvsp7DIHJ vNE55N2JnePHLHUl3pJ4JcZLEMgWzQ3nD0gbl785Ijmt2Q3+PiwmCaIyiGqG276zbMvO LuE8avqHrXFUDapVyACo8TdoLQd2JqNXt75KIH9kbHVvUE8GvVGCfRrA7O9WfrM91as+ TmrA== X-Gm-Message-State: AOAM5329olKuLh3fkkx/RPhn3CYHgsygakvrBUBNOmzZwFhdg7Y7WIXI Iu02KIbDIz1Wyzss6oTuFX4h3yXJ18SVfA== X-Google-Smtp-Source: ABdhPJx1SmIKt8DQjEBrnkm86h9UTaK5hGf5oK2W6pHvVhU3I/3Rp6viczcAtjNXXOl91Mjt/XRPZQ== X-Received: by 2002:a5d:64c7:: with SMTP id f7mr8237318wri.36.1623489694024; Sat, 12 Jun 2021 02:21:34 -0700 (PDT) Received: from localhost.localdomain (haganm.plus.com. [212.159.108.31]) by smtp.gmail.com with ESMTPSA id l10sm9562095wrs.11.2021.06.12.02.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Jun 2021 02:21:33 -0700 (PDT) Subject: Re: [PATCH v2 1/5] dt-bindings: arm: bcm: NSP: add Meraki MX64/MX65 To: Vladimir Oltean List-Id: Cc: Florian Fainelli , Andrew Lunn , Rob Herring , Arnd Bergmann , Olof Johansson , soc@kernel.org, Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Geert Uytterhoeven , Krzysztof Kozlowski , Sam Ravnborg , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210610232727.1383117-1-mnhagan88@gmail.com> <20210610232727.1383117-2-mnhagan88@gmail.com> <20210611194644.64lvhvp76wy6guqp@skbuf> From: Matthew Hagan Message-ID: Date: Sat, 12 Jun 2021 10:21:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210611194644.64lvhvp76wy6guqp@skbuf> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210612_022237_548280_722D538C X-CRM114-Status: GOOD ( 20.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vladimir, Many thanks for taking the time to review the submission. On 11/06/2021 20:46, Vladimir Oltean wrote: > On Fri, Jun 11, 2021 at 12:27:13AM +0100, Matthew Hagan wrote: >> Add bindings for the Meraki MX64/MX65 series. Note this patch should be >> applied on top of "dt-bindings: arm: bcm: add NSP devices to SoCs". >> >> Signed-off-by: Matthew Hagan >> --- >> Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml >> index 78dfa315f3d0..7d184ba7d180 100644 >> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml >> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml >> @@ -62,6 +62,12 @@ properties: >> - enum: >> - brcm,bcm958625hr >> - brcm,bcm958625k >> + - meraki,mx64 >> + - meraki,mx64-a0 >> + - meraki,mx64w >> + - meraki,mx64w-a0 >> + - meraki,mx65 >> + - meraki,mx65w >> - const: brcm,bcm58625 >> - const: brcm,nsp >> >> -- >> 2.26.3 >> > I think these compatibles describe SoCs, whereas Meraki MX64/MX65 are > boards, so this is a miscategorization. Can you not just describe the > Northstar Plus SoC that you are using in your compatible string? My understanding is that the bcm958625hr and bcm958625k are dev boards using the BCM58625 SoC variant of NSP. For reference, a close example can be found in brcm,bcm4708.yaml in the same directory: - description: BCM53012 based boards items: - enum: - brcm,bcm953012er - brcm,bcm953012hr - brcm,bcm953012k - meraki,mr32 - const: brcm,brcm53012 - const: brcm,brcm53016 - const: brcm,bcm4708 For the compatible string we would definitely need to specify a unique device name for identification by the OS, rather than just the SoC. Of course I could be mistaken. Will await confirmation on this. Matthew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel