From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Mahesh Talewad <mahesh.talewad@nxp.com>
Cc: linux-bluetooth@vger.kernel.org, devyani.godbole@nxp.com,
luiz.dentz@gmail.com, sarveshwar.bajaj@nxp.com
Subject: Re: [PATCH BlueZ v1 1/1] Autoconnecttimeout max value increased to 20000 msecs from 16384 msecs
Date: Fri, 29 Mar 2024 10:13:01 +0100 [thread overview]
Message-ID: <e7dfb37d-9163-4d58-aafb-2a2ebca73c4d@molgen.mpg.de> (raw)
In-Reply-To: <20240329063534.56892-2-mahesh.talewad@nxp.com>
Dear Mahesh,
Thank you for you patch.
Am 29.03.24 um 07:35 schrieb Mahesh Talewad:
> - In implementation Autoconnecttimeout max value is 16384 msecs.
> Increased this Autoconnecttimeout max value to 20000 msecs.
Please do *not* format it as a list item. I’d also rewrite the commit
message summary/title to use imperative mood:
> Increase autoconnect timeout max from 16.384 s to 20 s
Please also add, why this change is necessary.
> Signed-off-by: Mahesh Talewad <mahesh.talewad@nxp.com>
> ---
> src/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/main.c b/src/main.c
> index b1339c230..8ce72badc 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -656,7 +656,7 @@ static void parse_le_config(GKeyFile *config)
> &btd_opts.defaults.le.autoconnect_timeout,
> sizeof(btd_opts.defaults.le.autoconnect_timeout),
> 0x0001,
> - 0x4000},
> + 0x4E20},
Please add a comment with the decimal value. (Or why not use a decimal
value?)
Also, isn’t
2 * 16 + 15 * 256 + 4 * 16^3 = 20256
Why not just use 0x5000 (= 20480) to make it easier to calculate?
> { "AdvMonAllowlistScanDuration",
> &btd_opts.defaults.le.advmon_allowlist_scan_duration,
> sizeof(btd_opts.defaults.le.advmon_allowlist_scan_duration),
prev parent reply other threads:[~2024-03-29 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 6:35 [PATCH BlueZ v1 0/1] Autoconnecttimeout max value increased to 20000 msecs Mahesh Talewad
2024-03-29 6:35 ` [PATCH BlueZ v1 1/1] Autoconnecttimeout max value increased to 20000 msecs from 16384 msecs Mahesh Talewad
2024-03-29 8:37 ` Autoconnecttimeout max value increased to 20000 msecs bluez.test.bot
2024-03-29 9:13 ` Paul Menzel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7dfb37d-9163-4d58-aafb-2a2ebca73c4d@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=devyani.godbole@nxp.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=mahesh.talewad@nxp.com \
--cc=sarveshwar.bajaj@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.