* [Buildroot] [PATCHv2] package/localedef: fix dependencies
@ 2020-03-17 21:11 Yann E. MORIN
2020-03-17 21:31 ` Romain Naour
2020-03-27 21:48 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-03-17 21:11 UTC (permalink / raw
To: buildroot
localedef needs bison to satisfy a .y.c rule to generate a parser for
plural forms, to ultimately generate data for the target. So we do not
want to depend on the host-provided bison; we want to build our own (for
reproducibility).
localedef is a host-only package, and dependencies are not inherited
from the target variant, so we need to make them explicit host
dependencies.
And move the assignment after all the download-related variables.
Reported-by: James Hilliard <james.hilliard1@gmail.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
Changes v1 -> v2:
- do not depend on the host provided bison
---
package/localedef/localedef.mk | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/package/localedef/localedef.mk b/package/localedef/localedef.mk
index 10a1929044..3e22f68039 100644
--- a/package/localedef/localedef.mk
+++ b/package/localedef/localedef.mk
@@ -10,9 +10,12 @@
LOCALEDEF_VERSION = 2.30-20-g50f20fe506abb8853641006a7b90a81af21d7b91
LOCALEDEF_SOURCE = glibc-$(LOCALEDEF_VERSION).tar.gz
LOCALEDEF_SITE = $(call github,bminor,glibc,$(LOCALEDEF_VERSION))
-LOCALEDEF_DEPENDENCIES = $(BR2_MAKE_HOST_DEPENDENCY)
HOST_LOCALEDEF_DL_SUBDIR = glibc
+HOST_LOCALEDEF_DEPENDENCIES = \
+ $(BR2_MAKE_HOST_DEPENDENCY) \
+ host-bison
+
HOST_LOCALEDEF_CONF_ENV += ac_cv_prog_MAKE="$(BR2_MAKE)"
# Even though we use the autotools-package infrastructure, we have to override
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv2] package/localedef: fix dependencies
2020-03-17 21:11 [Buildroot] [PATCHv2] package/localedef: fix dependencies Yann E. MORIN
@ 2020-03-17 21:31 ` Romain Naour
2020-03-17 21:43 ` Yann E. MORIN
2020-03-27 21:48 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Romain Naour @ 2020-03-17 21:31 UTC (permalink / raw
To: buildroot
Hi Yann,
Le 17/03/2020 ? 22:11, Yann E. MORIN a ?crit?:
> localedef needs bison to satisfy a .y.c rule to generate a parser for
> plural forms, to ultimately generate data for the target. So we do not
> want to depend on the host-provided bison; we want to build our own (for
> reproducibility).
>
> localedef is a host-only package, and dependencies are not inherited
> from the target variant, so we need to make them explicit host
> dependencies.
>
> And move the assignment after all the download-related variables.
>
> Reported-by: James Hilliard <james.hilliard1@gmail.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
>
> ---
> Changes v1 -> v2:
> - do not depend on the host provided bison
> ---
> package/localedef/localedef.mk | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/package/localedef/localedef.mk b/package/localedef/localedef.mk
> index 10a1929044..3e22f68039 100644
> --- a/package/localedef/localedef.mk
> +++ b/package/localedef/localedef.mk
> @@ -10,9 +10,12 @@
> LOCALEDEF_VERSION = 2.30-20-g50f20fe506abb8853641006a7b90a81af21d7b91
> LOCALEDEF_SOURCE = glibc-$(LOCALEDEF_VERSION).tar.gz
> LOCALEDEF_SITE = $(call github,bminor,glibc,$(LOCALEDEF_VERSION))
> -LOCALEDEF_DEPENDENCIES = $(BR2_MAKE_HOST_DEPENDENCY)
I believe this line come from the glibc package [1] that requires GNU Make >=
4.0 since version 2.28. Indeed glibc is a target package not a host package.
[1] https://git.buildroot.net/buildroot/tree/package/glibc/glibc.mk?h=2020.02#n38
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Best regards,
Romain
> HOST_LOCALEDEF_DL_SUBDIR = glibc
>
> +HOST_LOCALEDEF_DEPENDENCIES = \
> + $(BR2_MAKE_HOST_DEPENDENCY) \
> + host-bison
> +
> HOST_LOCALEDEF_CONF_ENV += ac_cv_prog_MAKE="$(BR2_MAKE)"
>
> # Even though we use the autotools-package infrastructure, we have to override
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv2] package/localedef: fix dependencies
2020-03-17 21:31 ` Romain Naour
@ 2020-03-17 21:43 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2020-03-17 21:43 UTC (permalink / raw
To: buildroot
Romain., all,
On 2020-03-17 22:31 +0100, Romain Naour spake thusly:
> Le 17/03/2020 ? 22:11, Yann E. MORIN a ?crit?:
> > localedef needs bison to satisfy a .y.c rule to generate a parser for
> > plural forms, to ultimately generate data for the target. So we do not
> > want to depend on the host-provided bison; we want to build our own (for
> > reproducibility).
> >
> > localedef is a host-only package, and dependencies are not inherited
> > from the target variant, so we need to make them explicit host
> > dependencies.
> >
> > And move the assignment after all the download-related variables.
> >
> > Reported-by: James Hilliard <james.hilliard1@gmail.com>
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> >
> > ---
> > Changes v1 -> v2:
> > - do not depend on the host provided bison
> > ---
> > package/localedef/localedef.mk | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/localedef/localedef.mk b/package/localedef/localedef.mk
> > index 10a1929044..3e22f68039 100644
> > --- a/package/localedef/localedef.mk
> > +++ b/package/localedef/localedef.mk
> > @@ -10,9 +10,12 @@
> > LOCALEDEF_VERSION = 2.30-20-g50f20fe506abb8853641006a7b90a81af21d7b91
> > LOCALEDEF_SOURCE = glibc-$(LOCALEDEF_VERSION).tar.gz
> > LOCALEDEF_SITE = $(call github,bminor,glibc,$(LOCALEDEF_VERSION))
> > -LOCALEDEF_DEPENDENCIES = $(BR2_MAKE_HOST_DEPENDENCY)
>
> I believe this line come from the glibc package [1] that requires GNU Make >=
> 4.0 since version 2.28. Indeed glibc is a target package not a host package.
>
> [1] https://git.buildroot.net/buildroot/tree/package/glibc/glibc.mk?h=2020.02#n38
>
> Reviewed-by: Romain Naour <romain.naour@gmail.com>
Applied to master with your review tag, thanks! :-)
Regards,
Yann E. MORIN.
> Best regards,
> Romain
>
>
> > HOST_LOCALEDEF_DL_SUBDIR = glibc
> >
> > +HOST_LOCALEDEF_DEPENDENCIES = \
> > + $(BR2_MAKE_HOST_DEPENDENCY) \
> > + host-bison
> > +
> > HOST_LOCALEDEF_CONF_ENV += ac_cv_prog_MAKE="$(BR2_MAKE)"
> >
> > # Even though we use the autotools-package infrastructure, we have to override
> >
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv2] package/localedef: fix dependencies
2020-03-17 21:11 [Buildroot] [PATCHv2] package/localedef: fix dependencies Yann E. MORIN
2020-03-17 21:31 ` Romain Naour
@ 2020-03-27 21:48 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-03-27 21:48 UTC (permalink / raw
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> localedef needs bison to satisfy a .y.c rule to generate a parser for
> plural forms, to ultimately generate data for the target. So we do not
> want to depend on the host-provided bison; we want to build our own (for
> reproducibility).
> localedef is a host-only package, and dependencies are not inherited
> from the target variant, so we need to make them explicit host
> dependencies.
> And move the assignment after all the download-related variables.
> Reported-by: James Hilliard <james.hilliard1@gmail.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> Changes v1 -> v2:
> - do not depend on the host provided bison
Committed to 2020.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-27 21:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-17 21:11 [Buildroot] [PATCHv2] package/localedef: fix dependencies Yann E. MORIN
2020-03-17 21:31 ` Romain Naour
2020-03-17 21:43 ` Yann E. MORIN
2020-03-27 21:48 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.