From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C49BC4345F for ; Tue, 16 Apr 2024 16:42:05 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B78B402E0; Tue, 16 Apr 2024 18:42:04 +0200 (CEST) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id 9634D40268 for ; Tue, 16 Apr 2024 18:42:02 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VJqSd2Dzjz6K8y3; Wed, 17 Apr 2024 00:37:05 +0800 (CST) Received: from frapeml500007.china.huawei.com (unknown [7.182.85.172]) by mail.maildlp.com (Postfix) with ESMTPS id A5B5E140119; Wed, 17 Apr 2024 00:42:01 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml500007.china.huawei.com (7.182.85.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 16 Apr 2024 18:42:01 +0200 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.035; Tue, 16 Apr 2024 18:42:01 +0200 From: Konstantin Ananyev To: =?iso-8859-1?Q?Morten_Br=F8rup?= , "Stephen Hemminger" CC: "dev@dpdk.org" Subject: RE: [DPDK/ethdev Bug 1416] net/af_packet: tx_burst() can modify packets Thread-Topic: [DPDK/ethdev Bug 1416] net/af_packet: tx_burst() can modify packets Thread-Index: AQHaj+klsHkMFtD6mEu3P6qfirzOCbFq5v0AgAAmCbCAAAQrYIAAB5YQ Date: Tue, 16 Apr 2024 16:42:01 +0000 Message-ID: References: <20240416083846.08e8dcad@hermes.local> <2b4a3bac389141bbae7a2d0ec31df5c6@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35E9F3A9@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F3A9@smartserver.smartshare.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.206.138.42] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > static uint16_t > > > > eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t > > nb_pkts) > > > > { > > > > ... > > > > for (i =3D 0; i < nb_pkts; i++) { > > > > mbuf =3D *bufs++; > > > > > > > > ... > > > > > > > > /* insert vlan info if necessary */ > > > > if (mbuf->ol_flags & RTE_MBUF_F_TX_VLAN) { > > > > if (rte_vlan_insert(&mbuf)) { > > > > rte_pktmbuf_free(mbuf); > > > > continue; > > > > > > > > AFAIU, it does copy of mbuf contents into pbuf anyway (just few lin= e > > below). > > > > So the fix might be - simply insert VLAN tag at copying stage. > > > > Feel free to correct me, if I missed something. > > > > > > vlan_insert will fail if the mbuf is has refcnt > 1. > > > > > > static inline int rte_vlan_insert(struct rte_mbuf **m) > > > { > > > struct rte_ether_hdr *oh, *nh; > > > struct rte_vlan_hdr *vh; > > > > > > /* Can't insert header if mbuf is shared */ > > > if (!RTE_MBUF_DIRECT(*m) || rte_mbuf_refcnt_read(*m) > 1) > > > return -EINVAL; > > > > You are right, I missed that. > > Will close it then. >=20 > Don't close, silent drop is also a bug. >=20 > The VLAN tag could be insert when copying, as originally suggested. Agree, but to me that would be enhancement request, not a bug report. >=20 > Alternatively, set tpacket2_hdr's tp_vlan_tci and tp_vlan_tpid fields and= set TP_STATUS_VLAN_VALID and > TP_STATUS_VLAN_TPID_VALID flags in tp_status. If the kernel reads those?