* alsa-lib 1.2.2 kills my unity3d games
@ 2020-02-29 20:19 Thomas J. Moore
2020-02-29 20:41 ` Jaroslav Kysela
0 siblings, 1 reply; 2+ messages in thread
From: Thomas J. Moore @ 2020-02-29 20:19 UTC (permalink / raw
To: alsa-devel
Sorry if this has already been reported, but I only really subscribed to
report this bug, and nothing recent in the archive jumped out at me.
Some time after Jan 12, some change in my (Gentoo Linux) system caused
67 of my 72 commercial, closed-source unity3d games to crash on startup.
gdb was no help, but strace showed alsa activity before two crashes,
and, sure enough, reverting alsa-lib to 1.2.1.2 cured it.
I bisected to this commit (5ee5ef31b "namehint: correct the @args check"):
https://git.alsa-project.org/?p=alsa-lib.git;a=blobdiff;f=src/control/namehint.c;h=4927ef973c326bef41e33b87714de87b31c1f752;hp=808df6b507336b8f6d6e618a0cfa520d62a3b4fc;hb=5ee5ef31b5ff3fb7c904054cb9cac7478a727f7c;hpb=ebdd2b6cdb8119cf75f0dd0a3b283d271b3a547e
I don't know what the exact problem is, but reverting just this commit
was enough to make everything work again (and its later modification in
6055f8a58 which doesn't make sense looking at the code as the function
always returns 0 and str may still be NULL on exit, but adding a check
for NULL str is not enough to stop unity3d from crashing).
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: alsa-lib 1.2.2 kills my unity3d games
2020-02-29 20:19 alsa-lib 1.2.2 kills my unity3d games Thomas J. Moore
@ 2020-02-29 20:41 ` Jaroslav Kysela
0 siblings, 0 replies; 2+ messages in thread
From: Jaroslav Kysela @ 2020-02-29 20:41 UTC (permalink / raw
To: Thomas J. Moore, alsa-devel
Dne 29. 02. 20 v 21:19 Thomas J. Moore napsal(a):
> Sorry if this has already been reported, but I only really subscribed to
> report this bug, and nothing recent in the archive jumped out at me.
>
> Some time after Jan 12, some change in my (Gentoo Linux) system caused
> 67 of my 72 commercial, closed-source unity3d games to crash on startup.
> gdb was no help, but strace showed alsa activity before two crashes,
> and, sure enough, reverting alsa-lib to 1.2.1.2 cured it.
>
> I bisected to this commit (5ee5ef31b "namehint: correct the @args check"):
>
> https://git.alsa-project.org/?p=alsa-lib.git;a=blobdiff;f=src/control/namehint.c;h=4927ef973c326bef41e33b87714de87b31c1f752;hp=808df6b507336b8f6d6e618a0cfa520d62a3b4fc;hb=5ee5ef31b5ff3fb7c904054cb9cac7478a727f7c;hpb=ebdd2b6cdb8119cf75f0dd0a3b283d271b3a547e
>
> I don't know what the exact problem is, but reverting just this commit
> was enough to make everything work again (and its later modification in
> 6055f8a58 which doesn't make sense looking at the code as the function
> always returns 0 and str may still be NULL on exit, but adding a check
> for NULL str is not enough to stop unity3d from crashing).
The revert does not resolve the culprit. I already posted my comments to
https://github.com/alsa-project/alsa-lib/issues/27 . It's difficult to fix
something without sources. The bug seems to be in the sound device enumeration
in the commercial binary.
The alsa-lib's change just returns more devices than the previous version. It
should not affect anything. The device list collected from the affected
application in the comment bellow looks really suspicious:
https://github.com/alsa-project/alsa-lib/issues/27#issuecomment-592920831
It appears that the code does really something unwanted. You can find
workarounds in the issue.
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-29 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-29 20:19 alsa-lib 1.2.2 kills my unity3d games Thomas J. Moore
2020-02-29 20:41 ` Jaroslav Kysela
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.