From: Dan Carpenter <dan.carpenter@linaro.org>
To: diogo.ivo@tecnico.ulisboa.pt
Cc: linux-usb@vger.kernel.org
Subject: [bug report] usb: typec: ucsi: Only enable supported notifications
Date: Wed, 8 May 2024 10:53:05 +0300 [thread overview]
Message-ID: <dd955f16-bbb9-4d51-98ea-31cad358ab69@moroto.mountain> (raw)
Hello Diogo Ivo,
Commit 27ffe4ff0b33 ("usb: typec: ucsi: Only enable supported
notifications") from Mar 27, 2024 (linux-next), leads to the
following Smatch static checker warning:
drivers/usb/typec/ucsi/ucsi.c:1671 ucsi_get_supported_notifications()
warn: was expecting a 64 bit value instead of '((((1))) << (24))'
drivers/usb/typec/ucsi/ucsi.c
1665 static u64 ucsi_get_supported_notifications(struct ucsi *ucsi)
1666 {
1667 u8 features = ucsi->cap.features;
1668 u64 ntfy = UCSI_ENABLE_NTFY_ALL;
1669
1670 if (!(features & UCSI_CAP_ALT_MODE_DETAILS))
--> 1671 ntfy &= ~UCSI_ENABLE_NTFY_CAM_CHANGE;
ntfy is a u64 but UCSI_ENABLE_NTFY_CAM_CHANGE is unsigned long. So on
a 32 bit system this will clear the high 32 bits. So far as I can see
ntfy should just be a u32. Either way, the types should match.
BIT_ULL() is the way to do that if it really needs to be a u64.
1672
1673 if (!(features & UCSI_CAP_PDO_DETAILS))
1674 ntfy &= ~(UCSI_ENABLE_NTFY_PWR_LEVEL_CHANGE |
1675 UCSI_ENABLE_NTFY_CAP_CHANGE);
1676
1677 if (!(features & UCSI_CAP_EXT_SUPPLY_NOTIFICATIONS))
1678 ntfy &= ~UCSI_ENABLE_NTFY_EXT_PWR_SRC_CHANGE;
1679
1680 if (!(features & UCSI_CAP_PD_RESET))
1681 ntfy &= ~UCSI_ENABLE_NTFY_PD_RESET_COMPLETE;
1682
1683 return ntfy;
1684 }
regards,
dan carpenter
next reply other threads:[~2024-05-08 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 7:53 Dan Carpenter [this message]
2024-05-08 14:22 ` [bug report] usb: typec: ucsi: Only enable supported notifications Diogo Ivo
2024-05-08 14:34 ` Dan Carpenter
2024-05-08 14:45 ` Diogo Ivo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd955f16-bbb9-4d51-98ea-31cad358ab69@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=diogo.ivo@tecnico.ulisboa.pt \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.