From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 322D41FBA; Fri, 29 Mar 2024 15:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711726810; cv=none; b=HdL6QUR0uK57/gTcFmuwvsxwp7Is231eNnIyOK3oJoSeiErgq7txZMZXkemJ706h/3MmF23TBwrqyhDa9y9T797U3gTA7l+PYCyGN3Vb9GQ6TMhG45bwnPk+c/GXRpXpOdQ5QM7Yl7gPnUD9NcZZiU/zvvniuIML2PnCNLTipfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711726810; c=relaxed/simple; bh=XCgoZLnAXnGDp3scNF5htnbob5J7JStC8D45eQoM9R4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oCDryKTCwNBa1XESY+HXrS2fCn9Ozuiym1DVVy5CR6Vvze0hKrsJPXVEBXqEViTLFl7Ah4vNuiXZkU1sw6aoJwNBYy/7swRzdJ6OJ4/g2oFdS5u6stGkcvDtlZvAxMIncnK4B4wXmzWtYqljaYhhZLEz+CdqsKwIqq45swgykpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MUnOUR7H; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MUnOUR7H" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-53fa455cd94so1519286a12.2; Fri, 29 Mar 2024 08:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711726808; x=1712331608; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=iN31wd2vCkiTGMz1OBtEaB4JW8VyiA1XbISlyEebr3E=; b=MUnOUR7HY6vwYa92neIZHYGUvH5I1dF1Bo7/9/nYC/METJ1LcvRfTJ3UrdSMmUe6FC gOsAAcZI5fuMBtnYd1XYteTpD7iilDnzNJGQCDkjNtdSbNtsjQ+H+tT/p1giGio6N6XG c/fOoWgNLNBTXbnefO75MQyI51dLo+b1SVQJb2BkA3/hB5pZIlony882eQZu9ZFNh0ep 33bUFemjBqO3ZNk+x0tiQjkOnJ9fcXv2MQdOFypkFGG4FahpdXL6b/Vj7wCz/gfVSbTO MJv/wJzO/jQ7Kdcxmde4Pb9pySSflIuFcgkUN32tfKWGxoR+Pm6mK6F5SJkvChQwYmRp iBRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711726808; x=1712331608; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iN31wd2vCkiTGMz1OBtEaB4JW8VyiA1XbISlyEebr3E=; b=UZeXNTugUFF7ZLvxjcEC/t4b+REmywz0B1oaHxSC/FPLuIS2hcg1pnvyr0iY283ORN J5yEbOt82e+srx1WEoeZxx18mHADhxIVjqxIVbQNtO4YiNF84vQOwZMaHanx1QVhiyzi 30wGweoNPXMcu+4ZWuBv3tB2/AoFu/tSpvKnPAWTc7R6lGG+QXfoQhPIQ7qjxKDGkZ/v ZJQajuGvmLhkcxFBNd/VvXMN8OomN4lQ8AYg3AZRV7z5QGBJz9SzBiYDR89eJ0i3NxkZ b5QdJT8wzr3pwABneBZST1fjtCVvHVrB0uBTt6LeVO0XZJ6PaIXbQAQEZLISaKtvJJrU M9VA== X-Forwarded-Encrypted: i=1; AJvYcCVJOnvfqDstoGNWqya9c2CpvRlfeBuOGCz4oaW4BjNSstCi+JbsgNWSWKPkJTvDezGHP1l1yt3hbnjRuFMnFnP+ODAPa9B0KTgUzCTR4wBP509TYdlj1Yoc63C0gBx0PyATOTXRoU50jgTOCW5LOyzh02XO+PpOPZrzO6aKzu2WEDkkG11VeaYfUts4cuOCmJsj3BdXu8Ah9dTKuzXBAT0pXxXfErO3rzYezy4btqFL9YZzGWecZIDTEK13C8CLPsUfnn+9dXWOLXiWYAyrOYsmXUR2uml0icj4IJpVvUdrtlcQ8t8eBsSlQqEEb3VDGg== X-Gm-Message-State: AOJu0Yzacj+0ODnB61m4DFEwTd9U4g+aPd/faEYvzFALoBq7a3kkjEky RWWg6gr0dcatrVIFarTUu05/TalspZjQ1+zHRsDZleqZmcPuyvLR X-Google-Smtp-Source: AGHT+IF0O7HII5MYlv2g0E+BHBSm5qRGKAR+0KxI+xwk6+g8c7fXn65jtKX0C7ci+tZdnr/ge20LGw== X-Received: by 2002:a05:6a20:3c90:b0:1a5:6bfb:76de with SMTP id b16-20020a056a203c9000b001a56bfb76demr2694088pzj.2.1711726808383; Fri, 29 Mar 2024 08:40:08 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id m9-20020a170902db0900b001dd578121d4sm3581907plx.204.2024.03.29.08.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 08:40:07 -0700 (PDT) Sender: Guenter Roeck Date: Fri, 29 Mar 2024 08:40:05 -0700 From: Guenter Roeck To: Simon Horman Cc: linux-kselftest@vger.kernel.org, David Airlie , Arnd Bergmann , =?iso-8859-1?Q?Ma=EDra?= Canal , Dan Carpenter , Kees Cook , Daniel Diaz , David Gow , Arthur Grillo , Brendan Higgins , Naresh Kamboju , Maarten Lankhorst , Andrew Morton , Maxime Ripard , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, Linux Kernel Functional Testing Subject: Re: [PATCH v2 12/14] sh: Add support for suppressing warning backtraces Message-ID: References: <20240325175248.1499046-1-linux@roeck-us.net> <20240325175248.1499046-13-linux@roeck-us.net> <20240327144431.GL403975@kernel.org> <320aacc6-b7e5-4c3d-948e-d0743ab26c5d@roeck-us.net> <20240327193920.GV403975@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327193920.GV403975@kernel.org> On Wed, Mar 27, 2024 at 07:39:20PM +0000, Simon Horman wrote: [ ... ] > > > > > > Hi Guenter, > > > > > > a minor nit from my side: this change results in a Kernel doc warning. > > > > > > .../bug.h:29: warning: expecting prototype for _EMIT_BUG_ENTRY(). Prototype was for HAVE_BUG_FUNCTION() instead > > > > > > Perhaps either the new code should be placed above the Kernel doc, > > > or scripts/kernel-doc should be enhanced? > > > > > > > Thanks a lot for the feedback. > > > > The definition block needs to be inside CONFIG_DEBUG_BUGVERBOSE, > > so it would be a bit odd to move it above the documentation > > just to make kerneldoc happy. I am not really sure that to do > > about it. > > FWIIW, I agree that would be odd. > But perhaps the #ifdef could also move above the Kernel doc? > Maybe not a great idea, but the best one I've had so far. > I did that for the next version of the patch series. It is a bit more clumsy, so I left it as separate patch on top of this patch. I'd still like to get input from others before making the change final. Thanks, Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 544C5C6FD1F for ; Fri, 29 Mar 2024 16:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ufj5Wxo1srcxz8AtET+UmNBYV1p6tuoQRSr7EGujVps=; b=ZWVFPwfxjez3SG GutcQSxScFPbloVT9R/ejyiwllxxucDIvLUqhEucJ59r7Ratyuir+dcYCsDElXDFBjqXyEQSOpbzH wndQsTHGf1BzKX4uMaLRXP+gV8m9mMiajx/zPFt7pizj9xmZMcNAKLdb5MpslmuJkSRpSRa7GLOVl b/KIhmfz8YuTvdGiOI2Fgc6bFIVvtuZaamqbol/bRtLboCMV7Rsbp8/BhlZTFubWa4sFK/h0QDQwi x6XJHAQuXn6uX5P1m68jFnIQzlqepK6ZYfdsExPNX7U7M4N4lkG6sFWurJZ4JVUllAtvNHCDmLOaG /YOfiFpJ9uyaBQQ9ga9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqFPy-00000001MfI-1yQq; Fri, 29 Mar 2024 16:49:26 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqEKx-00000001Bds-1m0C; Fri, 29 Mar 2024 15:40:15 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6e709e0c123so1910534b3a.1; Fri, 29 Mar 2024 08:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711726808; x=1712331608; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=iN31wd2vCkiTGMz1OBtEaB4JW8VyiA1XbISlyEebr3E=; b=M2VV8TDTxMH1x5R6eohkb7Vm+YorT3DNwba+osiJRUx/l0Fd09wRLey/V3JMwIVCoN wFAk6tHeCCW0wweR9G4Id5sd+MUD8nRpuqvsWYBKt1PpMRCc1ZObfb2BudK0Z62tR+1M bY2x8dVXCNPev3Dok0CqwdNwBI1rc1Iyce4Ar4C+3ehmJ/gQVuXLoP58FUX4wA88hK5T YyUdbZG0WOvDlHz86cXjVcxGCM+1MKzaQWM0POZxlu/vJWM8Jv9AAlQHnTuAeVFqkqg7 Dl76oE2TrHXq4I7bMMwDMH+y1kYh4fjqwP1x+y1Gn74THLpwswwh9JFwIF614CQnF+5a ZdYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711726808; x=1712331608; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iN31wd2vCkiTGMz1OBtEaB4JW8VyiA1XbISlyEebr3E=; b=N/28Y/NFjZzUq3ZttQlV1WyAP1Ch2ff3CYWgMoXIUkbqRb5XQswtAneZ67z5YRsedL 2Z/6WsQo/8cFfxbjaLsQOueBRZfbcqOSBIj6RwleXkJ1eetCELZEbKq265ToIBiWCnWo dNCbCz5F8O2kSuaNH8IPzcEhUSJuPIfEvtppcN1K5eghetZ3mO8T9JzQN5eyg86UyYZZ KVc/s1DUqKCpHOa3WycdyBM6eGaowzoY68F4/SjtTX735QUU+sU1L+oT/HfVLCEFIo1v 96D42keNR4tvoac9QTFel5NtuLj1nOJEz1JxJbhPW5LFqviF6q04ny3Nh4q0ua77v5SP 5Ang== X-Forwarded-Encrypted: i=1; AJvYcCVuuOgGfL5FpWIENNj4dyBGwwnhIDWDMDBI8kkwinnSOCexo52Ct3tpVuwinPlFUE4mGZ+WHT+cvuTHP4hWf6SgedwPyOqR/y8tNmc7EB6X14XGGt7znmLkT9AE5VRykKvgIkFH3c6Zmkmv6h39heL+fqZjjqw= X-Gm-Message-State: AOJu0YwTnCcsNAWpMstMBO1p/f3DcPspSHsSD+e52/iNX68qJu0Ra0o5 udnHB+leV1R6mwKFJLx16jaG7Q2PY+ovfwEFf24jNbev9b5yhxjJ X-Google-Smtp-Source: AGHT+IF0O7HII5MYlv2g0E+BHBSm5qRGKAR+0KxI+xwk6+g8c7fXn65jtKX0C7ci+tZdnr/ge20LGw== X-Received: by 2002:a05:6a20:3c90:b0:1a5:6bfb:76de with SMTP id b16-20020a056a203c9000b001a56bfb76demr2694088pzj.2.1711726808383; Fri, 29 Mar 2024 08:40:08 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id m9-20020a170902db0900b001dd578121d4sm3581907plx.204.2024.03.29.08.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 08:40:07 -0700 (PDT) Date: Fri, 29 Mar 2024 08:40:05 -0700 From: Guenter Roeck To: Simon Horman Cc: linux-kselftest@vger.kernel.org, David Airlie , Arnd Bergmann , =?iso-8859-1?Q?Ma=EDra?= Canal , Dan Carpenter , Kees Cook , Daniel Diaz , David Gow , Arthur Grillo , Brendan Higgins , Naresh Kamboju , Maarten Lankhorst , Andrew Morton , Maxime Ripard , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, Linux Kernel Functional Testing Subject: Re: [PATCH v2 12/14] sh: Add support for suppressing warning backtraces Message-ID: References: <20240325175248.1499046-1-linux@roeck-us.net> <20240325175248.1499046-13-linux@roeck-us.net> <20240327144431.GL403975@kernel.org> <320aacc6-b7e5-4c3d-948e-d0743ab26c5d@roeck-us.net> <20240327193920.GV403975@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240327193920.GV403975@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240329_084011_493964_C6B517BC X-CRM114-Status: GOOD ( 23.50 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Mar 27, 2024 at 07:39:20PM +0000, Simon Horman wrote: [ ... ] > > > > > > Hi Guenter, > > > > > > a minor nit from my side: this change results in a Kernel doc warning. > > > > > > .../bug.h:29: warning: expecting prototype for _EMIT_BUG_ENTRY(). Prototype was for HAVE_BUG_FUNCTION() instead > > > > > > Perhaps either the new code should be placed above the Kernel doc, > > > or scripts/kernel-doc should be enhanced? > > > > > > > Thanks a lot for the feedback. > > > > The definition block needs to be inside CONFIG_DEBUG_BUGVERBOSE, > > so it would be a bit odd to move it above the documentation > > just to make kerneldoc happy. I am not really sure that to do > > about it. > > FWIIW, I agree that would be odd. > But perhaps the #ifdef could also move above the Kernel doc? > Maybe not a great idea, but the best one I've had so far. > I did that for the next version of the patch series. It is a bit more clumsy, so I left it as separate patch on top of this patch. I'd still like to get input from others before making the change final. Thanks, Guenter _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4146C6FD1F for ; Fri, 29 Mar 2024 16:49:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kjwwRR2YfIs85w937EZtAjbQMIiLvVu5K4iCWXgwcyI=; b=4OGlY7sOLMd18/ dUxnNi4JVc4gxd51QhWy2xhH4f5X3yWWFeTKtWdXNIFTr06sCxc5DXO2P9OS7w46O1A8bVoCY3iCX 0rU+YXPPjHlzOhQUbuUxuvs69XP+A+eN4/EoGDEY2U6bqe2d2K34WNIIXZeKgOackyQT/VCuAP2w1 HqAMJ5HeHn7NEM9rtGGJzwd6GsSPBvrkoWN2+HZ5xvjV06spawhRVEmSB79WSFJKvJHHYvG5yMxvI gIJ+KhIjX0JoJAVWh6B4Z/LrTIe3EvDZnW0RYAqScOTLlUQ0/xooOY4OF87S2Rub10ZLBO8Dc3ARG N22H8DvhCGHRxFqSu4tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqFPx-00000001MfD-3zjr; Fri, 29 Mar 2024 16:49:25 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rqEKx-00000001Bds-1m0C; Fri, 29 Mar 2024 15:40:15 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-6e709e0c123so1910534b3a.1; Fri, 29 Mar 2024 08:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711726808; x=1712331608; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=iN31wd2vCkiTGMz1OBtEaB4JW8VyiA1XbISlyEebr3E=; b=M2VV8TDTxMH1x5R6eohkb7Vm+YorT3DNwba+osiJRUx/l0Fd09wRLey/V3JMwIVCoN wFAk6tHeCCW0wweR9G4Id5sd+MUD8nRpuqvsWYBKt1PpMRCc1ZObfb2BudK0Z62tR+1M bY2x8dVXCNPev3Dok0CqwdNwBI1rc1Iyce4Ar4C+3ehmJ/gQVuXLoP58FUX4wA88hK5T YyUdbZG0WOvDlHz86cXjVcxGCM+1MKzaQWM0POZxlu/vJWM8Jv9AAlQHnTuAeVFqkqg7 Dl76oE2TrHXq4I7bMMwDMH+y1kYh4fjqwP1x+y1Gn74THLpwswwh9JFwIF614CQnF+5a ZdYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711726808; x=1712331608; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iN31wd2vCkiTGMz1OBtEaB4JW8VyiA1XbISlyEebr3E=; b=N/28Y/NFjZzUq3ZttQlV1WyAP1Ch2ff3CYWgMoXIUkbqRb5XQswtAneZ67z5YRsedL 2Z/6WsQo/8cFfxbjaLsQOueBRZfbcqOSBIj6RwleXkJ1eetCELZEbKq265ToIBiWCnWo dNCbCz5F8O2kSuaNH8IPzcEhUSJuPIfEvtppcN1K5eghetZ3mO8T9JzQN5eyg86UyYZZ KVc/s1DUqKCpHOa3WycdyBM6eGaowzoY68F4/SjtTX735QUU+sU1L+oT/HfVLCEFIo1v 96D42keNR4tvoac9QTFel5NtuLj1nOJEz1JxJbhPW5LFqviF6q04ny3Nh4q0ua77v5SP 5Ang== X-Forwarded-Encrypted: i=1; AJvYcCVuuOgGfL5FpWIENNj4dyBGwwnhIDWDMDBI8kkwinnSOCexo52Ct3tpVuwinPlFUE4mGZ+WHT+cvuTHP4hWf6SgedwPyOqR/y8tNmc7EB6X14XGGt7znmLkT9AE5VRykKvgIkFH3c6Zmkmv6h39heL+fqZjjqw= X-Gm-Message-State: AOJu0YwTnCcsNAWpMstMBO1p/f3DcPspSHsSD+e52/iNX68qJu0Ra0o5 udnHB+leV1R6mwKFJLx16jaG7Q2PY+ovfwEFf24jNbev9b5yhxjJ X-Google-Smtp-Source: AGHT+IF0O7HII5MYlv2g0E+BHBSm5qRGKAR+0KxI+xwk6+g8c7fXn65jtKX0C7ci+tZdnr/ge20LGw== X-Received: by 2002:a05:6a20:3c90:b0:1a5:6bfb:76de with SMTP id b16-20020a056a203c9000b001a56bfb76demr2694088pzj.2.1711726808383; Fri, 29 Mar 2024 08:40:08 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id m9-20020a170902db0900b001dd578121d4sm3581907plx.204.2024.03.29.08.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 08:40:07 -0700 (PDT) Date: Fri, 29 Mar 2024 08:40:05 -0700 From: Guenter Roeck To: Simon Horman Cc: linux-kselftest@vger.kernel.org, David Airlie , Arnd Bergmann , =?iso-8859-1?Q?Ma=EDra?= Canal , Dan Carpenter , Kees Cook , Daniel Diaz , David Gow , Arthur Grillo , Brendan Higgins , Naresh Kamboju , Maarten Lankhorst , Andrew Morton , Maxime Ripard , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, Linux Kernel Functional Testing Subject: Re: [PATCH v2 12/14] sh: Add support for suppressing warning backtraces Message-ID: References: <20240325175248.1499046-1-linux@roeck-us.net> <20240325175248.1499046-13-linux@roeck-us.net> <20240327144431.GL403975@kernel.org> <320aacc6-b7e5-4c3d-948e-d0743ab26c5d@roeck-us.net> <20240327193920.GV403975@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240327193920.GV403975@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240329_084011_493964_C6B517BC X-CRM114-Status: GOOD ( 23.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 27, 2024 at 07:39:20PM +0000, Simon Horman wrote: [ ... ] > > > > > > Hi Guenter, > > > > > > a minor nit from my side: this change results in a Kernel doc warning. > > > > > > .../bug.h:29: warning: expecting prototype for _EMIT_BUG_ENTRY(). Prototype was for HAVE_BUG_FUNCTION() instead > > > > > > Perhaps either the new code should be placed above the Kernel doc, > > > or scripts/kernel-doc should be enhanced? > > > > > > > Thanks a lot for the feedback. > > > > The definition block needs to be inside CONFIG_DEBUG_BUGVERBOSE, > > so it would be a bit odd to move it above the documentation > > just to make kerneldoc happy. I am not really sure that to do > > about it. > > FWIIW, I agree that would be odd. > But perhaps the #ifdef could also move above the Kernel doc? > Maybe not a great idea, but the best one I've had so far. > I did that for the next version of the patch series. It is a bit more clumsy, so I left it as separate patch on top of this patch. I'd still like to get input from others before making the change final. Thanks, Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBDBFC6FD1F for ; Fri, 29 Mar 2024 15:41:01 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=drcScYT5; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V5l4D1vBQz3vYC for ; Sat, 30 Mar 2024 02:41:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=drcScYT5; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::435; helo=mail-pf1-x435.google.com; envelope-from=groeck7@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V5l3M3RyXz3c4C for ; Sat, 30 Mar 2024 02:40:13 +1100 (AEDT) Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6e709e0c123so1910535b3a.1 for ; Fri, 29 Mar 2024 08:40:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711726808; x=1712331608; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=iN31wd2vCkiTGMz1OBtEaB4JW8VyiA1XbISlyEebr3E=; b=drcScYT5wthXsuphXCgxCeJYjSF1t1bSfgko8Gfnrg/znfl+t71b7YTUXvdpmogCRQ +K4zcg4e5hlmmdXqY+1LylWFFEWxi1jbPJoF1HbeKJVTwUjIkNQQghON+LCQrjr1WzML gPvZAIzY3myscSZCi7m6EZP8+vP6KtBRxqgGBwLuXrYIrcvTT3xD1sROFuODn56X+Eem STJsdecvYvFSpRDh1vXgjO9q99EkfLQ/6wDYpNfkXaVyb2jCPvj2ttlW30vERhcIChC6 zEY/FhNMVsL5KQwAHP1IKYEcOWDkcpi4O8mbNMeKtGnl5sEhBWWMxKqU9mKZPfOjLEc+ YDIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711726808; x=1712331608; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iN31wd2vCkiTGMz1OBtEaB4JW8VyiA1XbISlyEebr3E=; b=nJ0PkmnHaigeHJ/itL9GgRLbdhyYbkY7Xhe7XEKQc4gDddaTw4EEYVDAzEpco/062t f/ke+zdZL6/FvSJ/Db+kRQL7hKK04aVrl9ysmsbH9Rcu+hxgaeglLCIViVmtv4pe7qFR 4VM3e37dc0TmOhmZvryaNvU3yu15AhONUyf3bnIFsmbz72rflXGNK8e7DgYIQkAy7VNV lggejYOLZv4clOdn0aNgPKhuoSnIio1NbuspAncSegYbBm0gFRtzxuxIinuDhtSWd8eV wO4oTGv6vX8Uvm0MRR5MM78kFK/fS26nCDOUVLLzcGQBvBwRGjmjCfrghBSDRoUcyx6n HTHQ== X-Forwarded-Encrypted: i=1; AJvYcCUwjeaffsRD9lvSpFi6pTD34FXkZrvCMy2U6OqRLmFNflhWI9FPTjE+CLkRtyGbt6DCiyCW+BMIf1G+dw/FAY1lElGVRkgIb4XAXKy4zw== X-Gm-Message-State: AOJu0YxlwciqYMMVBesNckiasvvThMgbRr5Ia9sARGQO8EVkCk5HP5D/ INPHkcovPopdbcaUzj4oXUYvUpPN0De913RgYtMnAWufcHYvqsEq X-Google-Smtp-Source: AGHT+IF0O7HII5MYlv2g0E+BHBSm5qRGKAR+0KxI+xwk6+g8c7fXn65jtKX0C7ci+tZdnr/ge20LGw== X-Received: by 2002:a05:6a20:3c90:b0:1a5:6bfb:76de with SMTP id b16-20020a056a203c9000b001a56bfb76demr2694088pzj.2.1711726808383; Fri, 29 Mar 2024 08:40:08 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id m9-20020a170902db0900b001dd578121d4sm3581907plx.204.2024.03.29.08.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 08:40:07 -0700 (PDT) Date: Fri, 29 Mar 2024 08:40:05 -0700 From: Guenter Roeck To: Simon Horman Subject: Re: [PATCH v2 12/14] sh: Add support for suppressing warning backtraces Message-ID: References: <20240325175248.1499046-1-linux@roeck-us.net> <20240325175248.1499046-13-linux@roeck-us.net> <20240327144431.GL403975@kernel.org> <320aacc6-b7e5-4c3d-948e-d0743ab26c5d@roeck-us.net> <20240327193920.GV403975@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327193920.GV403975@kernel.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: loongarch@lists.linux.dev, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, Brendan Higgins , linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, David Airlie , Arthur Grillo , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Daniel Diaz , linux-sh@vger.kernel.org, Naresh Kamboju , =?iso-8859-1?Q?Ma=EDra?= Canal , Dan Carpenter , Linux Kernel Functional Testing , Kees Cook , Arnd Bergmann , Maarten Lankhorst , Maxime Ripard , David Gow , Daniel Vetter , linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com, linux-parisc@vger.kernel.org, netdev@vger.kernel.org, l inux-kernel@vger.kernel.org, Thomas Zimmermann , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Mar 27, 2024 at 07:39:20PM +0000, Simon Horman wrote: [ ... ] > > > > > > Hi Guenter, > > > > > > a minor nit from my side: this change results in a Kernel doc warning. > > > > > > .../bug.h:29: warning: expecting prototype for _EMIT_BUG_ENTRY(). Prototype was for HAVE_BUG_FUNCTION() instead > > > > > > Perhaps either the new code should be placed above the Kernel doc, > > > or scripts/kernel-doc should be enhanced? > > > > > > > Thanks a lot for the feedback. > > > > The definition block needs to be inside CONFIG_DEBUG_BUGVERBOSE, > > so it would be a bit odd to move it above the documentation > > just to make kerneldoc happy. I am not really sure that to do > > about it. > > FWIIW, I agree that would be odd. > But perhaps the #ifdef could also move above the Kernel doc? > Maybe not a great idea, but the best one I've had so far. > I did that for the next version of the patch series. It is a bit more clumsy, so I left it as separate patch on top of this patch. I'd still like to get input from others before making the change final. Thanks, Guenter