From: Dan Carpenter <dan.carpenter@linaro.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: quic_bqiang@quicinc.com, linux-wireless@vger.kernel.org,
ath12k@lists.infradead.org
Subject: Re: [bug report] wifi: ath12k: flush all packets before suspend
Date: Wed, 8 May 2024 20:31:56 +0300 [thread overview]
Message-ID: <d642bb50-5d79-4968-a001-13bd075c70b0@moroto.mountain> (raw)
In-Reply-To: <1abbdd0c-d4cf-4e24-9b68-d732b07300ff@quicinc.com>
On Wed, May 08, 2024 at 09:51:33AM -0700, Jeff Johnson wrote:
> On 5/8/2024 5:29 AM, Dan Carpenter wrote:
> > Hello Baochen Qiang,
> >
> > Commit 692921ead832 ("wifi: ath12k: flush all packets before
> > suspend") from Apr 22, 2024 (linux-next), leads to the following
> > Smatch static checker warning:
> >
> > drivers/net/wireless/ath/ath12k/core.c:58 ath12k_core_suspend()
> > warn: sleeping in atomic context
>
> Hi Dan,
> I'm not seeing this as part of my standard make W=1 C=1
>
> What do I need to do in order to see this?
> build_kernel_data.sh ??
>
Yeah. This is a smatch warning that requires build_kernel_data.sh
(probably you have to build several times which takes forever). The
might_sleep() is in synchronize_net().
It's better to do run time testing. If you run with
CONFIG_DEBUG_ATOMIC_SLEEP=y
then it will trigger a stack trace.
regards,
dan carpenter
prev parent reply other threads:[~2024-05-08 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 12:29 [bug report] wifi: ath12k: flush all packets before suspend Dan Carpenter
2024-05-08 16:51 ` Jeff Johnson
2024-05-08 17:31 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d642bb50-5d79-4968-a001-13bd075c70b0@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.