* [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA
@ 2024-04-21 22:23 Antony Antony
2024-04-21 22:26 ` [PATCH ipsec-next v11 1/4] xfrm: Add Direction to the SA in or out Antony Antony
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Antony Antony @ 2024-04-21 22:23 UTC (permalink / raw
To: Steffen Klassert, Herbert Xu, netdev
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, devel,
Leon Romanovsky, Eyal Birger, Nicolas Dichtel, Sabrina Dubroca
Hi,
Inspired by the upcoming IP-TFS patch set, and confusions experienced in
the past due to lack of direction attribute on SAs, add a new direction
"dir" attribute. It aims to streamline the SA configuration process and
enhance the clarity of existing SA attributes.
This patch set introduces the 'dir' attribute to SA, aka xfrm_state,
('in' for input or 'out' for output). Alsp add validations of existing
direction-specific SA attributes during configuration and in the data
path lookup.
This change would not affect any existing use case or way of configuring
SA. You will notice improvements when the new 'dir' attribute is set.
Antony Antony (4):
xfrm: Add Direction to the SA in or out
xfrm: Add dir validation to "out" data path lookup
xfrm: Add dir validation to "in" data path lookup
xfrm: Restrict SA direction attribute to specific netlink message types
include/net/xfrm.h | 1 +
include/uapi/linux/snmp.h | 2 +
include/uapi/linux/xfrm.h | 6 ++
net/ipv6/xfrm6_input.c | 7 ++
net/xfrm/xfrm_compat.c | 7 +-
net/xfrm/xfrm_device.c | 6 ++
net/xfrm/xfrm_input.c | 11 +++
net/xfrm/xfrm_policy.c | 6 ++
net/xfrm/xfrm_proc.c | 2 +
net/xfrm/xfrm_replay.c | 3 +-
net/xfrm/xfrm_state.c | 5 ++
net/xfrm/xfrm_user.c | 147 ++++++++++++++++++++++++++++++++++++--
12 files changed, 194 insertions(+), 9 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH ipsec-next v11 1/4] xfrm: Add Direction to the SA in or out
2024-04-21 22:23 [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Antony Antony
@ 2024-04-21 22:26 ` Antony Antony
2024-04-21 22:27 ` [PATCH ipsec-next v11 2/4] xfrm: Add dir validation to "out" data path lookup Antony Antony
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Antony Antony @ 2024-04-21 22:26 UTC (permalink / raw
To: Steffen Klassert, Herbert Xu, netdev
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, devel,
Leon Romanovsky, Eyal Birger, Nicolas Dichtel, Sabrina Dubroca
This patch introduces the 'dir' attribute, 'in' or 'out', to the
xfrm_state, SA, enhancing usability by delineating the scope of values
based on direction. An input SA will restrict values pertinent to input,
effectively segregating them from output-related values.
And an output SA will restrict attributes for output. This change aims
to streamline the configuration process and improve the overall
consistency of SA attributes during configuration.
This feature sets the groundwork for future patches, including
the upcoming IP-TFS patch.
Signed-off-by: Antony Antony <antony.antony@secunet.com>
v10->v11:
- set dir out for acquire state
- allow output state with ESN to set replay-window 0
- change XFRMA_SA_DIR using NLA_POLICY_RANGE()
- replace verify_sa_dir() with refactored code.
v9->v10:
- add more direction specific validations
XFRM_STATE_NOPMTUDISC, XFRM_SA_XFLAG_DONT_ENCAP_DSCP
XFRMA_MTIMER_THRESH
- refactor validations into a fuction.
- add dir to ALLOCSPI to support strongSwan updating SPI to "in" state
v8->v9:
- add validation XFRM_STATE_ICMP not allowed on OUT SA.
v7->v8:
- add extra validation check on replay window and seq
- XFRM_MSG_UPDSA old and new SA should match "dir"
v6->v7:
- add replay-window check non-esn 0 and ESN 1.
- remove :XFRMA_SA_DIR only allowed with HW OFFLOAD
v5->v6:
- XFRMA_SA_DIR only allowed with HW OFFLOAD
v4->v5:
- add details to commit message
v3->v4:
- improve HW OFFLOAD DIR check add the other direction
v2->v3:
- delete redundant XFRM_SA_DIR_USE
- use u8 for "dir"
- fix HW OFFLOAD DIR check
v1->v2:
- use .strict_start_type in struct nla_policy xfrma_policy
- delete redundant XFRM_SA_DIR_MAX enum
---
include/net/xfrm.h | 1 +
include/uapi/linux/xfrm.h | 6 ++
net/xfrm/xfrm_compat.c | 7 ++-
net/xfrm/xfrm_device.c | 6 ++
net/xfrm/xfrm_replay.c | 3 +-
net/xfrm/xfrm_state.c | 5 ++
net/xfrm/xfrm_user.c | 125 ++++++++++++++++++++++++++++++++++++--
7 files changed, 144 insertions(+), 9 deletions(-)
diff --git a/include/net/xfrm.h b/include/net/xfrm.h
index 57c743b7e4fe..7c9be06f8302 100644
--- a/include/net/xfrm.h
+++ b/include/net/xfrm.h
@@ -291,6 +291,7 @@ struct xfrm_state {
/* Private data of this transformer, format is opaque,
* interpreted by xfrm_type methods. */
void *data;
+ u8 dir;
};
static inline struct net *xs_net(struct xfrm_state *x)
diff --git a/include/uapi/linux/xfrm.h b/include/uapi/linux/xfrm.h
index 6a77328be114..18ceaba8486e 100644
--- a/include/uapi/linux/xfrm.h
+++ b/include/uapi/linux/xfrm.h
@@ -141,6 +141,11 @@ enum {
XFRM_POLICY_MAX = 3
};
+enum xfrm_sa_dir {
+ XFRM_SA_DIR_IN = 1,
+ XFRM_SA_DIR_OUT = 2
+};
+
enum {
XFRM_SHARE_ANY, /* No limitations */
XFRM_SHARE_SESSION, /* For this session only */
@@ -315,6 +320,7 @@ enum xfrm_attr_type_t {
XFRMA_SET_MARK_MASK, /* __u32 */
XFRMA_IF_ID, /* __u32 */
XFRMA_MTIMER_THRESH, /* __u32 in seconds for input SA */
+ XFRMA_SA_DIR, /* __u8 */
__XFRMA_MAX
#define XFRMA_OUTPUT_MARK XFRMA_SET_MARK /* Compatibility */
diff --git a/net/xfrm/xfrm_compat.c b/net/xfrm/xfrm_compat.c
index 655fe4ff8621..703d4172c7d7 100644
--- a/net/xfrm/xfrm_compat.c
+++ b/net/xfrm/xfrm_compat.c
@@ -98,6 +98,7 @@ static const int compat_msg_min[XFRM_NR_MSGTYPES] = {
};
static const struct nla_policy compat_policy[XFRMA_MAX+1] = {
+ [XFRMA_UNSPEC] = { .strict_start_type = XFRMA_SA_DIR },
[XFRMA_SA] = { .len = XMSGSIZE(compat_xfrm_usersa_info)},
[XFRMA_POLICY] = { .len = XMSGSIZE(compat_xfrm_userpolicy_info)},
[XFRMA_LASTUSED] = { .type = NLA_U64},
@@ -129,6 +130,7 @@ static const struct nla_policy compat_policy[XFRMA_MAX+1] = {
[XFRMA_SET_MARK_MASK] = { .type = NLA_U32 },
[XFRMA_IF_ID] = { .type = NLA_U32 },
[XFRMA_MTIMER_THRESH] = { .type = NLA_U32 },
+ [XFRMA_SA_DIR] = NLA_POLICY_RANGE(NLA_U8, XFRM_SA_DIR_IN, XFRM_SA_DIR_OUT),
};
static struct nlmsghdr *xfrm_nlmsg_put_compat(struct sk_buff *skb,
@@ -277,9 +279,10 @@ static int xfrm_xlate64_attr(struct sk_buff *dst, const struct nlattr *src)
case XFRMA_SET_MARK_MASK:
case XFRMA_IF_ID:
case XFRMA_MTIMER_THRESH:
+ case XFRMA_SA_DIR:
return xfrm_nla_cpy(dst, src, nla_len(src));
default:
- BUILD_BUG_ON(XFRMA_MAX != XFRMA_MTIMER_THRESH);
+ BUILD_BUG_ON(XFRMA_MAX != XFRMA_SA_DIR);
pr_warn_once("unsupported nla_type %d\n", src->nla_type);
return -EOPNOTSUPP;
}
@@ -434,7 +437,7 @@ static int xfrm_xlate32_attr(void *dst, const struct nlattr *nla,
int err;
if (type > XFRMA_MAX) {
- BUILD_BUG_ON(XFRMA_MAX != XFRMA_MTIMER_THRESH);
+ BUILD_BUG_ON(XFRMA_MAX != XFRMA_SA_DIR);
NL_SET_ERR_MSG(extack, "Bad attribute");
return -EOPNOTSUPP;
}
diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c
index 6346690d5c69..2455a76a1cff 100644
--- a/net/xfrm/xfrm_device.c
+++ b/net/xfrm/xfrm_device.c
@@ -253,6 +253,12 @@ int xfrm_dev_state_add(struct net *net, struct xfrm_state *x,
return -EINVAL;
}
+ if ((xuo->flags & XFRM_OFFLOAD_INBOUND && x->dir == XFRM_SA_DIR_OUT) ||
+ (!(xuo->flags & XFRM_OFFLOAD_INBOUND) && x->dir == XFRM_SA_DIR_IN)) {
+ NL_SET_ERR_MSG(extack, "Mismatched SA and offload direction");
+ return -EINVAL;
+ }
+
is_packet_offload = xuo->flags & XFRM_OFFLOAD_PACKET;
/* We don't yet support UDP encapsulation and TFC padding. */
diff --git a/net/xfrm/xfrm_replay.c b/net/xfrm/xfrm_replay.c
index ce56d659c55a..bc56c6305725 100644
--- a/net/xfrm/xfrm_replay.c
+++ b/net/xfrm/xfrm_replay.c
@@ -778,7 +778,8 @@ int xfrm_init_replay(struct xfrm_state *x, struct netlink_ext_ack *extack)
}
if (x->props.flags & XFRM_STATE_ESN) {
- if (replay_esn->replay_window == 0) {
+ if (replay_esn->replay_window == 0 &&
+ (!x->dir || x->dir == XFRM_SA_DIR_IN)) {
NL_SET_ERR_MSG(extack, "ESN replay window must be > 0");
return -EINVAL;
}
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 0c306473a79d..c8c5fc47c431 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -1292,6 +1292,7 @@ xfrm_state_find(const xfrm_address_t *daddr, const xfrm_address_t *saddr,
if (km_query(x, tmpl, pol) == 0) {
spin_lock_bh(&net->xfrm.xfrm_state_lock);
x->km.state = XFRM_STATE_ACQ;
+ x->dir = XFRM_SA_DIR_OUT;
list_add(&x->km.all, &net->xfrm.state_all);
XFRM_STATE_INSERT(bydst, &x->bydst,
net->xfrm.state_bydst + h,
@@ -1744,6 +1745,7 @@ static struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig,
x->lastused = orig->lastused;
x->new_mapping = 0;
x->new_mapping_sport = 0;
+ x->dir = orig->dir;
return x;
@@ -1857,6 +1859,9 @@ int xfrm_state_update(struct xfrm_state *x)
if (!x1)
goto out;
+ if (x1->dir != x->dir)
+ goto out;
+
if (xfrm_state_kern(x1)) {
to_put = x1;
err = -EEXIST;
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index 810b520493f3..54a0d750be4b 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -130,7 +130,7 @@ static inline int verify_sec_ctx_len(struct nlattr **attrs, struct netlink_ext_a
}
static inline int verify_replay(struct xfrm_usersa_info *p,
- struct nlattr **attrs,
+ struct nlattr **attrs, u8 sa_dir,
struct netlink_ext_ack *extack)
{
struct nlattr *rt = attrs[XFRMA_REPLAY_ESN_VAL];
@@ -168,6 +168,30 @@ static inline int verify_replay(struct xfrm_usersa_info *p,
return -EINVAL;
}
+ if (sa_dir == XFRM_SA_DIR_OUT) {
+ if (rs->replay_window) {
+ NL_SET_ERR_MSG(extack, "Replay window should be 0 for output SA");
+ return -EINVAL;
+ }
+ if (rs->seq || rs->seq_hi) {
+ NL_SET_ERR_MSG(extack,
+ "Replay seq and seq_hi should be 0 for output SA");
+ return -EINVAL;
+ }
+ if (rs->bmp_len) {
+ NL_SET_ERR_MSG(extack, "Replay bmp_len should 0 for output SA");
+ return -EINVAL;
+ }
+ }
+
+ if (sa_dir == XFRM_SA_DIR_IN) {
+ if (rs->oseq || rs->oseq_hi) {
+ NL_SET_ERR_MSG(extack,
+ "Replay oseq and oseq_hi should be 0 for input SA");
+ return -EINVAL;
+ }
+ }
+
return 0;
}
@@ -176,6 +200,7 @@ static int verify_newsa_info(struct xfrm_usersa_info *p,
struct netlink_ext_ack *extack)
{
int err;
+ u8 sa_dir = attrs[XFRMA_SA_DIR] ? nla_get_u8(attrs[XFRMA_SA_DIR]) : 0;
err = -EINVAL;
switch (p->family) {
@@ -334,7 +359,7 @@ static int verify_newsa_info(struct xfrm_usersa_info *p,
goto out;
if ((err = verify_sec_ctx_len(attrs, extack)))
goto out;
- if ((err = verify_replay(p, attrs, extack)))
+ if ((err = verify_replay(p, attrs, sa_dir, extack)))
goto out;
err = -EINVAL;
@@ -358,6 +383,64 @@ static int verify_newsa_info(struct xfrm_usersa_info *p,
err = -EINVAL;
goto out;
}
+
+ if (sa_dir == XFRM_SA_DIR_OUT) {
+ NL_SET_ERR_MSG(extack,
+ "MTIMER_THRESH attribute should not be set on output SA");
+ err = -EINVAL;
+ goto out;
+ }
+ }
+
+ if (sa_dir == XFRM_SA_DIR_OUT) {
+ if (p->flags & XFRM_STATE_DECAP_DSCP) {
+ NL_SET_ERR_MSG(extack, "Flag NDECAP_DSCP should not be set for output SA");
+ err = -EINVAL;
+ goto out;
+ }
+
+ if (p->flags & XFRM_STATE_ICMP) {
+ NL_SET_ERR_MSG(extack, "Flag ICMP should not be set for input SA");
+ err = -EINVAL;
+ goto out;
+ }
+
+ if (p->replay_window) {
+ NL_SET_ERR_MSG(extack, "Replay window should be 0 for output SA");
+ err = -EINVAL;
+ goto out;
+ }
+
+ if (attrs[XFRMA_REPLAY_VAL]) {
+ struct xfrm_replay_state *replay;
+
+ replay = nla_data(attrs[XFRMA_REPLAY_VAL]);
+
+ if (replay->seq || replay->bitmap) {
+ NL_SET_ERR_MSG(extack,
+ "Replay seq and bitmap should be 0 for output SA");
+ err = -EINVAL;
+ goto out;
+ }
+ }
+ }
+
+ if (sa_dir == XFRM_SA_DIR_IN) {
+ if (p->flags & XFRM_STATE_NOPMTUDISC) {
+ NL_SET_ERR_MSG(extack, "Flag NOPMTUDISC should not be set for input SA");
+ err = -EINVAL;
+ goto out;
+ }
+
+ if (attrs[XFRMA_SA_EXTRA_FLAGS]) {
+ u32 xflags = nla_get_u32(attrs[XFRMA_SA_EXTRA_FLAGS]);
+
+ if (xflags & XFRM_SA_XFLAG_DONT_ENCAP_DSCP) {
+ NL_SET_ERR_MSG(extack, "Flag DONT_ENCAP_DSCP should not be set for input SA");
+ err = -EINVAL;
+ goto out;
+ }
+ }
}
out:
@@ -734,6 +817,9 @@ static struct xfrm_state *xfrm_state_construct(struct net *net,
if (attrs[XFRMA_IF_ID])
x->if_id = nla_get_u32(attrs[XFRMA_IF_ID]);
+ if (attrs[XFRMA_SA_DIR])
+ x->dir = nla_get_u8(attrs[XFRMA_SA_DIR]);
+
err = __xfrm_init_state(x, false, attrs[XFRMA_OFFLOAD_DEV], extack);
if (err)
goto error;
@@ -1182,8 +1268,13 @@ static int copy_to_user_state_extra(struct xfrm_state *x,
if (ret)
goto out;
}
- if (x->mapping_maxage)
+ if (x->mapping_maxage) {
ret = nla_put_u32(skb, XFRMA_MTIMER_THRESH, x->mapping_maxage);
+ if (ret)
+ goto out;
+ }
+ if (x->dir)
+ ret = nla_put_u8(skb, XFRMA_SA_DIR, x->dir);
out:
return ret;
}
@@ -1618,6 +1709,9 @@ static int xfrm_alloc_userspi(struct sk_buff *skb, struct nlmsghdr *nlh,
if (err)
goto out;
+ if (attrs[XFRMA_SA_DIR])
+ x->dir = nla_get_u8(attrs[XFRMA_SA_DIR]);
+
resp_skb = xfrm_state_netlink(skb, x, nlh->nlmsg_seq);
if (IS_ERR(resp_skb)) {
err = PTR_ERR(resp_skb);
@@ -2402,7 +2496,8 @@ static inline unsigned int xfrm_aevent_msgsize(struct xfrm_state *x)
+ nla_total_size_64bit(sizeof(struct xfrm_lifetime_cur))
+ nla_total_size(sizeof(struct xfrm_mark))
+ nla_total_size(4) /* XFRM_AE_RTHR */
- + nla_total_size(4); /* XFRM_AE_ETHR */
+ + nla_total_size(4) /* XFRM_AE_ETHR */
+ + nla_total_size(sizeof(x->dir)); /* XFRMA_SA_DIR */
}
static int build_aevent(struct sk_buff *skb, struct xfrm_state *x, const struct km_event *c)
@@ -2459,6 +2554,12 @@ static int build_aevent(struct sk_buff *skb, struct xfrm_state *x, const struct
if (err)
goto out_cancel;
+ if (x->dir) {
+ err = nla_put_u8(skb, XFRMA_SA_DIR, x->dir);
+ if (err)
+ goto out_cancel;
+ }
+
nlmsg_end(skb, nlh);
return 0;
@@ -3018,6 +3119,7 @@ EXPORT_SYMBOL_GPL(xfrm_msg_min);
#undef XMSGSIZE
const struct nla_policy xfrma_policy[XFRMA_MAX+1] = {
+ [XFRMA_UNSPEC] = { .strict_start_type = XFRMA_SA_DIR },
[XFRMA_SA] = { .len = sizeof(struct xfrm_usersa_info)},
[XFRMA_POLICY] = { .len = sizeof(struct xfrm_userpolicy_info)},
[XFRMA_LASTUSED] = { .type = NLA_U64},
@@ -3049,6 +3151,7 @@ const struct nla_policy xfrma_policy[XFRMA_MAX+1] = {
[XFRMA_SET_MARK_MASK] = { .type = NLA_U32 },
[XFRMA_IF_ID] = { .type = NLA_U32 },
[XFRMA_MTIMER_THRESH] = { .type = NLA_U32 },
+ [XFRMA_SA_DIR] = NLA_POLICY_RANGE(NLA_U8, XFRM_SA_DIR_IN, XFRM_SA_DIR_OUT),
};
EXPORT_SYMBOL_GPL(xfrma_policy);
@@ -3189,8 +3292,9 @@ static void xfrm_netlink_rcv(struct sk_buff *skb)
static inline unsigned int xfrm_expire_msgsize(void)
{
- return NLMSG_ALIGN(sizeof(struct xfrm_user_expire))
- + nla_total_size(sizeof(struct xfrm_mark));
+ return NLMSG_ALIGN(sizeof(struct xfrm_user_expire)) +
+ nla_total_size(sizeof(struct xfrm_mark)) +
+ nla_total_size(sizeof_field(struct xfrm_state, dir));
}
static int build_expire(struct sk_buff *skb, struct xfrm_state *x, const struct km_event *c)
@@ -3217,6 +3321,12 @@ static int build_expire(struct sk_buff *skb, struct xfrm_state *x, const struct
if (err)
return err;
+ if (x->dir) {
+ err = nla_put_u8(skb, XFRMA_SA_DIR, x->dir);
+ if (err)
+ return err;
+ }
+
nlmsg_end(skb, nlh);
return 0;
}
@@ -3324,6 +3434,9 @@ static inline unsigned int xfrm_sa_len(struct xfrm_state *x)
if (x->mapping_maxage)
l += nla_total_size(sizeof(x->mapping_maxage));
+ if (x->dir)
+ l += nla_total_size(sizeof(x->dir));
+
return l;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH ipsec-next v11 2/4] xfrm: Add dir validation to "out" data path lookup
2024-04-21 22:23 [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Antony Antony
2024-04-21 22:26 ` [PATCH ipsec-next v11 1/4] xfrm: Add Direction to the SA in or out Antony Antony
@ 2024-04-21 22:27 ` Antony Antony
2024-04-22 9:54 ` Sabrina Dubroca
2024-04-21 22:29 ` [PATCH ipsec-next v11 3/4] xfrm: Add dir validation to "in" " Antony Antony
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Antony Antony @ 2024-04-21 22:27 UTC (permalink / raw
To: Steffen Klassert, Herbert Xu, netdev
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, devel,
Leon Romanovsky, Eyal Birger, Nicolas Dichtel, Sabrina Dubroca
Introduces validation for the x->dir attribute within the XFRM output
data lookup path. If the configured direction does not match the expected
direction, output, increment the XfrmOutDirError counter and drop the packet
to ensure data integrity and correct flow handling.
grep -vw 0 /proc/net/xfrm_stat
XfrmOutPolError 1
XfrmOutStateDirError 1
Signed-off-by: Antony Antony <antony.antony@secunet.com>
v10 -> 11
- rename error s/XfrmOutDirError/XfrmOutStateDirError/
- fix possible dereferencing of x reported by Smatch
---
include/uapi/linux/snmp.h | 1 +
net/xfrm/xfrm_policy.c | 6 ++++++
net/xfrm/xfrm_proc.c | 1 +
3 files changed, 8 insertions(+)
diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h
index a0819c6a5988..23792b8412bd 100644
--- a/include/uapi/linux/snmp.h
+++ b/include/uapi/linux/snmp.h
@@ -337,6 +337,7 @@ enum
LINUX_MIB_XFRMFWDHDRERROR, /* XfrmFwdHdrError*/
LINUX_MIB_XFRMOUTSTATEINVALID, /* XfrmOutStateInvalid */
LINUX_MIB_XFRMACQUIREERROR, /* XfrmAcquireError */
+ LINUX_MIB_XFRMOUTSTATEDIRERROR, /* XfrmOutStateDirError */
__LINUX_MIB_XFRMMAX
};
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index 6affe5cd85d8..298b3a9eb48d 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -2489,6 +2489,12 @@ xfrm_tmpl_resolve_one(struct xfrm_policy *policy, const struct flowi *fl,
x = xfrm_state_find(remote, local, fl, tmpl, policy, &error,
family, policy->if_id);
+ if (x && x->dir && x->dir != XFRM_SA_DIR_OUT) {
+ XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTSTATEDIRERROR);
+ xfrm_state_put(x);
+ error = -EINVAL;
+ goto fail;
+ }
if (x && x->km.state == XFRM_STATE_VALID) {
xfrm[nx++] = x;
diff --git a/net/xfrm/xfrm_proc.c b/net/xfrm/xfrm_proc.c
index 5f9bf8e5c933..98606f1078f7 100644
--- a/net/xfrm/xfrm_proc.c
+++ b/net/xfrm/xfrm_proc.c
@@ -41,6 +41,7 @@ static const struct snmp_mib xfrm_mib_list[] = {
SNMP_MIB_ITEM("XfrmFwdHdrError", LINUX_MIB_XFRMFWDHDRERROR),
SNMP_MIB_ITEM("XfrmOutStateInvalid", LINUX_MIB_XFRMOUTSTATEINVALID),
SNMP_MIB_ITEM("XfrmAcquireError", LINUX_MIB_XFRMACQUIREERROR),
+ SNMP_MIB_ITEM("XfrmOutStateDirError", LINUX_MIB_XFRMOUTSTATEDIRERROR),
SNMP_MIB_SENTINEL
};
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH ipsec-next v11 3/4] xfrm: Add dir validation to "in" data path lookup
2024-04-21 22:23 [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Antony Antony
2024-04-21 22:26 ` [PATCH ipsec-next v11 1/4] xfrm: Add Direction to the SA in or out Antony Antony
2024-04-21 22:27 ` [PATCH ipsec-next v11 2/4] xfrm: Add dir validation to "out" data path lookup Antony Antony
@ 2024-04-21 22:29 ` Antony Antony
2024-04-21 22:30 ` [PATCH ipsec-next v11 4/4] xfrm: Restrict SA direction attribute to specific netlink message types Antony Antony
2024-04-22 13:05 ` [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Jakub Kicinski
4 siblings, 0 replies; 9+ messages in thread
From: Antony Antony @ 2024-04-21 22:29 UTC (permalink / raw
To: Steffen Klassert, Herbert Xu, netdev
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, devel,
Leon Romanovsky, Eyal Birger, Nicolas Dichtel, Sabrina Dubroca
Introduces validation for the x->dir attribute within the XFRM input
data lookup path. If the configured direction does not match the
expected direction, input, increment the XfrmInStateDirError counter
and drop the packet to ensure data integrity and correct flow handling.
grep -vw 0 /proc/net/xfrm_stat
XfrmInStateDirError 1
Signed-off-by: Antony Antony <antony.antony@secunet.com>
v10->v11
- rename error s/XfrmInDirError/XfrmInStateDirError/
---
include/uapi/linux/snmp.h | 1 +
net/ipv6/xfrm6_input.c | 7 +++++++
net/xfrm/xfrm_input.c | 11 +++++++++++
net/xfrm/xfrm_proc.c | 1 +
4 files changed, 20 insertions(+)
diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h
index 23792b8412bd..adf5fd78dd50 100644
--- a/include/uapi/linux/snmp.h
+++ b/include/uapi/linux/snmp.h
@@ -338,6 +338,7 @@ enum
LINUX_MIB_XFRMOUTSTATEINVALID, /* XfrmOutStateInvalid */
LINUX_MIB_XFRMACQUIREERROR, /* XfrmAcquireError */
LINUX_MIB_XFRMOUTSTATEDIRERROR, /* XfrmOutStateDirError */
+ LINUX_MIB_XFRMINSTATEDIRERROR, /* XfrmInStateDirError */
__LINUX_MIB_XFRMMAX
};
diff --git a/net/ipv6/xfrm6_input.c b/net/ipv6/xfrm6_input.c
index a17d783dc7c0..a3c50b00d6c1 100644
--- a/net/ipv6/xfrm6_input.c
+++ b/net/ipv6/xfrm6_input.c
@@ -279,6 +279,13 @@ int xfrm6_input_addr(struct sk_buff *skb, xfrm_address_t *daddr,
if (!x)
continue;
+ if (unlikely(x->dir && x->dir != XFRM_SA_DIR_IN)) {
+ XFRM_INC_STATS(net, LINUX_MIB_XFRMINSTATEDIRERROR);
+ xfrm_state_put(x);
+ x = NULL;
+ continue;
+ }
+
spin_lock(&x->lock);
if ((!i || (x->props.flags & XFRM_STATE_WILDRECV)) &&
diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
index 161f535c8b94..71b42de6e3c9 100644
--- a/net/xfrm/xfrm_input.c
+++ b/net/xfrm/xfrm_input.c
@@ -466,6 +466,11 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
if (encap_type < 0 || (xo && xo->flags & XFRM_GRO)) {
x = xfrm_input_state(skb);
+ if (unlikely(x->dir && x->dir != XFRM_SA_DIR_IN)) {
+ XFRM_INC_STATS(net, LINUX_MIB_XFRMINSTATEDIRERROR);
+ goto drop;
+ }
+
if (unlikely(x->km.state != XFRM_STATE_VALID)) {
if (x->km.state == XFRM_STATE_ACQ)
XFRM_INC_STATS(net, LINUX_MIB_XFRMACQUIREERROR);
@@ -571,6 +576,12 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
goto drop;
}
+ if (unlikely(x->dir && x->dir != XFRM_SA_DIR_IN)) {
+ XFRM_INC_STATS(net, LINUX_MIB_XFRMINSTATEDIRERROR);
+ xfrm_state_put(x);
+ goto drop;
+ }
+
skb->mark = xfrm_smark_get(skb->mark, x);
sp->xvec[sp->len++] = x;
diff --git a/net/xfrm/xfrm_proc.c b/net/xfrm/xfrm_proc.c
index 98606f1078f7..eeb984be03a7 100644
--- a/net/xfrm/xfrm_proc.c
+++ b/net/xfrm/xfrm_proc.c
@@ -42,6 +42,7 @@ static const struct snmp_mib xfrm_mib_list[] = {
SNMP_MIB_ITEM("XfrmOutStateInvalid", LINUX_MIB_XFRMOUTSTATEINVALID),
SNMP_MIB_ITEM("XfrmAcquireError", LINUX_MIB_XFRMACQUIREERROR),
SNMP_MIB_ITEM("XfrmOutStateDirError", LINUX_MIB_XFRMOUTSTATEDIRERROR),
+ SNMP_MIB_ITEM("XfrmInStateDirError", LINUX_MIB_XFRMINSTATEDIRERROR),
SNMP_MIB_SENTINEL
};
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH ipsec-next v11 4/4] xfrm: Restrict SA direction attribute to specific netlink message types
2024-04-21 22:23 [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Antony Antony
` (2 preceding siblings ...)
2024-04-21 22:29 ` [PATCH ipsec-next v11 3/4] xfrm: Add dir validation to "in" " Antony Antony
@ 2024-04-21 22:30 ` Antony Antony
2024-04-22 13:05 ` [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Jakub Kicinski
4 siblings, 0 replies; 9+ messages in thread
From: Antony Antony @ 2024-04-21 22:30 UTC (permalink / raw
To: Steffen Klassert, Herbert Xu, netdev
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, devel,
Leon Romanovsky, Eyal Birger, Nicolas Dichtel, Sabrina Dubroca
Reject the usage of the SA_DIR attribute in xfrm netlink messages when
it's not applicable. This ensures that SA_DIR is only accepted for
certain message types (NEWSA, UPDSA, and ALLOCSPI)
Signed-off-by: Antony Antony <antony.antony@secunet.com>
---
net/xfrm/xfrm_user.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index 54a0d750be4b..be977e96338b 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -3200,6 +3200,24 @@ static const struct xfrm_link {
[XFRM_MSG_GETDEFAULT - XFRM_MSG_BASE] = { .doit = xfrm_get_default },
};
+static int xfrm_reject_unused(int type, struct nlattr **attrs,
+ struct netlink_ext_ack *extack)
+{
+ if (attrs[XFRMA_SA_DIR]) {
+ switch (type) {
+ case XFRM_MSG_NEWSA:
+ case XFRM_MSG_UPDSA:
+ case XFRM_MSG_ALLOCSPI:
+ break;
+ default:
+ NL_SET_ERR_MSG(extack, "Invalid attribute SA_DIR");
+ return -EINVAL;
+ }
+ }
+
+ return 0;
+}
+
static int xfrm_user_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh,
struct netlink_ext_ack *extack)
{
@@ -3259,6 +3277,10 @@ static int xfrm_user_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh,
if (err < 0)
goto err;
+ err = xfrm_reject_unused((type + XFRM_MSG_BASE), attrs, extack);
+ if (err < 0)
+ goto err;
+
if (link->doit == NULL) {
err = -EINVAL;
goto err;
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH ipsec-next v11 2/4] xfrm: Add dir validation to "out" data path lookup
2024-04-21 22:27 ` [PATCH ipsec-next v11 2/4] xfrm: Add dir validation to "out" data path lookup Antony Antony
@ 2024-04-22 9:54 ` Sabrina Dubroca
2024-04-23 12:36 ` [devel-ipsec] " Antony Antony
0 siblings, 1 reply; 9+ messages in thread
From: Sabrina Dubroca @ 2024-04-22 9:54 UTC (permalink / raw
To: Antony Antony
Cc: Steffen Klassert, Herbert Xu, netdev, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, devel, Leon Romanovsky,
Eyal Birger, Nicolas Dichtel
2024-04-22, 00:27:48 +0200, Antony Antony wrote:
> diff --git a/net/xfrm/xfrm_proc.c b/net/xfrm/xfrm_proc.c
> index 5f9bf8e5c933..98606f1078f7 100644
> --- a/net/xfrm/xfrm_proc.c
> +++ b/net/xfrm/xfrm_proc.c
> @@ -41,6 +41,7 @@ static const struct snmp_mib xfrm_mib_list[] = {
> SNMP_MIB_ITEM("XfrmFwdHdrError", LINUX_MIB_XFRMFWDHDRERROR),
> SNMP_MIB_ITEM("XfrmOutStateInvalid", LINUX_MIB_XFRMOUTSTATEINVALID),
> SNMP_MIB_ITEM("XfrmAcquireError", LINUX_MIB_XFRMACQUIREERROR),
> + SNMP_MIB_ITEM("XfrmOutStateDirError", LINUX_MIB_XFRMOUTSTATEDIRERROR),
This needs a corresponding entry in Documentation/networking/xfrm_proc.rst
--
Sabrina
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA
2024-04-21 22:23 [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Antony Antony
` (3 preceding siblings ...)
2024-04-21 22:30 ` [PATCH ipsec-next v11 4/4] xfrm: Restrict SA direction attribute to specific netlink message types Antony Antony
@ 2024-04-22 13:05 ` Jakub Kicinski
2024-04-23 12:34 ` Antony Antony
4 siblings, 1 reply; 9+ messages in thread
From: Jakub Kicinski @ 2024-04-22 13:05 UTC (permalink / raw
To: Antony Antony
Cc: Steffen Klassert, Herbert Xu, netdev, David S. Miller,
Eric Dumazet, Paolo Abeni, devel, Leon Romanovsky, Eyal Birger,
Nicolas Dichtel, Sabrina Dubroca
On Mon, 22 Apr 2024 00:23:58 +0200 Antony Antony wrote:
> Hi,
>
> Inspired by the upcoming IP-TFS patch set, and confusions experienced in
> the past due to lack of direction attribute on SAs, add a new direction
> "dir" attribute. It aims to streamline the SA configuration process and
> enhance the clarity of existing SA attributes.
>
> This patch set introduces the 'dir' attribute to SA, aka xfrm_state,
> ('in' for input or 'out' for output). Alsp add validations of existing
> direction-specific SA attributes during configuration and in the data
> path lookup.
>
> This change would not affect any existing use case or way of configuring
> SA. You will notice improvements when the new 'dir' attribute is set.
This breaks the xfrm_policy.sh selftests.
--
pw-bot: au
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA
2024-04-22 13:05 ` [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Jakub Kicinski
@ 2024-04-23 12:34 ` Antony Antony
0 siblings, 0 replies; 9+ messages in thread
From: Antony Antony @ 2024-04-23 12:34 UTC (permalink / raw
To: Jakub Kicinski
Cc: Antony Antony, Steffen Klassert, Herbert Xu, netdev,
David S. Miller, Eric Dumazet, Paolo Abeni, devel,
Leon Romanovsky, Eyal Birger, Nicolas Dichtel, Sabrina Dubroca
On Mon, Apr 22, 2024 at 06:05:38AM -0700, Jakub Kicinski via Devel wrote:
> On Mon, 22 Apr 2024 00:23:58 +0200 Antony Antony wrote:
> > Hi,
> >
> > Inspired by the upcoming IP-TFS patch set, and confusions experienced in
> > the past due to lack of direction attribute on SAs, add a new direction
> > "dir" attribute. It aims to streamline the SA configuration process and
> > enhance the clarity of existing SA attributes.
> >
> > This patch set introduces the 'dir' attribute to SA, aka xfrm_state,
> > ('in' for input or 'out' for output). Alsp add validations of existing
> > direction-specific SA attributes during configuration and in the data
> > path lookup.
> >
> > This change would not affect any existing use case or way of configuring
> > SA. You will notice improvements when the new 'dir' attribute is set.
>
> This breaks the xfrm_policy.sh selftests.
I mised spd lookup use diffrent nla_policy array than xfrma_policy.
I fixed it in v12.
> --
> pw-bot: au
> --
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [devel-ipsec] [PATCH ipsec-next v11 2/4] xfrm: Add dir validation to "out" data path lookup
2024-04-22 9:54 ` Sabrina Dubroca
@ 2024-04-23 12:36 ` Antony Antony
0 siblings, 0 replies; 9+ messages in thread
From: Antony Antony @ 2024-04-23 12:36 UTC (permalink / raw
To: Sabrina Dubroca
Cc: Antony Antony, Steffen Klassert, Herbert Xu, netdev,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, devel,
Leon Romanovsky, Eyal Birger, Nicolas Dichtel
On Mon, Apr 22, 2024 at 11:54:44AM +0200, Sabrina Dubroca via Devel wrote:
> 2024-04-22, 00:27:48 +0200, Antony Antony wrote:
> > diff --git a/net/xfrm/xfrm_proc.c b/net/xfrm/xfrm_proc.c
> > index 5f9bf8e5c933..98606f1078f7 100644
> > --- a/net/xfrm/xfrm_proc.c
> > +++ b/net/xfrm/xfrm_proc.c
> > @@ -41,6 +41,7 @@ static const struct snmp_mib xfrm_mib_list[] = {
> > SNMP_MIB_ITEM("XfrmFwdHdrError", LINUX_MIB_XFRMFWDHDRERROR),
> > SNMP_MIB_ITEM("XfrmOutStateInvalid", LINUX_MIB_XFRMOUTSTATEINVALID),
> > SNMP_MIB_ITEM("XfrmAcquireError", LINUX_MIB_XFRMACQUIREERROR),
> > + SNMP_MIB_ITEM("XfrmOutStateDirError", LINUX_MIB_XFRMOUTSTATEDIRERROR),
>
> This needs a corresponding entry in Documentation/networking/xfrm_proc.rst
fixed. I added both in and out error to it; v12.
-antony
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-04-23 12:37 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-21 22:23 [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Antony Antony
2024-04-21 22:26 ` [PATCH ipsec-next v11 1/4] xfrm: Add Direction to the SA in or out Antony Antony
2024-04-21 22:27 ` [PATCH ipsec-next v11 2/4] xfrm: Add dir validation to "out" data path lookup Antony Antony
2024-04-22 9:54 ` Sabrina Dubroca
2024-04-23 12:36 ` [devel-ipsec] " Antony Antony
2024-04-21 22:29 ` [PATCH ipsec-next v11 3/4] xfrm: Add dir validation to "in" " Antony Antony
2024-04-21 22:30 ` [PATCH ipsec-next v11 4/4] xfrm: Restrict SA direction attribute to specific netlink message types Antony Antony
2024-04-22 13:05 ` [PATCH ipsec-next v11 0/4] xfrm: Introduce direction attribute for SA Jakub Kicinski
2024-04-23 12:34 ` Antony Antony
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.