* [PATCH 0/1] A bugfix to enable external module building on target
@ 2014-09-30 20:57 nitin.a.kamble
2014-09-30 20:57 ` [PATCH 1/1] kernel.bbclass: enable a link for external module building nitin.a.kamble
0 siblings, 1 reply; 5+ messages in thread
From: nitin.a.kamble @ 2014-09-30 20:57 UTC (permalink / raw
To: richard.purdie, saul.wold, ross.burton, dvhart, bruce.ashfield,
Openembedded-core
From: Nitin A Kamble <nitin.a.kamble@intel.com>
The path /lib/modules/<kernel-version>/build was missing on the target.
It is required to build external modules on the target. The kernel-dev
package provides all the needed support files for building the external
kernel modules. This commit creates the required missing link on the
target, which enables the external modules building.
This has been tested with a simple external module on the qemux86-64 machine
with the core-image-sato-sdk image.
See this bug for more details:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=2968
Thanks,
Nitin
The following changes since commit c34775f8864f9bf9a2b32af1e3a803f7d84e11ba:
deb_packaging: Added support for multilib (2014-09-30 14:33:31 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib nitin/misc
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=nitin/misc
Nitin A Kamble (1):
kernel.bbclass: enable a link for external module building
meta/classes/kernel.bbclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
1.8.1.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] kernel.bbclass: enable a link for external module building
2014-09-30 20:57 [PATCH 0/1] A bugfix to enable external module building on target nitin.a.kamble
@ 2014-09-30 20:57 ` nitin.a.kamble
2014-09-30 21:00 ` Bruce Ashfield
0 siblings, 1 reply; 5+ messages in thread
From: nitin.a.kamble @ 2014-09-30 20:57 UTC (permalink / raw
To: richard.purdie, saul.wold, ross.burton, dvhart, bruce.ashfield,
Openembedded-core
From: Nitin A Kamble <nitin.a.kamble@intel.com>
To build external modules, the link /lib/modules/<kernel-version>/build
must exist, and point to the proper kernel source area.
The kernel-dev package already provides the needed source files. Now
putting a link in place to unblock the external module building.
Fixes Bug:
[YOCTO #2968]
Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
meta/classes/kernel.bbclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 78b33ce..5ac4ff4 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -213,6 +213,7 @@ kernel_do_install() {
#
kerneldir=${D}${KERNEL_SRC_PATH}
install -d $kerneldir
+ ln -sf ${KERNEL_SRC_PATH} "${D}/lib/modules/${KERNEL_VERSION}/build"
#
# Store the kernel version in sysroots for module-base.bbclass
@@ -346,7 +347,7 @@ PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev kernel-mod
FILES_${PN} = ""
FILES_kernel-base = "/lib/modules/${KERNEL_VERSION}/modules.order /lib/modules/${KERNEL_VERSION}/modules.builtin"
FILES_kernel-image = "/boot/${KERNEL_IMAGETYPE}*"
-FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH}"
+FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} /lib/modules/${KERNEL_VERSION}/build"
FILES_kernel-vmlinux = "/boot/vmlinux*"
FILES_kernel-modules = ""
RDEPENDS_kernel = "kernel-base"
--
1.8.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] kernel.bbclass: enable a link for external module building
2014-09-30 20:57 ` [PATCH 1/1] kernel.bbclass: enable a link for external module building nitin.a.kamble
@ 2014-09-30 21:00 ` Bruce Ashfield
2014-09-30 21:14 ` Bruce Ashfield
2014-09-30 21:14 ` Kamble, Nitin A
0 siblings, 2 replies; 5+ messages in thread
From: Bruce Ashfield @ 2014-09-30 21:00 UTC (permalink / raw
To: nitin.a.kamble, richard.purdie, saul.wold, ross.burton, dvhart,
Openembedded-core
On 2014-09-30, 4:57 PM, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
> To build external modules, the link /lib/modules/<kernel-version>/build
> must exist, and point to the proper kernel source area.
>
> The kernel-dev package already provides the needed source files. Now
> putting a link in place to unblock the external module building.
This description is not entirely accurate, at least from my point of
view.
You can build external modules on the target without this link .. it is
that many scripts and utilities look in this location for the kernel
source.
We are fixing that case, not the general case of building an external
module.
Cheers,
Bruce
>
> Fixes Bug:
> [YOCTO #2968]
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
> meta/classes/kernel.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 78b33ce..5ac4ff4 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -213,6 +213,7 @@ kernel_do_install() {
> #
> kerneldir=${D}${KERNEL_SRC_PATH}
> install -d $kerneldir
> + ln -sf ${KERNEL_SRC_PATH} "${D}/lib/modules/${KERNEL_VERSION}/build"
>
> #
> # Store the kernel version in sysroots for module-base.bbclass
> @@ -346,7 +347,7 @@ PACKAGES = "kernel kernel-base kernel-vmlinux kernel-image kernel-dev kernel-mod
> FILES_${PN} = ""
> FILES_kernel-base = "/lib/modules/${KERNEL_VERSION}/modules.order /lib/modules/${KERNEL_VERSION}/modules.builtin"
> FILES_kernel-image = "/boot/${KERNEL_IMAGETYPE}*"
> -FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH}"
> +FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} /lib/modules/${KERNEL_VERSION}/build"
> FILES_kernel-vmlinux = "/boot/vmlinux*"
> FILES_kernel-modules = ""
> RDEPENDS_kernel = "kernel-base"
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] kernel.bbclass: enable a link for external module building
2014-09-30 21:00 ` Bruce Ashfield
@ 2014-09-30 21:14 ` Bruce Ashfield
2014-09-30 21:14 ` Kamble, Nitin A
1 sibling, 0 replies; 5+ messages in thread
From: Bruce Ashfield @ 2014-09-30 21:14 UTC (permalink / raw
To: Kamble, Nitin A, Richard Purdie, Saul Wold, Ross Burton,
Darren Hart, Patches and discussions about the oe-core layer
On Tue, Sep 30, 2014 at 5:00 PM, Bruce Ashfield
<bruce.ashfield@windriver.com> wrote:
> On 2014-09-30, 4:57 PM, nitin.a.kamble@intel.com wrote:
>>
>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>>
>> To build external modules, the link /lib/modules/<kernel-version>/build
>> must exist, and point to the proper kernel source area.
>>
>> The kernel-dev package already provides the needed source files. Now
>> putting a link in place to unblock the external module building.
>
>
> This description is not entirely accurate, at least from my point of
> view.
>
> You can build external modules on the target without this link .. it is
> that many scripts and utilities look in this location for the kernel
> source.
>
> We are fixing that case, not the general case of building an external
> module.
I forgot to say, that outside of my nit picking on the commit message, I don't
see any significant issues with the patch.
Cheers,
Bruce
>
> Cheers,
>
> Bruce
>
>
>>
>> Fixes Bug:
>> [YOCTO #2968]
>>
>> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
>> ---
>> meta/classes/kernel.bbclass | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 78b33ce..5ac4ff4 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -213,6 +213,7 @@ kernel_do_install() {
>> #
>> kerneldir=${D}${KERNEL_SRC_PATH}
>> install -d $kerneldir
>> + ln -sf ${KERNEL_SRC_PATH}
>> "${D}/lib/modules/${KERNEL_VERSION}/build"
>>
>> #
>> # Store the kernel version in sysroots for module-base.bbclass
>> @@ -346,7 +347,7 @@ PACKAGES = "kernel kernel-base kernel-vmlinux
>> kernel-image kernel-dev kernel-mod
>> FILES_${PN} = ""
>> FILES_kernel-base = "/lib/modules/${KERNEL_VERSION}/modules.order
>> /lib/modules/${KERNEL_VERSION}/modules.builtin"
>> FILES_kernel-image = "/boot/${KERNEL_IMAGETYPE}*"
>> -FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config*
>> ${KERNEL_SRC_PATH}"
>> +FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config*
>> ${KERNEL_SRC_PATH} /lib/modules/${KERNEL_VERSION}/build"
>> FILES_kernel-vmlinux = "/boot/vmlinux*"
>> FILES_kernel-modules = ""
>> RDEPENDS_kernel = "kernel-base"
>>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] kernel.bbclass: enable a link for external module building
2014-09-30 21:00 ` Bruce Ashfield
2014-09-30 21:14 ` Bruce Ashfield
@ 2014-09-30 21:14 ` Kamble, Nitin A
1 sibling, 0 replies; 5+ messages in thread
From: Kamble, Nitin A @ 2014-09-30 21:14 UTC (permalink / raw
To: Ashfield, Bruce (Wind River), richard.purdie@linuxfoundation.org,
Wold, Saul, Burton, Ross, dvhart@linux.intel.com,
Openembedded-core@lists.openembedded.org
On 9/30/14, 2:00 PM, "Bruce Ashfield" <bruce.ashfield@windriver.com> wrote:
>On 2014-09-30, 4:57 PM, nitin.a.kamble@intel.com wrote:
>> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>>
>> To build external modules, the link /lib/modules/<kernel-version>/build
>> must exist, and point to the proper kernel source area.
>>
>> The kernel-dev package already provides the needed source files. Now
>> putting a link in place to unblock the external module building.
>
>This description is not entirely accurate, at least from my point of
>view.
>
>You can build external modules on the target without this link .. it is
>that many scripts and utilities look in this location for the kernel
>source.
>
>We are fixing that case, not the general case of building an external
>module.
I see. Thanks for pointing it out. I guess, the bug entry missed this
information. I will fix the commit log and resend it.
Nitin
>
>Cheers,
>
>Bruce
>
>>
>> Fixes Bug:
>> [YOCTO #2968]
>>
>> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
>> ---
>> meta/classes/kernel.bbclass | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 78b33ce..5ac4ff4 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -213,6 +213,7 @@ kernel_do_install() {
>> #
>> kerneldir=${D}${KERNEL_SRC_PATH}
>> install -d $kerneldir
>> + ln -sf ${KERNEL_SRC_PATH} "${D}/lib/modules/${KERNEL_VERSION}/build"
>>
>> #
>> # Store the kernel version in sysroots for module-base.bbclass
>> @@ -346,7 +347,7 @@ PACKAGES = "kernel kernel-base kernel-vmlinux
>>kernel-image kernel-dev kernel-mod
>> FILES_${PN} = ""
>> FILES_kernel-base = "/lib/modules/${KERNEL_VERSION}/modules.order
>>/lib/modules/${KERNEL_VERSION}/modules.builtin"
>> FILES_kernel-image = "/boot/${KERNEL_IMAGETYPE}*"
>> -FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers*
>>/boot/config* ${KERNEL_SRC_PATH}"
>> +FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers*
>>/boot/config* ${KERNEL_SRC_PATH} /lib/modules/${KERNEL_VERSION}/build"
>> FILES_kernel-vmlinux = "/boot/vmlinux*"
>> FILES_kernel-modules = ""
>> RDEPENDS_kernel = "kernel-base"
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-30 21:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-30 20:57 [PATCH 0/1] A bugfix to enable external module building on target nitin.a.kamble
2014-09-30 20:57 ` [PATCH 1/1] kernel.bbclass: enable a link for external module building nitin.a.kamble
2014-09-30 21:00 ` Bruce Ashfield
2014-09-30 21:14 ` Bruce Ashfield
2014-09-30 21:14 ` Kamble, Nitin A
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.