From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C91A3C04FF3 for ; Mon, 24 May 2021 08:30:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3D7B61139 for ; Mon, 24 May 2021 08:30:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3D7B61139 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7726F82ADA; Mon, 24 May 2021 10:30:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="3rLI99Rz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A2D5B82B62; Mon, 24 May 2021 10:30:42 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 914B381E92 for ; Mon, 24 May 2021 10:30:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=patrice.chotard@foss.st.com Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14O8MX54003453; Mon, 24 May 2021 10:30:38 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=NzEv8VVvFkUJN8Y+KB1SMa8jpcAHM0Gtq0E7B3bQKD4=; b=3rLI99RzoHOBHJwJC3NzoMGVUQuBT0qecMOo71384QqLDqVogJ9JUJbOWEDcGDXEM0Uz pzSDYf8jM9OKrpUUBrm+cCs0mZX6EQHBTGI5/Wf3GRFwI+kkDo/6w3KM94ev9a3mxrN2 YzsNNXfio90mfqshfb+aKeY6rDHPe/VJOcPm/e+PoayDBM7eLAhlPdFcn3aEEJ5zVKsw P5Ra9qc+/h5mm6FnfTTdp2ear+RxhBTt1iMXJrLdKMJlpMpeM02K6iD0qyyF7SGrvL5O /1c0uRtHYXQGWtG0OhTGbLYNAbKFMJmokntSl3CTWQuQ9dYB8nwuzgan9+69fNmt9S86 kA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38r83887h6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 May 2021 10:30:38 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 2297810002A; Mon, 24 May 2021 10:30:36 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1449421E66D; Mon, 24 May 2021 10:30:36 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.47) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 24 May 2021 10:30:35 +0200 Subject: Re: [PATCH] net: dwc_eth_qos: Fix needless phy auto-negotiation restarts To: Daniil Stas , , "Christophe ROULLIER" CC: Ramon Fried , Joe Hershberger , Patrick Delaunay References: <20210523222449.1495352-1-daniil.stas@posteo.net> From: Patrice CHOTARD Message-ID: Date: Mon, 24 May 2021 10:30:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210523222449.1495352-1-daniil.stas@posteo.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-24_04:2021-05-20, 2021-05-24 signatures=0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi Daniil +Christophe Thanks Patrice On 5/24/21 12:24 AM, Daniil Stas wrote: > Disabling clk_ck clock leads to link up status loss in phy, which > leads to auto-negotiation restart before each network command > execution. > > This issue is especially big for PXE boot protocol because of > auto-negotiation restarts before each configuration filename trial. > > To avoid this issue don't disable clk_ck clock after it was enabled. > > Signed-off-by: Daniil Stas > Cc: Ramon Fried > Cc: Joe Hershberger > Cc: Patrick Delaunay > Cc: Patrice Chotard > --- > drivers/net/dwc_eth_qos.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c > index e8242ca4e1..2f088c758f 100644 > --- a/drivers/net/dwc_eth_qos.c > +++ b/drivers/net/dwc_eth_qos.c > @@ -321,6 +321,7 @@ struct eqos_priv { > void *rx_pkt; > bool started; > bool reg_access_ok; > + bool clk_ck_enabled; > }; > > /* > @@ -591,12 +592,13 @@ static int eqos_start_clks_stm32(struct udevice *dev) > goto err_disable_clk_rx; > } > > - if (clk_valid(&eqos->clk_ck)) { > + if (clk_valid(&eqos->clk_ck) && !eqos->clk_ck_enabled) { > ret = clk_enable(&eqos->clk_ck); > if (ret < 0) { > pr_err("clk_enable(clk_ck) failed: %d", ret); > goto err_disable_clk_tx; > } > + eqos->clk_ck_enabled = true; > } > #endif > > @@ -648,8 +650,6 @@ static void eqos_stop_clks_stm32(struct udevice *dev) > clk_disable(&eqos->clk_tx); > clk_disable(&eqos->clk_rx); > clk_disable(&eqos->clk_master_bus); > - if (clk_valid(&eqos->clk_ck)) > - clk_disable(&eqos->clk_ck); > #endif > > debug("%s: OK\n", __func__); >