* [PATCH] xfs_scrub: fix reporting of EINVAL for online repairs
@ 2020-02-27 20:23 Darrick J. Wong
2020-02-27 20:28 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2020-02-27 20:23 UTC (permalink / raw
To: Eric Sandeen; +Cc: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
The arguments to str_corrupt() are in the wrong order. Fix that.
Fixes: de5d20ece73f579 ("libfrog: convert scrub.c functions to negative error codes")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
scrub/scrub.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/scrub/scrub.c b/scrub/scrub.c
index f8fa6b7a..6e7f99a5 100644
--- a/scrub/scrub.c
+++ b/scrub/scrub.c
@@ -774,9 +774,8 @@ _("Filesystem is shut down, aborting."));
/* fall through */
case EINVAL:
/* Kernel doesn't know how to repair this? */
- str_corrupt(ctx,
-_("%s: Don't know how to fix; offline repair required."),
- descr_render(&dsc));
+ str_corrupt(ctx, descr_render(&dsc),
+_("Don't know how to fix; offline repair required."));
return CHECK_DONE;
case EROFS:
/* Read-only filesystem, can't fix. */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs_scrub: fix reporting of EINVAL for online repairs
2020-02-27 20:23 [PATCH] xfs_scrub: fix reporting of EINVAL for online repairs Darrick J. Wong
@ 2020-02-27 20:28 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2020-02-27 20:28 UTC (permalink / raw
To: Darrick J. Wong, Eric Sandeen; +Cc: xfs
On 2/27/20 12:23 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The arguments to str_corrupt() are in the wrong order. Fix that.
>
> Fixes: de5d20ece73f579 ("libfrog: convert scrub.c functions to negative error codes")
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
thanks for the fixes: tag :)
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-27 20:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-27 20:23 [PATCH] xfs_scrub: fix reporting of EINVAL for online repairs Darrick J. Wong
2020-02-27 20:28 ` Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.