From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B12C47094 for ; Thu, 10 Jun 2021 09:51:15 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 6FC3D613C1 for ; Thu, 10 Jun 2021 09:51:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FC3D613C1 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=dpdk.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56ED44067C; Thu, 10 Jun 2021 11:51:13 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id ED1254003C for ; Thu, 10 Jun 2021 11:51:11 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id BD32BA0C50; Thu, 10 Jun 2021 11:51:11 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Date: Thu, 10 Jun 2021 09:51:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: ivan4th@gmail.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 Subject: [dpdk-dev] [Bug 729] Bad mbuf chain handling in the memif driver resulting in truncated packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" https://bugs.dpdk.org/show_bug.cgi?id=3D729 Bug ID: 729 Summary: Bad mbuf chain handling in the memif driver resulting in truncated packets Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: ivan4th@gmail.com Target Milestone: --- In a couple of places in the memif driver [1][2] rte_pktmbuf_is_contiguous() [3] is being used to check whether there are more mbufs in the chain when sending packets. Problem is, rte_pktmbuf_is_contiguous() checks nb_segs in = the mbuf, which, as far as I understand, is only set to the number of segments = in the first mbuf in the chain. This results in truncated packets as usually, nb_segs is 1 in the mbufs other than the first. Replacing rte_pktmbuf_is_contiguous(mbuf) =3D=3D 0 with mbuf->next !=3D NULL fixes th= e issue. The problem has been observed while trying to use TRex traffic generator wi= th VPP [4]. [1] http://code.dpdk.org/dpdk/v21.05/source/drivers/net/memif/rte_eth_memif.c#L= 660 [2] http://code.dpdk.org/dpdk/v21.05/source/drivers/net/memif/rte_eth_memif.c#L= 717 [3] http://code.dpdk.org/dpdk/v21.05/source/lib/mbuf/rte_mbuf.h#L1687 [4] https://github.com/cisco-system-traffic-generator/trex-core/issues/686 --=20 You are receiving this mail because: You are the assignee for the bug.=