All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 729] Bad mbuf chain handling in the memif driver resulting in truncated packets
Date: Thu, 10 Jun 2021 09:51:11 +0000	[thread overview]
Message-ID: <bug-729-3@http.bugs.dpdk.org/> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=729

            Bug ID: 729
           Summary: Bad mbuf chain handling in the memif driver resulting
                    in truncated packets
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: ivan4th@gmail.com
  Target Milestone: ---

In a couple of places in the memif driver [1][2] rte_pktmbuf_is_contiguous()
[3] is being used to check whether there are more mbufs in the chain when
sending packets. Problem is, rte_pktmbuf_is_contiguous() checks nb_segs in the
mbuf, which, as far as I understand, is only set to the number of segments in
the first mbuf in the chain. This results in truncated packets as usually,
nb_segs is 1 in the mbufs other than the first. Replacing
rte_pktmbuf_is_contiguous(mbuf) == 0 with mbuf->next != NULL fixes the issue.

The problem has been observed while trying to use TRex traffic generator with
VPP [4].

[1]
http://code.dpdk.org/dpdk/v21.05/source/drivers/net/memif/rte_eth_memif.c#L660

[2]
http://code.dpdk.org/dpdk/v21.05/source/drivers/net/memif/rte_eth_memif.c#L717

[3] http://code.dpdk.org/dpdk/v21.05/source/lib/mbuf/rte_mbuf.h#L1687

[4] https://github.com/cisco-system-traffic-generator/trex-core/issues/686

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2021-06-10  9:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-729-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.