From: gaosong <gaosong@loongson.cn>
To: Markus Elfring <Markus.Elfring@web.de>,
loongarch@lists.linux.dev, kernel-janitors@vger.kernel.org,
maobibo@loongson.cn
Cc: LKML <linux-kernel@vger.kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Tianrui Zhao <zhaotianrui@loongson.cn>,
Wang Xuerui <kernel@xen0n.name>
Subject: Re: [PATCH v3] LoongArch: KVM: Add PMU support
Date: Mon, 29 Apr 2024 15:32:09 +0800 [thread overview]
Message-ID: <b8818597-2770-f2a3-03bd-1653cd26fc78@loongson.cn> (raw)
In-Reply-To: <e68e09e0-75f3-43b8-b947-22cc0d1a0dae@web.de>
在 2024/4/25 下午3:18, Markus Elfring 写道:
> …
>> On KVM side. we save the host PMU CSRs into structure kvm_context.
>> If the host supports the PMU feature. When entering guest mode.
>> we save the host PMU CSRs and restore the guest PMU CSRs.
> …
>
> I suggest to reconsider the usage of a few dots in such a wording approach.
>
>
> …
> Signed-off-by: Song Gao <gaosong@loongson.cn>
>
> v2->V3:
> …
>
> * Please put your version descriptions behind a marker line.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n713
Got it, thank for you suggestion.
> * How do you think about to avoid the repetition of version identifiers here?
I'm new to this, is the following example correct?
[...]
Signed-off-by: Song Gao <gaosong@loongson.cn>
---
v4:
- Use the macro kvm_read_clear_hw_gcsr to optimize the code
and remove redundant code.
V3:
- When saving the PMU context, clear the CTRL register
before reading the CNTR register.
- Put kvm_lose_pmu() in kvm_handler_exit().
v2:
- Add new vcpu->request flag KVM_REQ_PMU. If we use PMU,
We need to set this flag;
- Add kvm_check_pmu() to kvm_pre_enter_guest();
- On _kvm_setcsr(), after modifying the PMU CSR register value,
if we use PMU, we need to set KVM_REQ_PMU.
Patch v3:
https://lore.kernel.org/all/20240424091813.1471440-1-gaosong@loongson.cn/
Patch v2:
https://lore.kernel.org/all/20240417065236.500011-1-gaosong@loongson.cn/
Patch v1:
https://lore.kernel.org/all/20240410095812.2943706-1-gaosong@loongson.cn/
---
[...]
Regards.
Song Gao
>
> Regards,
> Markus
next prev parent reply other threads:[~2024-04-29 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 9:18 [PATCH v3] LoongArch: KVM: Add PMU support Song Gao
2024-04-25 6:31 ` maobibo
2024-04-25 7:18 ` Markus Elfring
2024-04-29 7:32 ` gaosong [this message]
2024-04-29 8:20 ` [v3] " Markus Elfring
2024-04-29 9:07 ` gaosong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8818597-2770-f2a3-03bd-1653cd26fc78@loongson.cn \
--to=gaosong@loongson.cn \
--cc=Markus.Elfring@web.de \
--cc=chenhuacai@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=pbonzini@redhat.com \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.