From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E2CC433DF for ; Tue, 23 Jun 2020 11:07:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18B4B2072E for ; Tue, 23 Jun 2020 11:07:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18B4B2072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jngmQ-0006Mm-BC for qemu-devel@archiver.kernel.org; Tue, 23 Jun 2020 07:07:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jngla-0005Gh-M4; Tue, 23 Jun 2020 07:07:02 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:57018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnglY-0007rN-2A; Tue, 23 Jun 2020 07:07:02 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id D785E748DCC; Tue, 23 Jun 2020 13:06:56 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id B56E17482D3; Tue, 23 Jun 2020 13:06:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id B3F337482CE; Tue, 23 Jun 2020 13:06:56 +0200 (CEST) Date: Tue, 23 Jun 2020 13:06:56 +0200 (CEST) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [RFC PATCH v2 3/3] hw/misc/auxbus: Fix MOT/classic I2C mode In-Reply-To: <20200623063123.20776-4-f4bug@amsat.org> Message-ID: References: <20200623063123.20776-1-f4bug@amsat.org> <20200623063123.20776-4-f4bug@amsat.org> User-Agent: Alpine 2.22 (BSF 395 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-38403794-1592910416=:23200" Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/23 07:06:57 X-ACL-Warn: Detected OS = FreeBSD 9.x or newer [fuzzy] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Peter Maydell , Alistair Francis , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Frederic Konrad , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-38403794-1592910416=:23200 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Tue, 23 Jun 2020, Philippe Mathieu-Daudé wrote: > Since its introduction in commit 6fc7f77fd2 i2c_start_transfer() > uses incorrectly the direction of the transfer. Fix it now. > > Fixes: 6fc7f77fd2 ("introduce aux-bus") > Reported-by: BALATON Zoltan > Suggested-by: BALATON Zoltan One of the above is probably enough, maybe Reported-by because I wasn't sure what's the solution. I'm also happy with your changes to the whole series, thanks for fixing it. Regards, BALATON Zoltan > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC because untested (probably never was anyway) > Cc: Frederic Konrad > Cc: Alistair Francis > Cc: Peter Maydell > --- > hw/misc/auxbus.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c > index cef0d0d6d0..dc4a5dd10d 100644 > --- a/hw/misc/auxbus.c > +++ b/hw/misc/auxbus.c > @@ -141,7 +141,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address, > i2c_end_transfer(i2c_bus); > } > > - if (i2c_start_transfer(i2c_bus, address, is_write)) { > + if (i2c_start_transfer(i2c_bus, address, !is_write)) { > ret = AUX_I2C_NACK; > break; > } > @@ -172,7 +172,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address, > /* > * No transactions started.. > */ > - if (i2c_start_transfer(i2c_bus, address, is_write)) { > + if (i2c_start_transfer(i2c_bus, address, !is_write)) { > break; > } > } else if ((address != bus->last_i2c_address) || > @@ -181,7 +181,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address, > * Transaction started but we need to restart.. > */ > i2c_end_transfer(i2c_bus); > - if (i2c_start_transfer(i2c_bus, address, is_write)) { > + if (i2c_start_transfer(i2c_bus, address, !is_write)) { > break; > } > } > --3866299591-38403794-1592910416=:23200--