From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C04E6C4743E for ; Tue, 8 Jun 2021 05:08:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC1286124C for ; Tue, 8 Jun 2021 05:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229556AbhFHFJ5 (ORCPT ); Tue, 8 Jun 2021 01:09:57 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:45481 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbhFHFJ4 (ORCPT ); Tue, 8 Jun 2021 01:09:56 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623128884; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=2WqStAdtD5CJqMq8/pD/xnR0irJMgBYYsJ2cUkHzsVQ=; b=XoYqvbWMFbAPuN4pKftDk/8SwRHK7TpMqZ8JNYrvNUivMgyEhYfkEhs+LHOVU+4kt6t2mh/c 2llvWyWIHDTMYfjtv4TEVid1XSsy1kxjRNicjfVTUZ81G6R96fpBdMJrekb3wxLEU9Gn+1yl w0hVV/1N6PVchN0tbzF2oE9pcjU= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 60befb0be570c0561923bf39 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 08 Jun 2021 05:07:23 GMT Sender: wcheng=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 517D6C433F1; Tue, 8 Jun 2021 05:07:23 +0000 (UTC) Received: from [10.110.62.3] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: wcheng) by smtp.codeaurora.org (Postfix) with ESMTPSA id 92B35C433D3; Tue, 8 Jun 2021 05:07:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 92B35C433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=wcheng@codeaurora.org Subject: Re: [PATCH v9 0/5] Re-introduce TX FIFO resize for larger EP bursting To: Jack Pham , Greg KH Cc: balbi@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Thinh.Nguyen@synopsys.com References: <1621410561-32762-1-git-send-email-wcheng@codeaurora.org> <20210607160438.GA2975@jackp-linux.qualcomm.com> From: Wesley Cheng Message-ID: Date: Mon, 7 Jun 2021 22:07:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210607160438.GA2975@jackp-linux.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jack, On 6/7/2021 9:04 AM, Jack Pham wrote: > Hey Wesley, > > On Fri, Jun 04, 2021 at 01:54:48PM +0200, Greg KH wrote: >> On Wed, May 19, 2021 at 12:49:16AM -0700, Wesley Cheng wrote: >>> Changes in V9: >>> - Fixed incorrect patch in series. Removed changes in DTSI, as dwc3-qcom will >>> add the property by default from the kernel. >> >> This patch series has one build failure and one warning added: >> >> drivers/usb/dwc3/gadget.c: In function ‘dwc3_gadget_calc_tx_fifo_size’: >> drivers/usb/dwc3/gadget.c:653:45: warning: passing argument 1 of ‘dwc3_mdwidth’ makes pointer from integer without a cast [-Wint-conversion] >> 653 | mdwidth = dwc3_mdwidth(dwc->hwparams.hwparams0); >> | ~~~~~~~~~~~~~^~~~~~~~~~ >> | | >> | u32 {aka unsigned int} >> In file included from drivers/usb/dwc3/debug.h:14, >> from drivers/usb/dwc3/gadget.c:25: >> drivers/usb/dwc3/core.h:1493:45: note: expected ‘struct dwc3 *’ but argument is of type ‘u32’ {aka ‘unsigned int’} >> 1493 | static inline u32 dwc3_mdwidth(struct dwc3 *dwc) >> | ~~~~~~~~~~~~~^~~ > > I'm guessing you were previously using the DWC3_MDWIDTH macro which > operated on the 'hwparams0' reg value directly, but probably had to > switch it to the dwc3_mdwidth() inline function that Thinh had replaced > it with recently. Forgot to compile-test I bet? :) > Ah, looks like that's the case. I tried this on our internal branches, which didn't have Thinh's change, which is probably why it worked in the first place. Will fix this. >> drivers/usb/dwc3/dwc3-qcom.c: In function ‘dwc3_qcom_of_register_core’: >> drivers/usb/dwc3/dwc3-qcom.c:660:23: error: implicit declaration of function ‘of_add_property’; did you mean ‘of_get_property’? [-Werror=implicit-function-declaration] >> 660 | ret = of_add_property(dwc3_np, prop); >> | ^~~~~~~~~~~~~~~ >> | of_get_property > > Scratched my head on this one a bit, since 'of_add_property' is clearly > declared in which dwc3-qcom.c directly includes. Then I > looked closer and saw the declaration only in case of #ifdef CONFIG_OF > and noticed it doesn't have a corresponding no-op static inline > definition in the case of !CONFIG_OF. Again I'm guessing here that Greg > must have built on a non-OF config. We should probably include a patch > that adds the stub. > Nice catch, will add the stub. Thanks Wesley Cheng > Thanks, > Jack > -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project