From: Mario Limonciello <mario.limonciello@amd.com>
To: Suma Hegde <suma.hegde@amd.com>, platform-driver-x86@vger.kernel.org
Cc: ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com,
Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
Subject: Re: [PATCH 3/3] platform/x86/amd/hsmp: Make HSMP as default m
Date: Tue, 23 Apr 2024 12:17:33 -0500 [thread overview]
Message-ID: <aeb43442-a9d0-48fa-84fc-ec7ee773ee56@amd.com> (raw)
In-Reply-To: <20240423091434.2063246-4-suma.hegde@amd.com>
On 4/23/2024 04:14, Suma Hegde wrote:
> Making HSMP as "default m" in Kconfig, enables customers
> who rely on the standard distros to use the HSMP by dynamically
> loading it.
>
> Signed-off-by: Suma Hegde <suma.hegde@amd.com>
> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
> ---
> drivers/platform/x86/amd/hsmp/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/amd/hsmp/Kconfig b/drivers/platform/x86/amd/hsmp/Kconfig
> index 26096f901c22..9d3f422b3f81 100644
> --- a/drivers/platform/x86/amd/hsmp/Kconfig
> +++ b/drivers/platform/x86/amd/hsmp/Kconfig
> @@ -6,6 +6,7 @@
> config AMD_HSMP
> tristate "AMD HSMP Driver"
> depends on AMD_NB && X86_64
> + default m
I don't think Linus likes to see things default to 'm'. I don't see
anything in the platform-x86 subsystem that is defaulted 'm'.
IMO It's better to request the distros to enable it.
> help
> The driver provides a way for user space tools to monitor and manage
> system management functionality on EPYC server CPUs from AMD.
next prev parent reply other threads:[~2024-04-23 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 9:14 [PATCH 0/3] platform/x86/amd/hsmp: ACPI, Non-ACPI code split and other misc changes Suma Hegde
2024-04-23 9:14 ` [PATCH 1/3] platform/x86/amd/hsmp: Check HSMP support on AMD family of processors Suma Hegde
2024-04-23 17:11 ` Mario Limonciello
2024-04-25 10:03 ` Hegde, Suma
2024-04-23 9:14 ` [PATCH 2/3] platform/x86/amd/hsmp: Split the ACPI and non-ACPI code Suma Hegde
2024-04-23 17:13 ` Mario Limonciello
2024-04-23 9:14 ` [PATCH 3/3] platform/x86/amd/hsmp: Make HSMP as default m Suma Hegde
2024-04-23 17:17 ` Mario Limonciello [this message]
2024-04-25 6:59 ` Hegde, Suma
2024-04-23 17:07 ` [PATCH 0/3] platform/x86/amd/hsmp: ACPI, Non-ACPI code split and other misc changes Mario Limonciello
2024-04-29 8:50 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb43442-a9d0-48fa-84fc-ec7ee773ee56@amd.com \
--to=mario.limonciello@amd.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=naveenkrishna.chatradhi@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=suma.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.