From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59C6AC47094 for ; Thu, 10 Jun 2021 09:29:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16712613E3 for ; Thu, 10 Jun 2021 09:29:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16712613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8E2B6ECAC; Thu, 10 Jun 2021 09:29:19 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1F016ECAC; Thu, 10 Jun 2021 09:29:18 +0000 (UTC) IronPort-SDR: lYU02pjzMET51kcu/VjOJSp9DlC09jnMquCZ/GpeyakDqlBKjkGpAYC2m9d/fR/Sr++VrMi07D JEUvM5SnR7Ig== X-IronPort-AV: E=McAfee;i="6200,9189,10010"; a="205077983" X-IronPort-AV: E=Sophos;i="5.83,263,1616482800"; d="scan'208";a="205077983" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 02:29:16 -0700 IronPort-SDR: fBALTGYP5kqfgl7R2CnebFgmAIZDfjlLBbk+6+/rBQmIR7ca6HzVVI1kUwuDuGvY9tHSPUahcf z9vMievE1vfA== X-IronPort-AV: E=Sophos;i="5.83,263,1616482800"; d="scan'208";a="448653216" Received: from rabolton-mobl.ger.corp.intel.com (HELO [10.213.197.140]) ([10.213.197.140]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 02:29:14 -0700 To: Jason Ekstrand , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org References: <20210609212959.471209-1-jason@jlekstrand.net> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Thu, 10 Jun 2021 10:29:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210609212959.471209-1-jason@jlekstrand.net> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 0/5] dma-fence, i915: Stop allowing SLAB_TYPESAFE_BY_RCU for dma_fence X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , =?UTF-8?Q?Christian_K=c3=b6nig?= , Matthew Auld , Dave Airlie Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Ck9uIDA5LzA2LzIwMjEgMjI6MjksIEphc29uIEVrc3RyYW5kIHdyb3RlOgo+IEV2ZXIgc2luY2Ug MGVhZmVjNmQzMjQ0ICgiZHJtL2k5MTU6IEVuYWJsZSBsb2NrbGVzcyBsb29rdXAgb2YgcmVxdWVz dAo+IHRyYWNraW5nIHZpYSBSQ1UiKSwgdGhlIGk5MTUgZHJpdmVyIGhhcyB1c2VkIFNMQUJfVFlQ RVNBRkVfQllfUkNVIChpdAo+IHdhcyBjYWxsZWQgU0xBQl9ERVNUUk9ZX0JZX1JDVSBhdCB0aGUg dGltZSkgaW4gb3JkZXIgdG8gYWxsb3cgUkNVIG9uCj4gaTkxNV9yZXF1ZXN0LiAgQXMgbmlmdHkg YXMgU0xBQl9UWVBFU0FGRV9CWV9SQ1UgbWF5IGJlLCBpdCBjb21lcyB3aXRoCj4gc29tZSBzZXJp b3VzIGRpc2NsYWltZXJzLiAgSW4gcGFydGljdWxhciwgb2JqZWN0cyBjYW4gZ2V0IHJlY3ljbGVk IHdoaWxlCj4gUkNVIHJlYWRlcnMgYXJlIHN0aWxsIGluLWZsaWdodC4gIFRoaXMgY2FuIGJlIG9r IGlmIGV2ZXJ5b25lIHdobyB0b3VjaGVzCj4gdGhlc2Ugb2JqZWN0cyBrbm93cyBhYm91dCB0aGUg ZGlzY2xhaW1lcnMgYW5kIGlzIGNhcmVmdWwuICBIb3dldmVyLAo+IGJlY2F1c2Ugd2UndmUgY2hv c2VuIHRvIHVzZSBTTEFCX1RZUEVTQUZFX0JZX1JDVSBmb3IgaTkxNV9yZXF1ZXN0IGFuZAo+IGJl Y2F1c2UgaTkxNV9yZXF1ZXN0IGNvbnRhaW5zIGEgZG1hX2ZlbmNlLCB3ZSd2ZSBsZWFrZWQKPiBT TEFCX1RZUEVTQUZFX0JZX1JDVSBhbmQgaXRzIHdob2xlIHBpbGUgb2YgZGlzY2xhaW1lcnMgdG8g ZXZlcnkgZHJpdmVyCj4gaW4gdGhlIGtlcm5lbCB3aGljaCBtYXkgY29uc3VtZSBhIGRtYV9mZW5j ZS4KCkkgZG9uJ3QgdGhpbmsgdGhlIHBhcnQgYWJvdXQgbGVha2luZyBpcyB0cnVlLi4uCgo+IFdl J3ZlIHRyaWVkIHRvIGtlZXAgaXQgc29tZXdoYXQgY29udGFpbmVkIGJ5IGRvaW5nIG1vc3Qgb2Yg dGhlIGhhcmQgd29yawo+IHRvIHByZXZlbnQgYWNjZXNzIG9mIHJlY3ljbGVkIG9iamVjdHMgdmlh IGRtYV9mZW5jZV9nZXRfcmN1X3NhZmUoKS4KPiBIb3dldmVyLCBhIHF1aWNrIGdyZXAgb2Yga2Vy bmVsIHNvdXJjZXMgc2F5cyB0aGF0LCBvZiB0aGUgMzAgaW5zdGFuY2VzCj4gb2YgZG1hX2ZlbmNl X2dldF9yY3UqLCBvbmx5IDExIG9mIHRoZW0gdXNlIGRtYV9mZW5jZV9nZXRfcmN1X3NhZmUoKS4K PiBJdCdzIGxpa2VseSB0aGVyZSBiZWFyIHRyYXBzIGluIERSTSBhbmQgcmVsYXRlZCBzdWJzeXN0 ZW1zIGp1c3Qgd2FpdGluZwo+IGZvciBzb21lb25lIHRvIGFjY2lkZW50YWxseSBzdGVwIGluIHRo ZW0uCgouLi5iZWNhdXNlIGRtYV9mZW5jZV9nZXRfcmN1X3NhZmUgYXBlYXJzIHRvIGJlIGFib3V0 IHdoZXRoZXIgdGhlIAoqcG9pbnRlciogdG8gdGhlIGZlbmNlIGl0c2VsZiBpcyByY3UgcHJvdGVj dGVkLCBub3QgYWJvdXQgdGhlIGZlbmNlIApvYmplY3QgaXRzZWxmLgoKSWYgb25lIGhhcyBhIHN0 YWJsZSBwb2ludGVyIHRvIGEgZmVuY2UgZG1hX2ZlbmNlX2dldF9yY3UgaXMgSSB0aGluayAKZW5v dWdoIHRvIGRlYWwgd2l0aCBTTEFCX1RZUEVTQUZFX0JZX1JDVSB1c2VkIGJ5IGk5MTVfcmVxdWVz dCAoYXMgZG1hIApmZW5jZSBpcyBhIGJhc2Ugb2JqZWN0IHRoZXJlKS4gVW5sZXNzIHlvdSBmb3Vu ZCBhIGJ1ZyBpbiBycSBmaWVsZCAKcmVjeWNsaW5nLiBCdXQgYWNjZXNzIHRvIHRoZSBkbWEgZmVu Y2UgaXMgYWxsIHRpZ2h0bHkgY29udHJvbGxlZCBzbyBJIApkb24ndCBnZXQgd2hhdCBsZWFrcy4K Cj4gVGhpcyBwYXRjaCBzZXJpZXMgc3RvcHMgdXMgdXNpbmcgU0xBQl9UWVBFU0FGRV9CWV9SQ1Ug Zm9yIGk5MTVfcmVxdWVzdAo+IGFuZCwgaW5zdGVhZCwgZG9lcyBhbiBSQ1Utc2FmZSBzbGFiIGZy ZWUgdmlhIHJjdV9jYWxsKCkuICBUaGlzIHNob3VsZAo+IGxldCB1cyBrZWVwIG1vc3Qgb2YgdGhl IHBlcmYgYmVuZWZpdHMgb2Ygc2xhYiBhbGxvY2F0aW9uIHdoaWxlIGF2b2lkaW5nCj4gdGhlIGJl YXIgdHJhcHMgaW5oZXJlbnQgaW4gU0xBQl9UWVBFU0FGRV9CWV9SQ1UuICBJdCB0aGVuIHJlbW92 ZXMgc3VwcG9ydAo+IGZvciBTTEFCX1RZUEVTQUZFX0JZX1JDVSBmcm9tIGRtYV9mZW5jZSBlbnRp cmVseS4KCkFjY29yZGluZyB0byB0aGUgcmF0aW9uYWxlIGJlaGluZCBTTEFCX1RZUEVTQUZFX0JZ X1JDVSB0cmFkaXRpb25hbCBSQ1UgCmZyZWVpbmcgY2FuIGJlIGEgbG90IG1vcmUgY29zdGx5IHNv IEkgdGhpbmsgd2UgbmVlZCBhIGNsZWFyIApqdXN0aWZpY2F0aW9uIG9uIHdoeSB0aGlzIGNoYW5n ZSBpcyBiZWluZyBjb25zaWRlcmVkLgoKUmVnYXJkcywKClR2cnRrbwoKPiAKPiBOb3RlOiBUaGUg bGFzdCBwYXRjaCBpcyBsYWJsZWQgRE9OT1RNRVJHRS4gIFRoaXMgd2FzIGF0IERhbmllbCBWZXR0 ZXIncwo+IHJlcXVlc3QgYXMgd2UgbWF5IHdhbnQgdG8gbGV0IHRoaXMgYmFrZSBmb3IgYSBjb3Vw bGUgcmVsZWFzZXMgYmVmb3JlIHdlCj4gcmlwIG91dCBkbWFfZmVuY2VfZ2V0X3JjdV9zYWZlIGVu dGlyZWx5Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEphc29uIEVrc3RyYW5kIDxqYXNvbkBqbGVrc3Ry YW5kLm5ldD4KPiBDYzogSm9uIEJsb29tZmllbGQgPGpvbi5ibG9vbWZpZWxkQGludGVsLmNvbT4K PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBDYzogQ2hyaXN0 aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+IENjOiBEYXZlIEFpcmxpZSA8 YWlybGllZEByZWRoYXQuY29tPgo+IENjOiBNYXR0aGV3IEF1bGQgPG1hdHRoZXcuYXVsZEBpbnRl bC5jb20+Cj4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5p bnRlbC5jb20+Cj4gCj4gSmFzb24gRWtzdHJhbmQgKDUpOgo+ICAgIGRybS9pOTE1OiBNb3ZlIGlu dGVsX2VuZ2luZV9mcmVlX3JlcXVlc3RfcG9vbCB0byBpOTE1X3JlcXVlc3QuYwo+ICAgIGRybS9p OTE1OiBVc2UgYSBzaW1wbGVyIHNjaGVtZSBmb3IgY2FjaGluZyBpOTE1X3JlcXVlc3QKPiAgICBk cm0vaTkxNTogU3RvcCB1c2luZyBTTEFCX1RZUEVTQUZFX0JZX1JDVSBmb3IgaTkxNV9yZXF1ZXN0 Cj4gICAgZG1hLWJ1ZjogU3RvcCB1c2luZyBTTEFCX1RZUEVTQUZFX0JZX1JDVSBpbiBzZWxmdGVz dHMKPiAgICBET05PVE1FUkdFOiBkbWEtYnVmOiBHZXQgcmlkIG9mIGRtYV9mZW5jZV9nZXRfcmN1 X3NhZmUKPiAKPiAgIGRyaXZlcnMvZG1hLWJ1Zi9kbWEtZmVuY2UtY2hhaW4uYyAgICAgICAgIHwg ICA4ICstCj4gICBkcml2ZXJzL2RtYS1idWYvZG1hLXJlc3YuYyAgICAgICAgICAgICAgICB8ICAg NCArLQo+ICAgZHJpdmVycy9kbWEtYnVmL3N0LWRtYS1mZW5jZS1jaGFpbi5jICAgICAgfCAgMjQg Ky0tLQo+ICAgZHJpdmVycy9kbWEtYnVmL3N0LWRtYS1mZW5jZS5jICAgICAgICAgICAgfCAgMjcg Ky0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ZlbmNlLmMgfCAgIDQg Ky0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2VuZ2luZV9jcy5jIHwgICA4IC0t Cj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2FjdGl2ZS5oICAgICAgICB8ICAgNCArLQo+ ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMgICAgICAgfCAxNDcgKysrKysr KysrKysrLS0tLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0Lmgg ICAgICAgfCAgIDIgLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92bWEuYyAgICAgICAg ICAgfCAgIDQgKy0KPiAgIGluY2x1ZGUvZHJtL2RybV9zeW5jb2JqLmggICAgICAgICAgICAgICAg IHwgICA0ICstCj4gICBpbmNsdWRlL2xpbnV4L2RtYS1mZW5jZS5oICAgICAgICAgICAgICAgICB8 ICA1MCAtLS0tLS0tLQo+ICAgaW5jbHVkZS9saW51eC9kbWEtcmVzdi5oICAgICAgICAgICAgICAg ICAgfCAgIDQgKy0KPiAgIDEzIGZpbGVzIGNoYW5nZWQsIDExMCBpbnNlcnRpb25zKCspLCAxODAg ZGVsZXRpb25zKC0pCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15385C48BD1 for ; Thu, 10 Jun 2021 09:29:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD39C613E3 for ; Thu, 10 Jun 2021 09:29:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD39C613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E75E56ECAD; Thu, 10 Jun 2021 09:29:19 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1F016ECAC; Thu, 10 Jun 2021 09:29:18 +0000 (UTC) IronPort-SDR: lYU02pjzMET51kcu/VjOJSp9DlC09jnMquCZ/GpeyakDqlBKjkGpAYC2m9d/fR/Sr++VrMi07D JEUvM5SnR7Ig== X-IronPort-AV: E=McAfee;i="6200,9189,10010"; a="205077983" X-IronPort-AV: E=Sophos;i="5.83,263,1616482800"; d="scan'208";a="205077983" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 02:29:16 -0700 IronPort-SDR: fBALTGYP5kqfgl7R2CnebFgmAIZDfjlLBbk+6+/rBQmIR7ca6HzVVI1kUwuDuGvY9tHSPUahcf z9vMievE1vfA== X-IronPort-AV: E=Sophos;i="5.83,263,1616482800"; d="scan'208";a="448653216" Received: from rabolton-mobl.ger.corp.intel.com (HELO [10.213.197.140]) ([10.213.197.140]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 02:29:14 -0700 Subject: Re: [Intel-gfx] [PATCH 0/5] dma-fence, i915: Stop allowing SLAB_TYPESAFE_BY_RCU for dma_fence To: Jason Ekstrand , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org References: <20210609212959.471209-1-jason@jlekstrand.net> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: Date: Thu, 10 Jun 2021 10:29:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210609212959.471209-1-jason@jlekstrand.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , =?UTF-8?Q?Christian_K=c3=b6nig?= , Matthew Auld , Dave Airlie Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 09/06/2021 22:29, Jason Ekstrand wrote: > Ever since 0eafec6d3244 ("drm/i915: Enable lockless lookup of request > tracking via RCU"), the i915 driver has used SLAB_TYPESAFE_BY_RCU (it > was called SLAB_DESTROY_BY_RCU at the time) in order to allow RCU on > i915_request. As nifty as SLAB_TYPESAFE_BY_RCU may be, it comes with > some serious disclaimers. In particular, objects can get recycled while > RCU readers are still in-flight. This can be ok if everyone who touches > these objects knows about the disclaimers and is careful. However, > because we've chosen to use SLAB_TYPESAFE_BY_RCU for i915_request and > because i915_request contains a dma_fence, we've leaked > SLAB_TYPESAFE_BY_RCU and its whole pile of disclaimers to every driver > in the kernel which may consume a dma_fence. I don't think the part about leaking is true... > We've tried to keep it somewhat contained by doing most of the hard work > to prevent access of recycled objects via dma_fence_get_rcu_safe(). > However, a quick grep of kernel sources says that, of the 30 instances > of dma_fence_get_rcu*, only 11 of them use dma_fence_get_rcu_safe(). > It's likely there bear traps in DRM and related subsystems just waiting > for someone to accidentally step in them. ...because dma_fence_get_rcu_safe apears to be about whether the *pointer* to the fence itself is rcu protected, not about the fence object itself. If one has a stable pointer to a fence dma_fence_get_rcu is I think enough to deal with SLAB_TYPESAFE_BY_RCU used by i915_request (as dma fence is a base object there). Unless you found a bug in rq field recycling. But access to the dma fence is all tightly controlled so I don't get what leaks. > This patch series stops us using SLAB_TYPESAFE_BY_RCU for i915_request > and, instead, does an RCU-safe slab free via rcu_call(). This should > let us keep most of the perf benefits of slab allocation while avoiding > the bear traps inherent in SLAB_TYPESAFE_BY_RCU. It then removes support > for SLAB_TYPESAFE_BY_RCU from dma_fence entirely. According to the rationale behind SLAB_TYPESAFE_BY_RCU traditional RCU freeing can be a lot more costly so I think we need a clear justification on why this change is being considered. Regards, Tvrtko > > Note: The last patch is labled DONOTMERGE. This was at Daniel Vetter's > request as we may want to let this bake for a couple releases before we > rip out dma_fence_get_rcu_safe entirely. > > Signed-off-by: Jason Ekstrand > Cc: Jon Bloomfield > Cc: Daniel Vetter > Cc: Christian König > Cc: Dave Airlie > Cc: Matthew Auld > Cc: Maarten Lankhorst > > Jason Ekstrand (5): > drm/i915: Move intel_engine_free_request_pool to i915_request.c > drm/i915: Use a simpler scheme for caching i915_request > drm/i915: Stop using SLAB_TYPESAFE_BY_RCU for i915_request > dma-buf: Stop using SLAB_TYPESAFE_BY_RCU in selftests > DONOTMERGE: dma-buf: Get rid of dma_fence_get_rcu_safe > > drivers/dma-buf/dma-fence-chain.c | 8 +- > drivers/dma-buf/dma-resv.c | 4 +- > drivers/dma-buf/st-dma-fence-chain.c | 24 +--- > drivers/dma-buf/st-dma-fence.c | 27 +--- > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 8 -- > drivers/gpu/drm/i915/i915_active.h | 4 +- > drivers/gpu/drm/i915/i915_request.c | 147 ++++++++++++---------- > drivers/gpu/drm/i915/i915_request.h | 2 - > drivers/gpu/drm/i915/i915_vma.c | 4 +- > include/drm/drm_syncobj.h | 4 +- > include/linux/dma-fence.h | 50 -------- > include/linux/dma-resv.h | 4 +- > 13 files changed, 110 insertions(+), 180 deletions(-) >