From: Alex Shi <alex.shi@linux.alibaba.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Harry Wei <harryxiyou@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] docs/zh_CN: add translator info for embargoed-hardware-issues
Date: Fri, 20 Dec 2019 11:03:42 +0800 [thread overview]
Message-ID: <ac7c33f8-a00b-5360-b3b5-5c6f037590e9@linux.alibaba.com> (raw)
In-Reply-To: <20191219100534.707c0f36@lwn.net>
在 2019/12/20 上午1:05, Jonathan Corbet 写道:
> Alex Shi <alex.shi@linux.alibaba.com> wrote:
>
>> Let the people know where to complain... ;)
> So I'd like to apply all of these changes; they look fine to me given that
> I don't read Chinese...:) But I do have a couple of requests:
>
> - Please combine the changes into a single patch; adding the translated
> file, putting it into the toctree, and adding translator credit are all
> a single action, in the end. There is no reason to split them apart.
>
> - Changelogs like the above are not particularly helpful; please provide
> changelogs in the usual kernel style describing what was done and why.
>
Thanks for quick response, Jon!
I will modified all yesterday patches according to your suggestion and Cc to more Chinese as reviewer.
Thanks
Alex
next prev parent reply other threads:[~2019-12-20 3:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 9:10 [PATCH v2 1/4] docs/zh_CN: embargoed hardware issues Alex Shi
2019-12-18 9:10 ` [PATCH v2 2/4] docs/zh_CN: add translator info for embargoed-hardware-issues Alex Shi
2019-12-19 17:05 ` Jonathan Corbet
2019-12-20 3:03 ` Alex Shi [this message]
2019-12-18 9:10 ` [PATCH v2 3/4] docs/zh_CN: link embargoed-hardware-issue to index Alex Shi
2019-12-18 9:10 ` [PATCH v2 4/4] docs: add a link stub for embargoed hardware issue Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac7c33f8-a00b-5360-b3b5-5c6f037590e9@linux.alibaba.com \
--to=alex.shi@linux.alibaba.com \
--cc=corbet@lwn.net \
--cc=harryxiyou@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.