From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"briannorris@chromium.org" <briannorris@chromium.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>
Subject: Re: [bug report] iwlwifi: support REDUCE_TX_POWER_CMD version 6
Date: Tue, 8 Jun 2021 13:05:49 +0000 [thread overview]
Message-ID: <abe481f9cab8440c975331ff1a0d96b44c3eaeb8.camel@intel.com> (raw)
In-Reply-To: <CA+ASDXMS-qR2tgFzE7_cqtxLj9-TavbmghqGo0jDtHkbUB59Ow@mail.gmail.com>
On Wed, 2021-06-02 at 14:12 -0700, Brian Norris wrote:
> Signal boost:
> I've seen issues in this code in the past, as this is a custom format,
> the docs are non-public, it interacts with ACPI tables that Intel
> doesn't always get to review, and the parsing is all written in C...
> ...I also think Dan's static checker warning below is correct.
>
> Luca, has this been addressed yet?
You're right, the issue that Dan pointed out is indeed an issue. I'll
send a fix as explained in my previous email.
--
Cheers,
Luca.
next prev parent reply other threads:[~2021-06-08 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 9:08 [bug report] iwlwifi: support REDUCE_TX_POWER_CMD version 6 Dan Carpenter
2021-06-02 21:12 ` Brian Norris
2021-06-08 13:05 ` Coelho, Luciano [this message]
2021-06-08 13:04 ` Coelho, Luciano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe481f9cab8440c975331ff1a0d96b44c3eaeb8.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=briannorris@chromium.org \
--cc=dan.carpenter@oracle.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.