From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA484C4345F for ; Tue, 30 Apr 2024 04:37:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1fEw-00087x-MR; Tue, 30 Apr 2024 00:37:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1fEr-00087f-MU for qemu-devel@nongnu.org; Tue, 30 Apr 2024 00:37:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1fEm-0007ge-JX for qemu-devel@nongnu.org; Tue, 30 Apr 2024 00:37:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714451823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TFeWxa95KJxwgfMHRceC03NBS/A55G2iFitWOTs75X0=; b=LEVc22qP4O5zmLB8hecYD1PDIG/hWm0gp1QkuA/LVdV/RQnEInqqhxtwLtecvPDI+JU+5F 6mOB3qkh3txrucAwKMM5oT2ROAnC6Y4mhIysur/esKCh4iDnIpbH483+PTo1B9wDCCKWvs 1Yp+Upo2v6rUkHSxtb58357RO7xZEnU= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-4tFXlqMoOsqozIYptaGD-w-1; Tue, 30 Apr 2024 00:36:59 -0400 X-MC-Unique: 4tFXlqMoOsqozIYptaGD-w-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a5563ef10d4so327043666b.2 for ; Mon, 29 Apr 2024 21:36:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714451818; x=1715056618; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TFeWxa95KJxwgfMHRceC03NBS/A55G2iFitWOTs75X0=; b=KXy9+hwxYlRJAYQi5o4UwQnaEqoEKSl5bVMiCYwXTwNP3ubw4HIdsZ+aiaWZ36I3nR 8vfhHJfrmSAIwHERG8mMQdUnpDCxjL8gz9BuURc60y4OKJsd7z2bXesOsFewXpdL2b3g udq+HgcQp+0LHk0Bx3ukwyPxZUfvZtNmHiWkfTpkiGSaPh55IOIi507awMB2x95Evtnm jDrMKHunL5sfrZ11k8jNrsG8Iaty8lml0UJU2mtib5bWKZfMdnv1YR9ci5yhq8m4LZOU m291wfxt7H9OnEzykNYXD2Z+Vk1V5u1nwOFwBLldtkOAeP3Dw/8o+Zlsb8+9nIxu5udi wiIg== X-Forwarded-Encrypted: i=1; AJvYcCXXsn33g018NjS04fy22x/eyf95u1jz5GKixsKcsEw+53zo+lS7DlF5EvQ2rBFv2a6SvzxYvraenSh6/KyIsRP7jAcJmLQ= X-Gm-Message-State: AOJu0YzcpV8+unSOcSknFBvpdwA3XHQtUhapMQvOLm74QYdNUks1y0OC F279cOUq/DicNVA3rRqAJkqPiaVUDXTP4SnrUTiSB3g75uyQ/JI/fpGFdIyOM+yPOA9/Z9Gjvuf NSJ6J756jYnrswrot35Gq2fZWd14hY3jhv/yEoQJt/DQ1Eo9pv+MX X-Received: by 2002:a17:906:12c1:b0:a55:3707:781d with SMTP id l1-20020a17090612c100b00a553707781dmr7415408ejb.73.1714451818527; Mon, 29 Apr 2024 21:36:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwIDhUOQ+BnkUbmJI3lsjxQDdlC5+2ti9/05fnQAFqMbyh0fRHGF8E83iuctaz8LjG5Z/nRA== X-Received: by 2002:a17:906:12c1:b0:a55:3707:781d with SMTP id l1-20020a17090612c100b00a553707781dmr7415399ejb.73.1714451818143; Mon, 29 Apr 2024 21:36:58 -0700 (PDT) Received: from [192.168.0.9] (ip-109-43-179-34.web.vodafone.de. [109.43.179.34]) by smtp.gmail.com with ESMTPSA id a14-20020a1709065f8e00b00a559bbe8a00sm11831360eju.100.2024.04.29.21.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Apr 2024 21:36:57 -0700 (PDT) Message-ID: Date: Tue, 30 Apr 2024 06:36:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PULL 1/1] hw/ufs: Fix buffer overflow bug From: Thomas Huth To: Richard Henderson , Jeuk Kim , qemu-devel@nongnu.org, stefanha@redhat.com Cc: fam@euphon.net, pbonzini@redhat.com, qemu-block@nongnu.org, jeuk20.kim@samsung.com, j-young.choi@samsung.com, zheyuma97@gmail.com References: <46836849-4a23-4b7d-9940-5d3ce1f63a12@linaro.org> <5f2036ba-8fa6-4c75-9ac1-b782638027f5@redhat.com> Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <5f2036ba-8fa6-4c75-9ac1-b782638027f5@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.987, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 30/04/2024 06.32, Thomas Huth wrote: > On 30/04/2024 02.17, Richard Henderson wrote: >> On 4/28/24 20:25, Jeuk Kim wrote: >>> From: Jeuk Kim >>> >>> It fixes the buffer overflow vulnerability in the ufs device. >>> The bug was detected by sanitizers. >>> >>> You can reproduce it by: >>> >>> cat << EOF |\ >>> qemu-system-x86_64 \ >>> -display none -machine accel=qtest -m 512M -M q35 -nodefaults -drive \ >>> file=null-co://,if=none,id=disk0 -device ufs,id=ufs_bus -device \ >>> ufs-lu,drive=disk0,bus=ufs_bus -qtest stdio >>> outl 0xcf8 0x80000810 >>> outl 0xcfc 0xe0000000 >>> outl 0xcf8 0x80000804 >>> outw 0xcfc 0x06 >>> write 0xe0000058 0x1 0xa7 >>> write 0xa 0x1 0x50 >>> EOF >>> >>> Resolves: #2299 >>> Fixes: 329f16624499 ("hw/ufs: Support for Query Transfer Requests") >>> Reported-by: Zheyu Ma >>> Signed-off-by: Jeuk Kim >>> --- >>>   hw/ufs/ufs.c | 8 ++++++++ >>>   1 file changed, 8 insertions(+) >> >> For some reason this appears to cause failures on s390x: >> >>    https://gitlab.com/qemu-project/qemu/-/jobs/6740883283 >> >> All of the timeouts are new with this patch alone applied, >> and go away when reverted. >> >> I wasn't aware that these tests used ufs, but I have no >> other explanation... > > I don't know for sure, but the test failure might instead be related to the > problem that gets fixed by > https://lore.kernel.org/qemu-devel/20240429075908.36302-1-thuth@redhat.com/ > ... I'm preparing a pull request for that fix right now, so maybe you could > try this ufs pull request afterwards again to see whether the problem is fixed? Hmm, thinking about it twice, it cannot be the reason: That bug affects aarch64/arm only, and in above CI run, some other targets were failing. So the problem must be something else, indeed. Thomas