From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC8AC48BE5 for ; Fri, 11 Jun 2021 13:48:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F63E613BC for ; Fri, 11 Jun 2021 13:48:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231254AbhFKNt7 (ORCPT ); Fri, 11 Jun 2021 09:49:59 -0400 Received: from mout.gmx.net ([212.227.15.15]:58483 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbhFKNt6 (ORCPT ); Fri, 11 Jun 2021 09:49:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1623419269; bh=DQZaNV/hwR/W07WPShIulNh1yaAYynzVvSqkCu5eIgw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=gv0lZuxvaCRSdJw9ALtXnvPNz0RpqA3o41KJkHnFS3JAjFQN0NXaOJPZaJGXTvfRW cRfk/2pcZiRH3pYPujayL27QT3O3kXFTqWzKe5XgNOYazGOEsu4txjz+xPemm2fyAr YAjNey8WEfRl/vTGUIWJQwCexlRqJdpxyNvj5fgc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [0.0.0.0] ([45.77.180.217]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MMGRA-1laadG39Pi-00JMkH; Fri, 11 Jun 2021 15:47:49 +0200 Subject: Re: [PATCH] fs: btrfs: Disable BTRFS on platforms having 256K pages To: Christophe Leroy , Chris Mason , Josef Bacik , David Sterba Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-btrfs@vger.kernel.org, linux-hexagon@vger.kernel.org References: From: Qu Wenruo Message-ID: Date: Fri, 11 Jun 2021 21:47:39 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Oz7Y2Pd5S35Xo4teAX2NkhjMPqdlSnZ/X9M7YWX87qJwU02UdFX ONeoj46pv+uWradLLCwtNKQu4Cfv5yDkU6d45LZ5rCh+Y/quqn58yXkyyZr6GdAEf3NTJn6 z73x+9KfLF5ujCc1xo8aUcmcu5186WRbra////x4K2z4hYyKti1aXCI9uvZG1WZSdk0eBZg 3K2AT4odeGMgO39E5fGTw== X-UI-Out-Filterresults: notjunk:1;V03:K0:fbDu+ROrRRM=:IYeBLdyGVO30AKgwzEsXt4 gG4vovTO3s34V2CXIH3btu/cwpr/xRNSZG+86ds/zxDzdUzeY40v7unNYDxYiGA7hBEhp06gZ 1kh0kIajOPnDNXZAVoNo2FOE4IwWrLS+SZHAgNy5/Qtn2ZH+e0k2w4vxK5qwZqXbmsoMDtWqp UXyB3B9yrQ9TdOzaN33n0BsCpu3L4OIFkhnrzrlkRZtlyJHaPM29WA/0VjiuoEmeYKY7AsgvQ 4HmmPnPePgovVDoNVTnoM0EXHFE0HgeJOE3GBopX7zaiv4b+7mdkZOchAM7N+oPe/2+D11V3b grPqObRUO2Vaj6qSsKCDpaDm7ckE0eetfMVyIUo8eYRAo2FOGUBxnAha/i4mMeHmK/Ixi2Wro QqNJREbuFNxzTiy9lCExyyk5+qj47I0U8Vr6UjJP4v+7F7jCPWMv5322jS6HzhuVF6qHMKwaj snNtAHa6Y0m4yWBMDXM06lcKb8knZRcjlUFZJ5gc7tU6Gpi9UugylOx8y0aIE9p6ZEUQPiEzr I0xhXHfh8Z4DlQV3WqMoE7vBo72U28jK09FPto0cuB4c0w/yZc0WDc9DHcDIEgEKpTjeS6t5J rOUjuKHNoLdhJ5iAfr1vdC6Ky9Z3sHO4rCoD1z8K0Qp3/dzyvIltfn/s9eacKdU3FiYSHdvQd gzz0Nfo2C+qJwDoE53dbldbOe13ld81dkqDJDdUENA62MzUfSKtOTKpIX/p62q3q5WaEmGJy9 /0JFyC/XmdhnDmv1z5N8USGAd2GVZG2VhbJbxrCfUsNinG1zo3uiw+k11TdM4bkFMwQbQM5Jl /u/67Q/Ho25UIyVLHey18fBYKvh96vpKv75AJP37tclGlC5HGzfVPJbMrclCkLgMMbni5SIqe v5vNKDVvLukKc1mz4IZBSO/j7MtIA9oJH86d03cDEx3NBZKy0q2JwGTUCSG1xVsOWuiwjRftW VU0eBEflj0GCzVuXn0hh3YWX6IDFO5Q9crhZ2kqaFqZpAeO0l2YTp64iZkk0AvehQw46dkDmq RRbxqoCumDZJhsDVv9AgnK5xMorDPNl3UhgArmNyd5e5r9+lCZHV+XmRSyS1VpPf4mxdUWJ5k 4/5dGKThpbFBLPEr3JoynjRfYJJ9Xwl+O69Pqs/bVSPrGE6wvdes4F1gQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/10 =E4=B8=8B=E5=8D=881:23, Christophe Leroy wrote: > With a config having PAGE_SIZE set to 256K, BTRFS build fails > with the following message > > include/linux/compiler_types.h:326:38: error: call to '__compiletime_a= ssert_791' declared with attribute error: BUILD_BUG_ON failed: (BTRFS_MAX_= COMPRESSED % PAGE_SIZE) !=3D 0 > > BTRFS_MAX_COMPRESSED being 128K, BTRFS cannot support platforms with > 256K pages at the time being. > > There are two platforms that can select 256K pages: > - hexagon > - powerpc > > Disable BTRFS when 256K page size is selected. > > Reported-by: kernel test robot > Signed-off-by: Christophe Leroy > --- > fs/btrfs/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig > index 68b95ad82126..520a0f6a7d9e 100644 > --- a/fs/btrfs/Kconfig > +++ b/fs/btrfs/Kconfig > @@ -18,6 +18,8 @@ config BTRFS_FS > select RAID6_PQ > select XOR_BLOCKS > select SRCU > + depends on !PPC_256K_PAGES # powerpc > + depends on !PAGE_SIZE_256KB # hexagon I'm OK to disable page size other than 4K, 16K, 32K, 64K for now. Although for other reasons. Not only for the BUILD_BUG_ON(), but for the fact that btrfs only support 4K, 16K, 32K, 64K sectorsize, and requires PAGE_SIZE =3D=3D sector= size. Although we're adding subpage support, the subpage support only comes with 4K sectorsize on 64K page size. Until variable length version is introduced, 256K/128K page size won't be support. Thus I'm fine to disable BTRFS for any arch outside of the supported page sizes for now. Thanks, Qu > > help > Btrfs is a general purpose copy-on-write filesystem with extents, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42AF6C48BE5 for ; Fri, 11 Jun 2021 21:41:59 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78577610F8 for ; Fri, 11 Jun 2021 21:41:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78577610F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4G1vSP40j7z3c6M for ; Sat, 12 Jun 2021 07:41:57 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=k+vs4KqQ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmx.com (client-ip=212.227.15.19; helo=mout.gmx.net; envelope-from=quwenruo.btrfs@gmx.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=k+vs4KqQ; dkim-atps=neutral X-Greylist: delayed 315 seconds by postgrey-1.36 at boromir; Fri, 11 Jun 2021 23:53:23 AEST Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4G1j3l2vP4z30Fq for ; Fri, 11 Jun 2021 23:53:22 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1623419598; bh=DQZaNV/hwR/W07WPShIulNh1yaAYynzVvSqkCu5eIgw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=k+vs4KqQcKtkuYNuuFhylDdiMRatG90IsOywwFiHe7fmyC2zqLlUjacBItefCL/zm 86nxxfxwPu4BLjQnGSDHs51dYrB1q0ftxC+0Noq7StQh1NrvItXumZYM60EL7OF904 6AtpUFwl3mt3Pe9xnRzckIyyYWTjn1rupT7/UNZg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [0.0.0.0] ([45.77.180.217]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MMGRA-1laadG39Pi-00JMkH; Fri, 11 Jun 2021 15:47:49 +0200 Subject: Re: [PATCH] fs: btrfs: Disable BTRFS on platforms having 256K pages To: Christophe Leroy , Chris Mason , Josef Bacik , David Sterba References: From: Qu Wenruo Message-ID: Date: Fri, 11 Jun 2021 21:47:39 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Oz7Y2Pd5S35Xo4teAX2NkhjMPqdlSnZ/X9M7YWX87qJwU02UdFX ONeoj46pv+uWradLLCwtNKQu4Cfv5yDkU6d45LZ5rCh+Y/quqn58yXkyyZr6GdAEf3NTJn6 z73x+9KfLF5ujCc1xo8aUcmcu5186WRbra////x4K2z4hYyKti1aXCI9uvZG1WZSdk0eBZg 3K2AT4odeGMgO39E5fGTw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Giv8/+Lm8kk=:0aAPt1Dbk5O4U69QzYRTC9 Bi5Jlugde0oqnR29+zIrkXmtFeahPkwigZA9Jg8bj9X6PduvZNfDj8U1bI6tI03H/BQal7YSa We/Ec5idJDLjU7FqTT6fDEZzp0yHwnV63F+zNVexvKUaX3554y2Fyjls/NbCwcJR2aQzBuzvq iJBhnfbF++FRRbgKAViz58HWMPdSr2qvynkwSFv49e36Q5KznrUMxUKyrTCmyuLmtEoo7AYHK vb7chU3dtC9wzGXhg+XBtJSAcyPJZitDC6xoiecemgzS2bbAKDE1abeF5XbNS5YFuBoaEVKgZ mdzPSyg8jVF0p2Gq0sb3LvY+MZqtZ6YXW0Nfw6SBsOdw/B56TYz2CuRnGERZCHiCaa8Z421Gy wP5/ECymU8AXZT2JO9EtBXuUYWpon6YRqxuMdVseUcWPy2Awg2wBi50HF26GDjEiyKg9bgaic cRYsLNdeaX8Ltyc0URXlhObMJ6x88a4GrNEhT2Z+XnJkdVYZOUamZFiLuDqzHyvfCuc+4BlNM qQqkUIYSev/zh2uapk7KyEbAFOURbjcejr8j2vAHKCVo8UL2FKrbfFyc1TTY/7BvmSfwY3IjP dCQZRkHY10AMgZCRhdCthWTAoSodnPeHws8DN1wCG6WTbPtXkyKHYDo9oqOG/mW56bKDb8gQa eBweDVPGl9iSLmUGDkIELRo6Ijoj9Po8hOaKHfvi7Y9EfIACGLf75+LtlyICggYPu+DP94pna TCMeHg3dbAjvysgKJkjrMWKsEhsCYCZlzc+51zKKv/KbqEa8i1nKtAuymluYtEH8+Ox5xjxNW 2fK/x9Q4zMyKma4/G2muOhg00P/0llCLa0Lm6gfWXCewGxquqZ50ZAVtX9VVnzueT4SprU6V0 j20O3GwS8pFk55lxtJ1l3+YqTAqNJb9qvfITAM25IXzdSUQ5LT4ZIbUG59nAM9ZDYxv0Aiiq0 rK608IXW0uZiCet20Q1EVl0zQD52ocIJ/ZFqjvoe2R2UY/cNHMZYgUy/C7q6/YGIWt1+IrjBu 08UGrZGIlDvX05z7wu7NbV/uP+IjX8CZ8Yf/KXHDem79mT93jXLLABnyU5Rn76Ft3cMKBFo3r VylBtjX/cC0VBveSY8Pjx98vG9qFO+EM2YYVAY2RxbynEghOD1HnTCCrw== X-Mailman-Approved-At: Sat, 12 Jun 2021 07:41:32 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hexagon@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2021/6/10 =E4=B8=8B=E5=8D=881:23, Christophe Leroy wrote: > With a config having PAGE_SIZE set to 256K, BTRFS build fails > with the following message > > include/linux/compiler_types.h:326:38: error: call to '__compiletime_a= ssert_791' declared with attribute error: BUILD_BUG_ON failed: (BTRFS_MAX_= COMPRESSED % PAGE_SIZE) !=3D 0 > > BTRFS_MAX_COMPRESSED being 128K, BTRFS cannot support platforms with > 256K pages at the time being. > > There are two platforms that can select 256K pages: > - hexagon > - powerpc > > Disable BTRFS when 256K page size is selected. > > Reported-by: kernel test robot > Signed-off-by: Christophe Leroy > --- > fs/btrfs/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig > index 68b95ad82126..520a0f6a7d9e 100644 > --- a/fs/btrfs/Kconfig > +++ b/fs/btrfs/Kconfig > @@ -18,6 +18,8 @@ config BTRFS_FS > select RAID6_PQ > select XOR_BLOCKS > select SRCU > + depends on !PPC_256K_PAGES # powerpc > + depends on !PAGE_SIZE_256KB # hexagon I'm OK to disable page size other than 4K, 16K, 32K, 64K for now. Although for other reasons. Not only for the BUILD_BUG_ON(), but for the fact that btrfs only support 4K, 16K, 32K, 64K sectorsize, and requires PAGE_SIZE =3D=3D sector= size. Although we're adding subpage support, the subpage support only comes with 4K sectorsize on 64K page size. Until variable length version is introduced, 256K/128K page size won't be support. Thus I'm fine to disable BTRFS for any arch outside of the supported page sizes for now. Thanks, Qu > > help > Btrfs is a general purpose copy-on-write filesystem with extents, >