From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
devicetree@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Kousik Sanagavarapu <five231003@gmail.com>
Subject: Re: [PATCH] sh: j2: drop incorrect SPI controller max frequency property
Date: Mon, 29 Apr 2024 10:50:16 +0200 [thread overview]
Message-ID: <a105ba2b-a809-4a6e-84fc-f67eb11606be@linaro.org> (raw)
In-Reply-To: <d6b562f336b3750c131830a984b148ea7103ab0d.camel@physik.fu-berlin.de>
On 29/04/2024 10:16, John Paul Adrian Glaubitz wrote:
> On Fri, 2024-03-22 at 07:42 +0100, Krzysztof Kozlowski wrote:
>> The J2 SPI controller bindings never allowed spi-max-frequency property
>> in the controller node. Neither old spi-bus.txt bindings, nor new DT
>> schema allows it. Linux driver does not parse that property from
>> controller node, thus drop it from DTS as incorrect hardware
>> description. The SPI child device has already the same property with
>> the same value, so functionality should not be affected.
>>
>> Cc: Kousik Sanagavarapu <five231003@gmail.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> arch/sh/boot/dts/j2_mimas_v2.dts | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/sh/boot/dts/j2_mimas_v2.dts b/arch/sh/boot/dts/j2_mimas_v2.dts
>> index fa9562f78d53..faf884f53804 100644
>> --- a/arch/sh/boot/dts/j2_mimas_v2.dts
>> +++ b/arch/sh/boot/dts/j2_mimas_v2.dts
>> @@ -71,8 +71,6 @@ spi0: spi@40 {
>> #address-cells = <1>;
>> #size-cells = <0>;
>>
>> - spi-max-frequency = <25000000>;
>> -
>> reg = <0x40 0x8>;
>>
>> sdcard@0 {
>
> It seems that spi-bus.txt has been replaced by spi-controller.yaml now, so
> I think we should update the filename in the commit message, shouldn't we?
I think commit msg properly says what is old and what is new....
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-29 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 6:42 [PATCH] sh: j2: drop incorrect SPI controller max frequency property Krzysztof Kozlowski
2024-03-30 4:44 ` Rob Landley
2024-04-24 6:48 ` Krzysztof Kozlowski
2024-04-24 6:59 ` D. Jeff Dionne
2024-04-24 7:24 ` Krzysztof Kozlowski
2024-04-24 7:08 ` John Paul Adrian Glaubitz
2024-04-24 7:25 ` Krzysztof Kozlowski
2024-04-29 8:16 ` John Paul Adrian Glaubitz
2024-04-29 8:50 ` Krzysztof Kozlowski [this message]
2024-05-02 10:28 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a105ba2b-a809-4a6e-84fc-f67eb11606be@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=dalias@libc.org \
--cc=devicetree@vger.kernel.org \
--cc=five231003@gmail.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.