* [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog
@ 2024-04-20 19:51 Orgad Shaneh via GitGitGadget
2024-04-21 18:29 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Orgad Shaneh via GitGitGadget @ 2024-04-20 19:51 UTC (permalink / raw
To: git; +Cc: Orgad Shaneh, Orgad Shaneh
From: Orgad Shaneh <orgads@gmail.com>
Signed-off-by: Orgad Shaneh <orgads@gmail.com>
---
docs: remove duplicate entry and fix typo in 2.45 changelog
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1711%2Forgads%2Fchangelog-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1711/orgads/changelog-v1
Pull-Request: https://github.com/git/git/pull/1711
Documentation/RelNotes/2.45.0.txt | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/Documentation/RelNotes/2.45.0.txt b/Documentation/RelNotes/2.45.0.txt
index 0570dcd8773..38458664407 100644
--- a/Documentation/RelNotes/2.45.0.txt
+++ b/Documentation/RelNotes/2.45.0.txt
@@ -100,7 +100,7 @@ Performance, Internal Implementation, Development Support etc.
* The way placeholders are to be marked-up in documentation have been
specified; use "_<placeholder>_" to typeset the word inside a pair
- of <angle-brakets> emphasized.
+ of <angle-brackets> emphasized.
* "git --no-lazy-fetch cmd" allows to run "cmd" while disabling lazy
fetching of objects from the promisor remote, which may be handy
@@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc.
clean.requireForce has been simplified, together with the
documentation.
- * The code to iterate over refs with the reftable backend has seen
- some optimization.
-
* Uses of xwrite() helper have been audited and updated for better
error checking and simpler code.
base-commit: ae3196a5ea84a9e88991d576020cf66512487088
--
gitgitgadget
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog
2024-04-20 19:51 [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog Orgad Shaneh via GitGitGadget
@ 2024-04-21 18:29 ` Junio C Hamano
2024-04-22 5:51 ` Patrick Steinhardt
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2024-04-21 18:29 UTC (permalink / raw
To: Orgad Shaneh via GitGitGadget; +Cc: git, Orgad Shaneh
"Orgad Shaneh via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Orgad Shaneh <orgads@gmail.com>
>
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> ---
>
> Documentation/RelNotes/2.45.0.txt | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/Documentation/RelNotes/2.45.0.txt b/Documentation/RelNotes/2.45.0.txt
> index 0570dcd8773..38458664407 100644
> --- a/Documentation/RelNotes/2.45.0.txt
> +++ b/Documentation/RelNotes/2.45.0.txt
> @@ -100,7 +100,7 @@ Performance, Internal Implementation, Development Support etc.
>
> * The way placeholders are to be marked-up in documentation have been
> specified; use "_<placeholder>_" to typeset the word inside a pair
> - of <angle-brakets> emphasized.
> + of <angle-brackets> emphasized.
Thanks.
> @@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc.
> clean.requireForce has been simplified, together with the
> documentation.
>
> - * The code to iterate over refs with the reftable backend has seen
> - some optimization.
> -
> * Uses of xwrite() helper have been audited and updated for better
> error checking and simpler code.
Interesting. It is likely that we had two topics that did things
that summarised down to the same description. They are
448a74e1 (Merge branch 'ps/reftable-iteration-perf-part2', 2024-03-14)
9f67cbd0 (Merge branch 'ps/reftable-iteration-perf', 2024-02-26)
I do not know which is better between removing the second entry
(which is what this patch is doing, as the entries are in
chronological order of the topics' graduation to 'master'), or
amending it to say "has seen some more optimization".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog
2024-04-21 18:29 ` Junio C Hamano
@ 2024-04-22 5:51 ` Patrick Steinhardt
0 siblings, 0 replies; 3+ messages in thread
From: Patrick Steinhardt @ 2024-04-22 5:51 UTC (permalink / raw
To: Junio C Hamano; +Cc: Orgad Shaneh via GitGitGadget, git, Orgad Shaneh
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
On Sun, Apr 21, 2024 at 11:29:10AM -0700, Junio C Hamano wrote:
> "Orgad Shaneh via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Orgad Shaneh <orgads@gmail.com>
> >
> > Signed-off-by: Orgad Shaneh <orgads@gmail.com>
> > @@ -110,9 +110,6 @@ Performance, Internal Implementation, Development Support etc.
> > clean.requireForce has been simplified, together with the
> > documentation.
> >
> > - * The code to iterate over refs with the reftable backend has seen
> > - some optimization.
> > -
> > * Uses of xwrite() helper have been audited and updated for better
> > error checking and simpler code.
>
> Interesting. It is likely that we had two topics that did things
> that summarised down to the same description. They are
>
> 448a74e1 (Merge branch 'ps/reftable-iteration-perf-part2', 2024-03-14)
> 9f67cbd0 (Merge branch 'ps/reftable-iteration-perf', 2024-02-26)
>
> I do not know which is better between removing the second entry
> (which is what this patch is doing, as the entries are in
> chronological order of the topics' graduation to 'master'), or
> amending it to say "has seen some more optimization".
Squashing these into a single entry should be fine in my opinion. The
split was artificial anyway to make the review process easier.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-22 5:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-20 19:51 [PATCH] docs: remove duplicate entry and fix typo in 2.45 changelog Orgad Shaneh via GitGitGadget
2024-04-21 18:29 ` Junio C Hamano
2024-04-22 5:51 ` Patrick Steinhardt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.