From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
mimperial@lenovo.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com,
bard.liao@intel.com, yung-chuan.liao@linux.intel.com,
kevin-lu@ti.com, cameron.berkenpas@gmail.com, tiwai@suse.de,
baojun.xu@ti.com, soyer@irl.hu, Baojun.Xu@fpt.com
Subject: Re: [PATCH v1] ALSA: ASoc/tas2781: fixed wrong loading calibrated data sequence
Date: Mon, 29 Apr 2024 12:00:30 +0300 [thread overview]
Message-ID: <Zi9hrs3G3i4dNtro@smile.fi.intel.com> (raw)
In-Reply-To: <20240427052858.265-1-shenghao-ding@ti.com>
On Sat, Apr 27, 2024 at 01:28:57PM +0800, Shenghao Ding wrote:
In the Subject: fixed --> Fix
> Calibrated data will be set to default after loading dsp config params,
DSP
> which will cause speaker protection work abnormally. Reload calibrated
> data after loading dsp config params.
DSP
...
> -// Copyright (C) 2022 - 2023 Texas Instruments Incorporated
> +// Copyright (C) 2022 - 2024 Texas Instruments Incorporated
> -// Copyright 2023 Texas Instruments, Inc.
> +// Copyright 2023 - 2024 Texas Instruments, Inc.
Seems unrelated changes, but harmless.
...
> + load_calib_data(tas_priv,
> + &(cal->dev_data));
Why do you need parentheses for & (dereference) operator?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-04-29 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 5:28 [PATCH v1] ALSA: ASoc/tas2781: fixed wrong loading calibrated data sequence Shenghao Ding
2024-04-29 9:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zi9hrs3G3i4dNtro@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=cameron.berkenpas@gmail.com \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mimperial@lenovo.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.