From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: sfp-bus: constify link_modes to sfp_select_interface()
Date: Mon, 29 Apr 2024 09:58:46 +0100 [thread overview]
Message-ID: <Zi9hRst2uBGgbWo9@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240429082511.h32rsx5s3iu2jlpe@DEN-DL-M70577>
On Mon, Apr 29, 2024 at 08:25:11AM +0000, Daniel Machon wrote:
> > @@ -593,7 +593,7 @@ static inline void sfp_parse_support(struct sfp_bus *bus,
> > }
> >
> > static inline phy_interface_t sfp_select_interface(struct sfp_bus *bus,
> > - unsigned long *link_modes)
> > + const unsigned long *link_modes)
>
> There seem to be some misalignment on the opening brace - at least in my
> editor..
It's intentional to avoid going over column 80 (I use an 80 column wide
terminal to edit.) It's either that or the thing gets wrapped differently
(which then means one loses the return code when grepping.) From a
readability point of view, this is what I prefer.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-04-29 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 14:51 [PATCH net-next] net: sfp-bus: constify link_modes to sfp_select_interface() Russell King (Oracle)
2024-04-29 8:25 ` Daniel Machon
2024-04-29 8:58 ` Russell King (Oracle) [this message]
2024-04-30 13:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zi9hRst2uBGgbWo9@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.