From: Keith Busch <kbusch@kernel.org>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org, hch@lst.de,
gjoyce@linux.ibm.com, axboe@fb.com,
Srimannarayana Murthy Maram <msmurthy@imap.linux.ibm.com>
Subject: Re: [PATCH] nvme: cancel pending I/O if nvme controller is in terminal state
Date: Mon, 29 Apr 2024 09:51:38 +0100 [thread overview]
Message-ID: <Zi9fmr3wmcFlqxt3@kbusch-mbp.mynextlight.net> (raw)
In-Reply-To: <20240425140303.1599437-1-nilay@linux.ibm.com>
On Thu, Apr 25, 2024 at 07:33:00PM +0530, Nilay Shroff wrote:
> While I/O is running, if the pci bus error occurs then
> in-flight I/O can not complete. Worst, if at this time,
> user (logically) hot-unplug the nvme disk then the
> nvme_remove() code path can't forward progress until
> in-flight I/O is cancelled. So these sequence of events
> may potentially hang hot-unplug code path indefinitely.
> This patch helps cancel the pending/in-flight I/O from the
> nvme request timeout handler in case the nvme controller
> is in the terminal (DEAD/DELETING/DELETING_NOIO) state and
> that helps nvme_remove() code path forward progress and
> finish successfully.
>
> Link: https://lore.kernel.org/all/199be893-5dfa-41e5-b6f2-40ac90ebccc4@linux.ibm.com/
> Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
Thanks, applied to nvme-6.9.
prev parent reply other threads:[~2024-04-29 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 14:03 [PATCH] nvme: cancel pending I/O if nvme controller is in terminal state Nilay Shroff
2024-04-28 8:17 ` Sagi Grimberg
2024-04-29 8:51 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zi9fmr3wmcFlqxt3@kbusch-mbp.mynextlight.net \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=gjoyce@linux.ibm.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=msmurthy@imap.linux.ibm.com \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.