From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E49174D9FF for ; Mon, 15 Apr 2024 09:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713174300; cv=none; b=L7N6wlwsDo6OQ3S4BGFxbbArp/vHUxRMj/1MV5y6pT51tQCg17FrovRzPX4gQryHFl83ZJEa41FizxyE57PWEx+8JDWaimuiwaSnkRtXn9VIBYj4oyjCwB8+fYLo1XawP78QcIhBmKREVVmWkkS7CzwN4jeSM9p96XixTKnVopA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713174300; c=relaxed/simple; bh=VtwuyubYUYZ4mi1Ujdo1t+RKF4tKBpowGisw1EN28aI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qNM/Y1TlXLQfXiym/2Eg4j3XKel5TJJykSFiOch16Io8/b2qsyUGJ1LtOi0CQXhrp5ZTEdqngoJBB1PYglsvFRFqDO82YxG76GmBPoFWmdcy/11xKY7yrhGLT7VBTVZrxUxRRZTQDKjiwjw7k9A0krewuqhcPSHF31+AmjhdMlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=I2DeG4QO; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="I2DeG4QO" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3dwAMvNpKeQ9PatZlAuEMPbAqrw8p29gML5z9fKjLW4=; b=I2DeG4QOJP6IjEQADh7wSKhTjo Y5YVYaMxGCKJTzJMVB2H96z44xgVc+bol/xfbV/wl22KcAYKtX41YnFvNRSFeOVwtu3XBfsbSDEA7 lUQQhFZ20aiqxcFYYv5EBOeeKucw41NswFlZyrRVCDFZXqczEpxyPwKkVLes/iVoDFmKlaTM+WgDn CU3beLRvx2cDdHtoixy9tzmAi0ptBAg6EFfji/pabx9EqiLdQuzZA8rlK0fHcuVF8mgvP9qeyQDVQ 7mahxUdsejWTTat/6Aq/aErtF8I1JUJhXt1P6kcn3fZerv8+cVnslF1wlAXIi6iq2RNSVHScdRSPN O2Cvg27w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42636) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rwItN-0005vm-11; Mon, 15 Apr 2024 10:44:49 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rwItM-00026W-TT; Mon, 15 Apr 2024 10:44:48 +0100 Date: Mon, 15 Apr 2024 10:44:48 +0100 From: "Russell King (Oracle)" To: Tetsuo Handa Cc: Mark Rutland , Kees Cook , Linux ARM , syzbot , linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [hardening?] [mm?] BUG: bad usercopy in fpa_set Message-ID: References: <0000000000004cf5c205faf1c7f3@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) On Mon, Apr 15, 2024 at 06:38:33PM +0900, Tetsuo Handa wrote: > On 2024/04/15 18:02, Mark Rutland wrote: > > 08626a6056aad824 ("arm: Implement thread_struct whitelist for hardened usercopy") > > > > That commit says that all accesses are bounce-buffered and bypass the check, > > but AFAICT the fpa_set() code hasn't changed since then, so either that was > > wrong or the user_regset_copyin() code has changed. > > Then, can we go with https://lkml.kernel.org/r/0b49d91b-511f-449e-b7c3-93b2ccce6c49@I-love.SAKURA.ne.jp ? Have you visited that URL? It doesn't point to an email containing a patch, so sorry, I don't know what patch you're referring to. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7180DC4345F for ; Mon, 15 Apr 2024 09:45:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JjXN88+L/ZzIu8MhUjhnyWo+FnOBiTRi6uZCejCaANU=; b=fHOf92MUaINCmW ixSE6rhVxa4wN/mlenGPRYPMKmeu39lbNAPvb4FGlhtVtJaX5AMaajPTIvaR/RPZ0k2J1TVbM2QGf k2K67hQQyPi/is2siehhoE4Pk4HY1traEDYq60EFNIX44namrUeGqkrmyOON10ukKc4QCekgZO6Ny A9osQ/6wxMOv6Gw87KKfvurLiZF+vGllXhaFE6mlMmtk2lxKT3DN0Vwuj44p2KoYNU+Xmc4gYloMg n1OFrkpRXw0jHQeIQ7kJjtnqV5RmbwwA/LDkWEc09WllLPROz/Lmvk+JuZCfRod8jbokZoY6C04kN p9bgcsDRa8kFUzI1L+4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwItY-00000007kel-3SNJ; Mon, 15 Apr 2024 09:45:00 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwItV-00000007kcy-0zW0 for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 09:44:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3dwAMvNpKeQ9PatZlAuEMPbAqrw8p29gML5z9fKjLW4=; b=I2DeG4QOJP6IjEQADh7wSKhTjo Y5YVYaMxGCKJTzJMVB2H96z44xgVc+bol/xfbV/wl22KcAYKtX41YnFvNRSFeOVwtu3XBfsbSDEA7 lUQQhFZ20aiqxcFYYv5EBOeeKucw41NswFlZyrRVCDFZXqczEpxyPwKkVLes/iVoDFmKlaTM+WgDn CU3beLRvx2cDdHtoixy9tzmAi0ptBAg6EFfji/pabx9EqiLdQuzZA8rlK0fHcuVF8mgvP9qeyQDVQ 7mahxUdsejWTTat/6Aq/aErtF8I1JUJhXt1P6kcn3fZerv8+cVnslF1wlAXIi6iq2RNSVHScdRSPN O2Cvg27w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42636) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rwItN-0005vm-11; Mon, 15 Apr 2024 10:44:49 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rwItM-00026W-TT; Mon, 15 Apr 2024 10:44:48 +0100 Date: Mon, 15 Apr 2024 10:44:48 +0100 From: "Russell King (Oracle)" To: Tetsuo Handa Cc: Mark Rutland , Kees Cook , Linux ARM , syzbot , linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [hardening?] [mm?] BUG: bad usercopy in fpa_set Message-ID: References: <0000000000004cf5c205faf1c7f3@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_024457_312605_F5DDFF76 X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2024 at 06:38:33PM +0900, Tetsuo Handa wrote: > On 2024/04/15 18:02, Mark Rutland wrote: > > 08626a6056aad824 ("arm: Implement thread_struct whitelist for hardened usercopy") > > > > That commit says that all accesses are bounce-buffered and bypass the check, > > but AFAICT the fpa_set() code hasn't changed since then, so either that was > > wrong or the user_regset_copyin() code has changed. > > Then, can we go with https://lkml.kernel.org/r/0b49d91b-511f-449e-b7c3-93b2ccce6c49@I-love.SAKURA.ne.jp ? Have you visited that URL? It doesn't point to an email containing a patch, so sorry, I don't know what patch you're referring to. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel