From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B21B38F4E for ; Wed, 10 Apr 2024 09:58:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712743099; cv=none; b=AFgg7MEPFG72vCepyJecKJTjGMJoV4XexQGPMqz5hKEpRqZuL3o2GvmbJ6j/DuQ69386ptWtfUd5OrJWZKCeJ/HoQRb0f5ys15T8ZRYYIpDd6XfVKwEyhPNooGs1bL/11DVtm2wufRI8azW5o5FZN2rWp7Z6+qnKbnE3sl2aGWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712743099; c=relaxed/simple; bh=8kljXWF9cM8kvyiMlAHuhlM0UfE1pXGPxynSESs+2dQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OIGHEOeN/tK7bXKWOnbQEzwzVxTLqFoFqOndoRuO/21ewZ3CkNekjilsz/m3Vb8SsEHYBKDSEZQDd3W4W13FyoW8Tly/13H3jWyQ9lxgx561au9fwXmMkn4MTtph5baKppO5EmX3sX9nNkE47q364VPHJVLvqIyzMghJn6AbyOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dF83plSu; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dF83plSu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712743098; x=1744279098; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8kljXWF9cM8kvyiMlAHuhlM0UfE1pXGPxynSESs+2dQ=; b=dF83plSuPiXQTi3r0FozgRuVDqvJj1xVNE+uczju8F+bSStlLCthNoUJ kPkrmMO42VLInL+PCBmk1BVTRhHuIuwtmGD0iUIRO4izjVUN+wczp6osn A6GUVEnfM/U0RG/jxN3jo9bqqkpXgNwlvdNMWEgZe7ixKxcKBibHbEEeW Ujd1uayMLRuJEYGZfZ44NTS3a8ZSeRW3RAyVYdQJhunjwBD59QMCqxsTK fWjQx3gkWqdNO0vq+yROXBlsJZhhqipZNbcHn1JQGqDRK+XSvuPvCBORb N7szOGWj+sdKRlLaGrRhkr8PVTIPxXhnwJXibX0xGs3Y7k0RBI6gknCdZ Q==; X-CSE-ConnectionGUID: zYT2Wya7TdCen8VyNCRJeg== X-CSE-MsgGUID: s60Y++N1SdCsg2MxMG27Uw== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="25601425" X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="25601425" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 02:58:17 -0700 X-CSE-ConnectionGUID: aYy+foZLSn2r2UUZc3n3tg== X-CSE-MsgGUID: iIgP4Th0SfSAleBxwmoMpg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="20542691" Received: from unknown (HELO mev-dev) ([10.237.112.144]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 02:58:15 -0700 Date: Wed, 10 Apr 2024 11:57:55 +0200 From: Michal Swiatkowski To: "Buvaneswaran, Sujai" Cc: "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , Marcin Szycik , "Kubiak, Michal" Subject: Re: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on all profiles Message-ID: References: <20240312105259.2450-1-michal.swiatkowski@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Apr 05, 2024 at 10:43:04AM +0200, Michal Swiatkowski wrote: > On Mon, Apr 01, 2024 at 09:28:30AM +0000, Buvaneswaran, Sujai wrote: > > > -----Original Message----- > > > From: Michal Swiatkowski > > > Sent: Friday, March 29, 2024 1:56 PM > > > To: Buvaneswaran, Sujai > > > Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; Marcin Szycik > > > ; Kubiak, Michal > > > Subject: Re: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on all > > > profiles > > > > > > On Mon, Mar 25, 2024 at 06:36:56AM +0000, Buvaneswaran, Sujai wrote: > > > > > -----Original Message----- > > > > > From: Intel-wired-lan On Behalf > > > > > Of Michal Swiatkowski > > > > > Sent: Tuesday, March 12, 2024 4:23 PM > > > > > To: intel-wired-lan@lists.osuosl.org > > > > > Cc: netdev@vger.kernel.org; Marcin Szycik > > > > > ; Kubiak, Michal > > > > > ; Michal Swiatkowski > > > > > > > > > > Subject: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on > > > > > all profiles > > > > > > > > > > A simple non-tunnel rule (e.g. matching only on destination MAC) in > > > > > hardware will be hit only if the packet isn't a tunnel. In software > > > > > execution of the same command, the rule will match both tunnel and > > > non-tunnel packets. > > > > > > > > > > Change the hardware behaviour to match tunnel and non-tunnel packets > > > > > in this case. Do this by considering all profiles when adding > > > > > non-tunnel rule (rule not added on tunnel, or not redirecting to tunnel). > > > > > > > > > > Example command: > > > > > tc filter add dev pf0 ingress protocol ip flower skip_sw action mirred \ > > > > > egress redirect dev pr0 > > > > > > > > > > It should match also tunneled packets, the same as command with > > > > > skip_hw will do in software. > > > > > > > > > > Fixes: 9e300987d4a8 ("ice: VXLAN and Geneve TC support") > > > > > Reviewed-by: Marcin Szycik > > > > > Reviewed-by: Michal Kubiak > > > > > Signed-off-by: Michal Swiatkowski > > > > > > > > > > --- > > > > > v1 --> v2: > > > > > * fix commit message sugested by Marcin > > > > > --- > > > > > drivers/net/ethernet/intel/ice/ice_tc_lib.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > Hi, > > > > > > > > We are seeing error while adding HW tc rules on PF with the latest net- > > > queue patches. This issue is blocking the validation of latest net-queue > > > Switchdev patches. > > > > > > > > + tc filter add dev ens5f0np0 ingress protocol ip prio 1 flower > > > > + src_mac b4:96:91:9f:65:58 dst_mac 52:54:00:00:16:01 skip_sw action > > > > + mirred egress redirect dev eth0 > > > > Error: ice: Unable to add filter due to error. > > > > We have an error talking to the kernel > > > > + tc filter add dev ens5f0np0 ingress protocol ip prio 1 flower > > > > + src_mac b4:96:91:9f:65:58 dst_mac 52:54:00:00:16:02 skip_sw action > > > > + mirred egress redirect dev eth1 > > > > Error: ice: Unable to add filter due to error. > > > > We have an error talking to the kernel > > > > > > Hi, > > > > > > The same command is working fine on my setup. I suspect that it isn't related > > > to this patch. The change is only in command validation, there is no > > > functional changes here that can cause error during adding filters which > > > previously was working fine. > > > > > > Can you share more information about the setup? It was the first filter added > > > on the PF? Did you do sth else before checking tc? > > > > Hi Michal, > > I have used the setup with latest upstream dev-queue kernel and this issue is observed while adding HW tc rules on PF using > > 'Script A' from below link. > > https://edc.intel.com/content/www/us/en/design/products/ethernet/appnote-e810-eswitch-switchdev-mode-config-guide/script-a-switchdev-mode-with-linux-bridge-configuration/ > > > > This issue is reproducible on two of our setups with latest upstream kernel - 6.9.0-rc1+. Please check and let me know if more information is needed. > > > > I tried script from the link and it is working. I am aware of the > problem when the same rule is being added with different destination. > Are you sure there are no more exsisting rule before calling the script? > In the script VFs are removed, but PF qdisc isn't removed. Old rule can > exsist there. I suggest to add sth like, before adding new qdiscs: > $tc qdisc del dev $PF1 ingress > > I tested on 6.9.0-rc1+ kernel. > I have found the problem. I was using different DDP package. The problem is with lack of free indexes in profiles when matching is done on both tunnel and not tunnel packet (so all profiles are considered). For now please Tony remove it from next-queue. I am trying to figure out how to implement matching on all profiles using less indexes. If I find the correct way I will submit new patch. Thanks > Thanks, > Michal > > Thanks, > > Sujai B > > > > > > Thanks, > > > Michal > > > > > > > > Thanks, > > > > Sujai B From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 378EFCD11C2 for ; Wed, 10 Apr 2024 09:58:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E4BFB60645; Wed, 10 Apr 2024 09:58:23 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id NCpT69iV3Yrk; Wed, 10 Apr 2024 09:58:23 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D4C57607E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1712743102; bh=DGSz3y2VLz8gFlf5o29sSobWJkbWvTaRCKfvwBZdJIY=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=8ZEiHZe9kxBgnexAV4rbli1lLUVbXs1dzqOlUQ4RvsM8jQlGAFW7hLbxRVUpkfuGq sU8798tv2WRVxng7ESkCSCCIMjFs38U8hg68j5A5Wm6M4+D/PDkBBJ5dG54BXiClIq tPWWmfK4sH8fy8RLc+BU7srtY+iQRvVLR019WePWopgBLSGQb3u535xnNx9rMCjm79 YEHK65vBjv/vnnUqHlGc7ELjbifGmmMs3AXDpH8fBdp5H5s44NKWQmkT/nMKYSm4kQ +3DvQIxM6ujgtPtiBauCNFSEa/atlzeSKpZ4MbT4AYaTm7ZzMcrgC0DUOvoSKdQ0fH aISz7KmgJnDqg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id D4C57607E0; Wed, 10 Apr 2024 09:58:22 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 3B7631BF275 for ; Wed, 10 Apr 2024 09:58:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2728E607E0 for ; Wed, 10 Apr 2024 09:58:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 6Uo4Vrt-pWrn for ; Wed, 10 Apr 2024 09:58:18 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=192.198.163.8; helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 109C960645 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 109C960645 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by smtp3.osuosl.org (Postfix) with ESMTPS id 109C960645 for ; Wed, 10 Apr 2024 09:58:17 +0000 (UTC) X-CSE-ConnectionGUID: Zqdw8k9BQAKlZfpoDIjeXg== X-CSE-MsgGUID: tYDStekJQP+r74vLgBDVEA== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="25601426" X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="25601426" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 02:58:17 -0700 X-CSE-ConnectionGUID: aYy+foZLSn2r2UUZc3n3tg== X-CSE-MsgGUID: iIgP4Th0SfSAleBxwmoMpg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="20542691" Received: from unknown (HELO mev-dev) ([10.237.112.144]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 02:58:15 -0700 Date: Wed, 10 Apr 2024 11:57:55 +0200 From: Michal Swiatkowski To: "Buvaneswaran, Sujai" Message-ID: References: <20240312105259.2450-1-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712743098; x=1744279098; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8kljXWF9cM8kvyiMlAHuhlM0UfE1pXGPxynSESs+2dQ=; b=dF83plSuPiXQTi3r0FozgRuVDqvJj1xVNE+uczju8F+bSStlLCthNoUJ kPkrmMO42VLInL+PCBmk1BVTRhHuIuwtmGD0iUIRO4izjVUN+wczp6osn A6GUVEnfM/U0RG/jxN3jo9bqqkpXgNwlvdNMWEgZe7ixKxcKBibHbEEeW Ujd1uayMLRuJEYGZfZ44NTS3a8ZSeRW3RAyVYdQJhunjwBD59QMCqxsTK fWjQx3gkWqdNO0vq+yROXBlsJZhhqipZNbcHn1JQGqDRK+XSvuPvCBORb N7szOGWj+sdKRlLaGrRhkr8PVTIPxXhnwJXibX0xGs3Y7k0RBI6gknCdZ Q==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=dF83plSu Subject: Re: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on all profiles X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "netdev@vger.kernel.org" , Marcin Szycik , "intel-wired-lan@lists.osuosl.org" , "Kubiak, Michal" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Apr 05, 2024 at 10:43:04AM +0200, Michal Swiatkowski wrote: > On Mon, Apr 01, 2024 at 09:28:30AM +0000, Buvaneswaran, Sujai wrote: > > > -----Original Message----- > > > From: Michal Swiatkowski > > > Sent: Friday, March 29, 2024 1:56 PM > > > To: Buvaneswaran, Sujai > > > Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; Marcin Szycik > > > ; Kubiak, Michal > > > Subject: Re: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on all > > > profiles > > > > > > On Mon, Mar 25, 2024 at 06:36:56AM +0000, Buvaneswaran, Sujai wrote: > > > > > -----Original Message----- > > > > > From: Intel-wired-lan On Behalf > > > > > Of Michal Swiatkowski > > > > > Sent: Tuesday, March 12, 2024 4:23 PM > > > > > To: intel-wired-lan@lists.osuosl.org > > > > > Cc: netdev@vger.kernel.org; Marcin Szycik > > > > > ; Kubiak, Michal > > > > > ; Michal Swiatkowski > > > > > > > > > > Subject: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on > > > > > all profiles > > > > > > > > > > A simple non-tunnel rule (e.g. matching only on destination MAC) in > > > > > hardware will be hit only if the packet isn't a tunnel. In software > > > > > execution of the same command, the rule will match both tunnel and > > > non-tunnel packets. > > > > > > > > > > Change the hardware behaviour to match tunnel and non-tunnel packets > > > > > in this case. Do this by considering all profiles when adding > > > > > non-tunnel rule (rule not added on tunnel, or not redirecting to tunnel). > > > > > > > > > > Example command: > > > > > tc filter add dev pf0 ingress protocol ip flower skip_sw action mirred \ > > > > > egress redirect dev pr0 > > > > > > > > > > It should match also tunneled packets, the same as command with > > > > > skip_hw will do in software. > > > > > > > > > > Fixes: 9e300987d4a8 ("ice: VXLAN and Geneve TC support") > > > > > Reviewed-by: Marcin Szycik > > > > > Reviewed-by: Michal Kubiak > > > > > Signed-off-by: Michal Swiatkowski > > > > > > > > > > --- > > > > > v1 --> v2: > > > > > * fix commit message sugested by Marcin > > > > > --- > > > > > drivers/net/ethernet/intel/ice/ice_tc_lib.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > Hi, > > > > > > > > We are seeing error while adding HW tc rules on PF with the latest net- > > > queue patches. This issue is blocking the validation of latest net-queue > > > Switchdev patches. > > > > > > > > + tc filter add dev ens5f0np0 ingress protocol ip prio 1 flower > > > > + src_mac b4:96:91:9f:65:58 dst_mac 52:54:00:00:16:01 skip_sw action > > > > + mirred egress redirect dev eth0 > > > > Error: ice: Unable to add filter due to error. > > > > We have an error talking to the kernel > > > > + tc filter add dev ens5f0np0 ingress protocol ip prio 1 flower > > > > + src_mac b4:96:91:9f:65:58 dst_mac 52:54:00:00:16:02 skip_sw action > > > > + mirred egress redirect dev eth1 > > > > Error: ice: Unable to add filter due to error. > > > > We have an error talking to the kernel > > > > > > Hi, > > > > > > The same command is working fine on my setup. I suspect that it isn't related > > > to this patch. The change is only in command validation, there is no > > > functional changes here that can cause error during adding filters which > > > previously was working fine. > > > > > > Can you share more information about the setup? It was the first filter added > > > on the PF? Did you do sth else before checking tc? > > > > Hi Michal, > > I have used the setup with latest upstream dev-queue kernel and this issue is observed while adding HW tc rules on PF using > > 'Script A' from below link. > > https://edc.intel.com/content/www/us/en/design/products/ethernet/appnote-e810-eswitch-switchdev-mode-config-guide/script-a-switchdev-mode-with-linux-bridge-configuration/ > > > > This issue is reproducible on two of our setups with latest upstream kernel - 6.9.0-rc1+. Please check and let me know if more information is needed. > > > > I tried script from the link and it is working. I am aware of the > problem when the same rule is being added with different destination. > Are you sure there are no more exsisting rule before calling the script? > In the script VFs are removed, but PF qdisc isn't removed. Old rule can > exsist there. I suggest to add sth like, before adding new qdiscs: > $tc qdisc del dev $PF1 ingress > > I tested on 6.9.0-rc1+ kernel. > I have found the problem. I was using different DDP package. The problem is with lack of free indexes in profiles when matching is done on both tunnel and not tunnel packet (so all profiles are considered). For now please Tony remove it from next-queue. I am trying to figure out how to implement matching on all profiles using less indexes. If I find the correct way I will submit new patch. Thanks > Thanks, > Michal > > Thanks, > > Sujai B > > > > > > Thanks, > > > Michal > > > > > > > > Thanks, > > > > Sujai B