From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Vinod Govindapillai <vinod.govindapillai@intel.com>
Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
ville.syrjala@intel.com, matthew.d.roper@intel.com
Subject: Re: [PATCH v1] drm/xe: no need to call fixup_initial_plane_config in XE
Date: Tue, 16 Apr 2024 15:55:33 +0300 [thread overview]
Message-ID: <Zh51RV89rS4xJ7uv@intel.com> (raw)
In-Reply-To: <20240412213342.181465-1-vinod.govindapillai@intel.com>
On Sat, Apr 13, 2024 at 12:33:42AM +0300, Vinod Govindapillai wrote:
> In XE, the updated fb mapping is already done and updated as
> part of intel_find_initial_plane_obj(). So no need to invoke
> fixup_initial_plane_config() again as it would basically write
> the same data to "PLAN_SURF" again.
>
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
> drivers/gpu/drm/xe/display/xe_plane_initial.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
> index 9693c56d386b..51eb80729cfb 100644
> --- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
> +++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
> @@ -297,9 +297,6 @@ void intel_initial_plane_config(struct drm_i915_private *i915)
> */
> intel_find_initial_plane_obj(crtc, plane_configs);
>
> - if (i915->display.funcs.display->fixup_initial_plane_config(crtc, plane_config))
> - intel_crtc_wait_for_next_vblank(crtc);
> -
We want to do the opposite. ie. get rid rid of the async flip abuse in
xe.
> plane_config_fini(plane_config);
> }
> }
> --
> 2.34.1
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2024-04-16 12:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 21:33 [PATCH v1] drm/xe: no need to call fixup_initial_plane_config in XE Vinod Govindapillai
2024-04-15 15:35 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-15 15:35 ` ✓ CI.checkpatch: " Patchwork
2024-04-15 15:36 ` ✓ CI.KUnit: " Patchwork
2024-04-15 15:47 ` ✓ CI.Build: " Patchwork
2024-04-15 15:50 ` ✓ CI.Hooks: " Patchwork
2024-04-15 15:51 ` ✓ CI.checksparse: " Patchwork
2024-04-15 16:17 ` ✓ CI.BAT: " Patchwork
2024-04-15 19:59 ` ✓ Fi.CI.BAT: " Patchwork
2024-04-15 23:31 ` ✓ CI.FULL: " Patchwork
2024-04-16 8:23 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-04-16 12:55 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh51RV89rS4xJ7uv@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
--cc=ville.syrjala@intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.