From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4134413B59E for ; Fri, 29 Mar 2024 20:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711743490; cv=none; b=pUMaFFCCZKN8xAzfReBcziea7cByOwF+BN4PAl9JN/pGt3MXgX8ZUUEeSwOxWuMhjLQIw7Hf4fAJolyLOlPHYJmxk4oh/CB9LrCA3g4bhDwpDS8UprrFyOt/gpV1E2QH+qIG8BnNki3ykJkH5S1N2D1M60n2w5nOhinYPd1CwNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711743490; c=relaxed/simple; bh=3WbLA9Tayyx5l7XBtxYtcQu/1RXvOvT4WZKieEDaOzs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b88Ru/RVKiFNfcTHNlYz3Qz4r/d+RVuX6zwnCSYO02xSLxLQcDWGSwoNl4Mr3toFyUXNHWeuvzwYnNzsouKSWA0khjaNN+4v/usLhe1ubqWoxrRfH2fizHv0rH/QILSzwk3YdMredvIspYJf9aOi6V04hxZbsTGesiQhWYfnjy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=xbi8JOh0; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="xbi8JOh0" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1deddb82b43so171105ad.0 for ; Fri, 29 Mar 2024 13:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711743488; x=1712348288; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Gg6m+O36BVgBKp2BfarjLDVsnWA4tAwgiFOnj36SdA0=; b=xbi8JOh09rHHlGahJ/e60JADBuf+RF0OFSCKBCAW2vETGQTyOJurPHj0y7t5DqJB+B SGFeE/UqZwRaBmwboEYNL3Cw5qkdcixamYV9pQovsrhyN5keMa4A1Q6CZv5QwRtvmCbf tUX6u2xqntGjz0GLVtTj4e415cwEIdkTBjJyXy+YsUMnDpNj05XR6XyQx5Frs52kp+DY QccnX30O9BE49l/nxKV2IRj+QKl570/tz044+PfuMh7noEdc1QoMgOMGcAsU/f0bRK4p WZ7mlscd0/Do9xXqsHsgUkOLZtoqreXxLBLMBFEWZuAIQbh+wGcNTj/G75NNqqI6A6T5 RTMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711743488; x=1712348288; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gg6m+O36BVgBKp2BfarjLDVsnWA4tAwgiFOnj36SdA0=; b=EFjope4pzuHLk2hOKJyzHdmqAgeUUkONOsUQpHgcG22qBi/Nd+1/120RJU2DJUNwS4 4FHc3GOFUsTI3yZivWBnfgkFUhTQJXPprSZ+pZ9Woth9eUS5qKKrFluYJrd3LN7ly/1j jrrF72M+DLzAw48La4dcdDMGRZMbC1MFsafgLvqWZREx0frycNzMUswsPIPd6dBF5WEJ ZLRaiTTgCybmTK2fAPqEJO3QzSxzfge8A730Uc+1GtR/JwF41pg97yFtkyyD6kE6X1Xc 2F1xuFESzFJva+thKsDq4+IivDwkXhadZaxf9i5F635bfnPUrIBRxF5tfznj3sMQogDy HIyw== X-Forwarded-Encrypted: i=1; AJvYcCX1pGXLhf61EaYaaDkLVmvDCwOQfSyN0Rcot3b6BMw8tc5s5H4f95vHRBmYu+XiWpDBjuT4t5tPybtlwkZqj7h4VvBZEH2989sZGFU= X-Gm-Message-State: AOJu0YzgOus5EMK8y5EnPfJH11FjgKWnjF4uhdq0G2Cu2xAV6Np/7jQS NtmqOCn0lleoZjCcqhoUqcvqaVffwSfshFpErEa+M7v/+zlM/pSMUDnKe+BTrQ== X-Google-Smtp-Source: AGHT+IEMrr6gtaQSq3svrIypR7Gvc5mKqMuHZj3C6jkaJI+vd2LfrkRr6mbcX6hbmqCHo2nHi/KWcg== X-Received: by 2002:a17:902:eccb:b0:1e0:a494:4bb7 with SMTP id a11-20020a170902eccb00b001e0a4944bb7mr286932plh.2.1711743488041; Fri, 29 Mar 2024 13:18:08 -0700 (PDT) Received: from google.com (236.219.125.34.bc.googleusercontent.com. [34.125.219.236]) by smtp.gmail.com with ESMTPSA id x3-20020a170902ec8300b001e035cecd27sm3828903plg.129.2024.03.29.13.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 13:18:07 -0700 (PDT) Date: Fri, 29 Mar 2024 20:18:03 +0000 From: Benson Leung To: Tzung-Bi Shih Cc: bleung@chromium.org, groeck@chromium.org, linus.walleij@linaro.org, brgl@bgdev.pl, hverkuil-cisco@xs4all.nl, mchehab@kernel.org, sre@kernel.org, alexandre.belloni@bootlin.com, chrome-platform@lists.linux.dev, pmalani@chromium.org, linux-gpio@vger.kernel.org, linux-media@vger.kernel.org, linux-pm@vger.kernel.org, linux-rtc@vger.kernel.org, krzk@kernel.org Subject: Re: [PATCH 12/18] platform/chrome: cros_ec_lightbar: provide ID table for avoiding fallback match Message-ID: References: <20240329075630.2069474-1-tzungbi@kernel.org> <20240329075630.2069474-13-tzungbi@kernel.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jGJ4Z6TsBTQg0SOc" Content-Disposition: inline In-Reply-To: <20240329075630.2069474-13-tzungbi@kernel.org> --jGJ4Z6TsBTQg0SOc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 29, 2024 at 03:56:24PM +0800, Tzung-Bi Shih wrote: > Instead of using fallback driver name match, provide ID table[1] for the > primary match. >=20 > [1]: https://elixir.bootlin.com/linux/v6.8/source/drivers/base/platform.c= #L1353 >=20 > Signed-off-by: Tzung-Bi Shih Reviewed-by: Benson Leung > --- > drivers/platform/chrome/cros_ec_lightbar.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platfor= m/chrome/cros_ec_lightbar.c > index 6677cc6c4984..1e69f61115a4 100644 > --- a/drivers/platform/chrome/cros_ec_lightbar.c > +++ b/drivers/platform/chrome/cros_ec_lightbar.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -594,6 +595,12 @@ static int __maybe_unused cros_ec_lightbar_suspend(s= truct device *dev) > static SIMPLE_DEV_PM_OPS(cros_ec_lightbar_pm_ops, > cros_ec_lightbar_suspend, cros_ec_lightbar_resume); > =20 > +static const struct platform_device_id cros_ec_lightbar_id[] =3D { > + { DRV_NAME, 0 }, > + {} > +}; > +MODULE_DEVICE_TABLE(platform, cros_ec_lightbar_id); > + > static struct platform_driver cros_ec_lightbar_driver =3D { > .driver =3D { > .name =3D DRV_NAME, > @@ -602,10 +609,10 @@ static struct platform_driver cros_ec_lightbar_driv= er =3D { > }, > .probe =3D cros_ec_lightbar_probe, > .remove_new =3D cros_ec_lightbar_remove, > + .id_table =3D cros_ec_lightbar_id, > }; > =20 > module_platform_driver(cros_ec_lightbar_driver); > =20 > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("Expose the Chromebook Pixel's lightbar to userspace"= ); > -MODULE_ALIAS("platform:" DRV_NAME); > --=20 > 2.44.0.478.gd926399ef9-goog >=20 >=20 --jGJ4Z6TsBTQg0SOc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCZgch+wAKCRBzbaomhzOw wuzjAQCy/MjVt+YNcK751CMXj2j/EU6HWv9x0qhgCLWvuXJxDQEA3SMl8hSQYrBf 8OGD/VWV78xkaXLmP8YciNQoF+pNowI= =u+MD -----END PGP SIGNATURE----- --jGJ4Z6TsBTQg0SOc--