From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B273CCD1288 for ; Fri, 29 Mar 2024 08:25:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5DD0A41825; Fri, 29 Mar 2024 08:25:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id qFBGNgnoagCm; Fri, 29 Mar 2024 08:25:49 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 97B7C41811 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1711700749; bh=/jJxQwptvj8RJCMkfRlF4UnaW3XMz6CxOSy1bys/2d8=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=rE/N27vSgHkhfeCplUmEr+dxGjY+5SeI9Z2N/7z5xj67rnfUCfYoOrXoTjIqYx6K0 aV1egugRq0UBEbP8fmb8lIzksDubqISUCxUfQn7h3+XCxigE1b3c1SffoDC5LnbyVK TtpUxD+lp0kX8Dc1hy/qYAPiBrEjjQDJN5DMSD1XYbXyXo4tuztZ87V23X+BWuMERF b/xgaFGZFhFRqbA9Z56s9tLOVXFfdWZ2hybgdjidikyB2aC8UofdWdQ/tHWfvIgep3 xlxRE6KcmFvUMzHHORnRy8iwwuRTtHB7Pw8lIoQhZr3GglucE5OsalqUrrS/InXTj9 S5EUHB1jTlYFw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 97B7C41811; Fri, 29 Mar 2024 08:25:49 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id D0CD61BF285 for ; Fri, 29 Mar 2024 08:25:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id BCC0E60D6D for ; Fri, 29 Mar 2024 08:25:47 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id EMYfaR_BYfPD for ; Fri, 29 Mar 2024 08:25:47 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=192.198.163.17; helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org BA53A6074E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BA53A6074E Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by smtp3.osuosl.org (Postfix) with ESMTPS id BA53A6074E for ; Fri, 29 Mar 2024 08:25:46 +0000 (UTC) X-CSE-ConnectionGUID: SD5M3sDEShWXc0KO7iMVEA== X-CSE-MsgGUID: o7ER0t6UTvyJFqXCkWwsnA== X-IronPort-AV: E=McAfee;i="6600,9927,11027"; a="6748961" X-IronPort-AV: E=Sophos;i="6.07,164,1708416000"; d="scan'208";a="6748961" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2024 01:25:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,164,1708416000"; d="scan'208";a="16965983" Received: from unknown (HELO mev-dev) ([10.237.112.144]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2024 01:25:44 -0700 Date: Fri, 29 Mar 2024 09:25:35 +0100 From: Michal Swiatkowski To: "Buvaneswaran, Sujai" Message-ID: References: <20240312105259.2450-1-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711700747; x=1743236747; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=v+cbkxJzxF/YcfwnjeRh08GfHVnQ93gPGcW75G6xRTA=; b=UpuPC3mxZpBhHRBPEiNxXWVBaUkyfvcezJKNoFU1DQScNc173p170tkd JMmCXF9Z7MZ4DJQ/d3OwIPoaky7CG2Svv8oYafxenFGalYOzehrl1CtNX I1JkJpboFd87nac2qJwxaMjJskLj1Xn1H4uZe6oymk+wW5Lfvy2+ZUL2G Q37gZwr9m0UvDfZkBaKNoDncBNtWkPbhqvdaplo55ct4Ux8zul6qPlkIy ToaTbhynSlBFAf2DTjocMQULllHkYFM+cjmEjAIydCn5nzyJ1xG0ZC9eB nGZtu4WOOSblquDr2KbW4UfCdLzNbh59HcimMQGKn+Hd1+LHXgcRHzPwr A==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=UpuPC3mx Subject: Re: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on all profiles X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "netdev@vger.kernel.org" , Marcin Szycik , "intel-wired-lan@lists.osuosl.org" , "Kubiak, Michal" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Mar 25, 2024 at 06:36:56AM +0000, Buvaneswaran, Sujai wrote: > > -----Original Message----- > > From: Intel-wired-lan On Behalf Of > > Michal Swiatkowski > > Sent: Tuesday, March 12, 2024 4:23 PM > > To: intel-wired-lan@lists.osuosl.org > > Cc: netdev@vger.kernel.org; Marcin Szycik ; > > Kubiak, Michal ; Michal Swiatkowski > > > > Subject: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on all profiles > > > > A simple non-tunnel rule (e.g. matching only on destination MAC) in > > hardware will be hit only if the packet isn't a tunnel. In software execution of > > the same command, the rule will match both tunnel and non-tunnel packets. > > > > Change the hardware behaviour to match tunnel and non-tunnel packets in > > this case. Do this by considering all profiles when adding non-tunnel rule > > (rule not added on tunnel, or not redirecting to tunnel). > > > > Example command: > > tc filter add dev pf0 ingress protocol ip flower skip_sw action mirred \ > > egress redirect dev pr0 > > > > It should match also tunneled packets, the same as command with skip_hw > > will do in software. > > > > Fixes: 9e300987d4a8 ("ice: VXLAN and Geneve TC support") > > Reviewed-by: Marcin Szycik > > Reviewed-by: Michal Kubiak > > Signed-off-by: Michal Swiatkowski > > --- > > v1 --> v2: > > * fix commit message sugested by Marcin > > --- > > drivers/net/ethernet/intel/ice/ice_tc_lib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Hi, > > We are seeing error while adding HW tc rules on PF with the latest net-queue patches. This issue is blocking the validation of latest net-queue Switchdev patches. > > + tc filter add dev ens5f0np0 ingress protocol ip prio 1 flower src_mac b4:96:91:9f:65:58 dst_mac 52:54:00:00:16:01 skip_sw action mirred egress redirect dev eth0 > Error: ice: Unable to add filter due to error. > We have an error talking to the kernel > + tc filter add dev ens5f0np0 ingress protocol ip prio 1 flower src_mac b4:96:91:9f:65:58 dst_mac 52:54:00:00:16:02 skip_sw action mirred egress redirect dev eth1 > Error: ice: Unable to add filter due to error. > We have an error talking to the kernel Hi, The same command is working fine on my setup. I suspect that it isn't related to this patch. The change is only in command validation, there is no functional changes here that can cause error during adding filters which previously was working fine. Can you share more information about the setup? It was the first filter added on the PF? Did you do sth else before checking tc? Thanks, Michal > > Thanks, > Sujai B From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BC093BBE2 for ; Fri, 29 Mar 2024 08:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711700748; cv=none; b=sQA1mvNacxg02QNuaZ4uPlLoinfwZGk25PBZn80PibVbxknmKoUTMkK+AAlA3+eijNwJMn8Xwn3ydKf+b6u9NmyRTpXWePoXBmJmsg72NRWJo3aUmbsUVfTfbJF8t902AN6y8zq0gXq5olWU3UpaGLnOWE7nYnQO33g70JyJxjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711700748; c=relaxed/simple; bh=v+cbkxJzxF/YcfwnjeRh08GfHVnQ93gPGcW75G6xRTA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FkjBjShVQxhlCAtpL090yQJr2QhswOAuNR6Mzso/SUrvMXxd7DDjd+eIaj26peZWF673XpCDbBtmH8ic4iLRjZjTXl54XBUUwzqHiHUqFpEC5hAM4mPdtO+D5r2XHn/PFNSeVipO5zJVVejv/iEkTm6n/P50zYlLIoHW2Z+hjDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Z95iwgoE; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Z95iwgoE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711700746; x=1743236746; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=v+cbkxJzxF/YcfwnjeRh08GfHVnQ93gPGcW75G6xRTA=; b=Z95iwgoEaItq/p3wzPo2irY7XLZ2OQuHhOII65hsu3D3hq4bJBjAIuS2 5oqvjaxLQEUo7Lor9fJoTcu8HTHFL14vT7iJb34TK9gV8sMuGJsdnFgh5 VIUl8L4aPusRbCfDsbn/aAaHBVQAfErQp8gTWX7wufwuuauz22ErahU4c S0sSywQVSNgYBk5GWtdYC78ZBXBHotQYnTyzEnIfuD7yWIuaIhGjSNDuc 8qqKlggVLPJCqjaEqgweyjWlsve07bZ+yYEUOWb1jEMetLlYIdm03MLt/ D0Fw5JAt11LocfyEhhGuXeIuGIMrcrCOK18gcV2xekkt8bjfW78HrAKgO A==; X-CSE-ConnectionGUID: rwXpi1m5TpOPnCZM/jouhg== X-CSE-MsgGUID: SJt8/nLsRTOZzFgJWFYM0A== X-IronPort-AV: E=McAfee;i="6600,9927,11027"; a="6748963" X-IronPort-AV: E=Sophos;i="6.07,164,1708416000"; d="scan'208";a="6748963" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2024 01:25:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,164,1708416000"; d="scan'208";a="16965983" Received: from unknown (HELO mev-dev) ([10.237.112.144]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2024 01:25:44 -0700 Date: Fri, 29 Mar 2024 09:25:35 +0100 From: Michal Swiatkowski To: "Buvaneswaran, Sujai" Cc: "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , Marcin Szycik , "Kubiak, Michal" Subject: Re: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on all profiles Message-ID: References: <20240312105259.2450-1-michal.swiatkowski@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 25, 2024 at 06:36:56AM +0000, Buvaneswaran, Sujai wrote: > > -----Original Message----- > > From: Intel-wired-lan On Behalf Of > > Michal Swiatkowski > > Sent: Tuesday, March 12, 2024 4:23 PM > > To: intel-wired-lan@lists.osuosl.org > > Cc: netdev@vger.kernel.org; Marcin Szycik ; > > Kubiak, Michal ; Michal Swiatkowski > > > > Subject: [Intel-wired-lan] [iwl-net v1] ice: tc: do default match on all profiles > > > > A simple non-tunnel rule (e.g. matching only on destination MAC) in > > hardware will be hit only if the packet isn't a tunnel. In software execution of > > the same command, the rule will match both tunnel and non-tunnel packets. > > > > Change the hardware behaviour to match tunnel and non-tunnel packets in > > this case. Do this by considering all profiles when adding non-tunnel rule > > (rule not added on tunnel, or not redirecting to tunnel). > > > > Example command: > > tc filter add dev pf0 ingress protocol ip flower skip_sw action mirred \ > > egress redirect dev pr0 > > > > It should match also tunneled packets, the same as command with skip_hw > > will do in software. > > > > Fixes: 9e300987d4a8 ("ice: VXLAN and Geneve TC support") > > Reviewed-by: Marcin Szycik > > Reviewed-by: Michal Kubiak > > Signed-off-by: Michal Swiatkowski > > --- > > v1 --> v2: > > * fix commit message sugested by Marcin > > --- > > drivers/net/ethernet/intel/ice/ice_tc_lib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > Hi, > > We are seeing error while adding HW tc rules on PF with the latest net-queue patches. This issue is blocking the validation of latest net-queue Switchdev patches. > > + tc filter add dev ens5f0np0 ingress protocol ip prio 1 flower src_mac b4:96:91:9f:65:58 dst_mac 52:54:00:00:16:01 skip_sw action mirred egress redirect dev eth0 > Error: ice: Unable to add filter due to error. > We have an error talking to the kernel > + tc filter add dev ens5f0np0 ingress protocol ip prio 1 flower src_mac b4:96:91:9f:65:58 dst_mac 52:54:00:00:16:02 skip_sw action mirred egress redirect dev eth1 > Error: ice: Unable to add filter due to error. > We have an error talking to the kernel Hi, The same command is working fine on my setup. I suspect that it isn't related to this patch. The change is only in command validation, there is no functional changes here that can cause error during adding filters which previously was working fine. Can you share more information about the setup? It was the first filter added on the PF? Did you do sth else before checking tc? Thanks, Michal > > Thanks, > Sujai B