All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"V, Narasimhan" <Narasimhan.V@amd.com>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Aithal, Srikanth" <Srikanth.Aithal@amd.com>,
	Dawei Li <dawei.li@shingroup.cn>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Yury Norov <yury.norov@gmail.com>,
	lkml <linux-kernel@vger.kernel.org>,
	Vlastimil Babka <vbabka@suse.cz>
Subject: Re: Boot failure with kernel BUG at mm/usercopy.c on next-20240325
Date: Tue, 26 Mar 2024 10:30:10 +0800	[thread overview]
Message-ID: <ZgIzMqiZzqUmqEOZ@feng-clx.sh.intel.com> (raw)
In-Reply-To: <20240325203714.GJZgHgem2TR1aVAVlU@fat_crate.local>

Add Vlastimil for slab related topic.

On Tue, Mar 26, 2024 at 04:37:14AM +0800, Borislav Petkov wrote:
> On Mon, Mar 25, 2024 at 11:34:33AM -0700, Andrew Morton wrote:
> > Thanks, I'll just drop the patch.  It didn't receive a very favorable
> > review reception anyway.
> 
> See here:
> 
> https://lore.kernel.org/all/DM4PR12MB5086B9BDBF32D53DF226CBF489362@DM4PR12MB5086.namprd12.prod.outlook.com/
> 
> folks still need to learn email. :-)
> 
> Anyway, apparently there's some fix there.

The original commit 328c801335d5 ("cpumask: create dedicated kmem
cache for cpumask var") has some benefit, that there are CPU numbers
which are not power of 8, like 144, 288 etc where it will save
some memory. 

And 'slabtop' on a qemu-VM with 16 cpus shows it is surprisingly
non-trivial and has the third largest number of objects: 

22350   22350 100%    0.13K    745       30      2980K kernfs_node_cache
 11172  10693   0%    0.19K    266       42      2128K dentry
 10240   8222   0%    0.01K     20      512        80K cpumask

Andrew, if it is worth merging, you can folder my fix into the patch. 

Thanks,
Feng


> Thx.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette
> 

  reply	other threads:[~2024-03-26  2:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 12:40 Boot failure with kernel BUG at mm/usercopy.c on next-20240325 V, Narasimhan
2024-03-25 12:50 ` Borislav Petkov
2024-03-25 18:34   ` Andrew Morton
2024-03-25 20:37     ` Borislav Petkov
2024-03-26  2:30       ` Feng Tang [this message]
2024-03-26 19:56         ` Andrew Morton
2024-03-25 15:28 ` Feng Tang
2024-03-25 17:48   ` V, Narasimhan
  -- strict thread matches above, loose matches on Subject: below --
2024-03-25 12:36 V, Narasimhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZgIzMqiZzqUmqEOZ@feng-clx.sh.intel.com \
    --to=feng.tang@intel.com \
    --cc=Narasimhan.V@amd.com \
    --cc=Srikanth.Aithal@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dawei.li@shingroup.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=vbabka@suse.cz \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.