All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] PCI/AER: Fix rootport attribute paths in ABI docs
@ 2024-02-02 13:16 Johan Hovold
  2024-02-02 13:16 ` [PATCH 1/2] " Johan Hovold
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Johan Hovold @ 2024-02-02 13:16 UTC (permalink / raw
  To: Bjorn Helgaas; +Cc: Rajat Jain, linux-pci, linux-kernel, Johan Hovold

Some AER attribute paths were changed in the final revision of the
series adding them but the ABI documentation was never updated to match.

Included is also a related white space cleanup after a commit fixing the
'KernelVersion' field name.

Johan


Johan Hovold (2):
  PCI/AER: Fix rootport attribute paths in ABI docs
  PCI/AER: Clean up version indentation in ABI docs

 .../testing/sysfs-bus-pci-devices-aer_stats    | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] PCI/AER: Fix rootport attribute paths in ABI docs
  2024-02-02 13:16 [PATCH 0/2] PCI/AER: Fix rootport attribute paths in ABI docs Johan Hovold
@ 2024-02-02 13:16 ` Johan Hovold
  2024-02-02 13:16 ` [PATCH 2/2] PCI/AER: Clean up version indentation " Johan Hovold
  2024-02-02 23:24 ` [PATCH 0/2] PCI/AER: Fix rootport attribute paths " Bjorn Helgaas
  2 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2024-02-02 13:16 UTC (permalink / raw
  To: Bjorn Helgaas; +Cc: Rajat Jain, linux-pci, linux-kernel, Johan Hovold

The 'aer_stats' directory never made it into the sixth and final
revision of the series adding the AER attributes.

Fixes: 12833017e581 ("PCI/AER: Add sysfs attributes for rootport cumulative stats")
Link: https://lore.kernel.org/lkml/20180621184822.GB14136@bhelgaas-glaptop.roam.corp.google.com/
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
index 860db53037a5..24087d5fd417 100644
--- a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
+++ b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
@@ -100,19 +100,19 @@ collectors) that are AER capable. These indicate the number of error messages as
 device, so these counters include them and are thus cumulative of all the error
 messages on the PCI hierarchy originating at that root port.
 
-What:		/sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_cor
+What:		/sys/bus/pci/devices/<dev>/aer_rootport_total_err_cor
 Date:		July 2018
 KernelVersion: 4.19.0
 Contact:	linux-pci@vger.kernel.org, rajatja@google.com
 Description:	Total number of ERR_COR messages reported to rootport.
 
-What:	    /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_fatal
+What:		/sys/bus/pci/devices/<dev>/aer_rootport_total_err_fatal
 Date:		July 2018
 KernelVersion: 4.19.0
 Contact:	linux-pci@vger.kernel.org, rajatja@google.com
 Description:	Total number of ERR_FATAL messages reported to rootport.
 
-What:	    /sys/bus/pci/devices/<dev>/aer_stats/aer_rootport_total_err_nonfatal
+What:		/sys/bus/pci/devices/<dev>/aer_rootport_total_err_nonfatal
 Date:		July 2018
 KernelVersion: 4.19.0
 Contact:	linux-pci@vger.kernel.org, rajatja@google.com
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] PCI/AER: Clean up version indentation in ABI docs
  2024-02-02 13:16 [PATCH 0/2] PCI/AER: Fix rootport attribute paths in ABI docs Johan Hovold
  2024-02-02 13:16 ` [PATCH 1/2] " Johan Hovold
@ 2024-02-02 13:16 ` Johan Hovold
  2024-02-02 23:24 ` [PATCH 0/2] PCI/AER: Fix rootport attribute paths " Bjorn Helgaas
  2 siblings, 0 replies; 6+ messages in thread
From: Johan Hovold @ 2024-02-02 13:16 UTC (permalink / raw
  To: Bjorn Helgaas; +Cc: Rajat Jain, linux-pci, linux-kernel, Johan Hovold

The 'KernelVersion' lines use a single space as separator instead of a
tab so the values are not aligned with the other AER attribute fields.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 .../ABI/testing/sysfs-bus-pci-devices-aer_stats      | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
index 24087d5fd417..d1f67bb81d5d 100644
--- a/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
+++ b/Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
@@ -11,7 +11,7 @@ saw any problems).
 
 What:		/sys/bus/pci/devices/<dev>/aer_dev_correctable
 Date:		July 2018
-KernelVersion: 4.19.0
+KernelVersion:	4.19.0
 Contact:	linux-pci@vger.kernel.org, rajatja@google.com
 Description:	List of correctable errors seen and reported by this
 		PCI device using ERR_COR. Note that since multiple errors may
@@ -32,7 +32,7 @@ Description:	List of correctable errors seen and reported by this
 
 What:		/sys/bus/pci/devices/<dev>/aer_dev_fatal
 Date:		July 2018
-KernelVersion: 4.19.0
+KernelVersion:	4.19.0
 Contact:	linux-pci@vger.kernel.org, rajatja@google.com
 Description:	List of uncorrectable fatal errors seen and reported by this
 		PCI device using ERR_FATAL. Note that since multiple errors may
@@ -62,7 +62,7 @@ Description:	List of uncorrectable fatal errors seen and reported by this
 
 What:		/sys/bus/pci/devices/<dev>/aer_dev_nonfatal
 Date:		July 2018
-KernelVersion: 4.19.0
+KernelVersion:	4.19.0
 Contact:	linux-pci@vger.kernel.org, rajatja@google.com
 Description:	List of uncorrectable nonfatal errors seen and reported by this
 		PCI device using ERR_NONFATAL. Note that since multiple errors
@@ -102,18 +102,18 @@ messages on the PCI hierarchy originating at that root port.
 
 What:		/sys/bus/pci/devices/<dev>/aer_rootport_total_err_cor
 Date:		July 2018
-KernelVersion: 4.19.0
+KernelVersion:	4.19.0
 Contact:	linux-pci@vger.kernel.org, rajatja@google.com
 Description:	Total number of ERR_COR messages reported to rootport.
 
 What:		/sys/bus/pci/devices/<dev>/aer_rootport_total_err_fatal
 Date:		July 2018
-KernelVersion: 4.19.0
+KernelVersion:	4.19.0
 Contact:	linux-pci@vger.kernel.org, rajatja@google.com
 Description:	Total number of ERR_FATAL messages reported to rootport.
 
 What:		/sys/bus/pci/devices/<dev>/aer_rootport_total_err_nonfatal
 Date:		July 2018
-KernelVersion: 4.19.0
+KernelVersion:	4.19.0
 Contact:	linux-pci@vger.kernel.org, rajatja@google.com
 Description:	Total number of ERR_NONFATAL messages reported to rootport.
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] PCI/AER: Fix rootport attribute paths in ABI docs
  2024-02-02 13:16 [PATCH 0/2] PCI/AER: Fix rootport attribute paths in ABI docs Johan Hovold
  2024-02-02 13:16 ` [PATCH 1/2] " Johan Hovold
  2024-02-02 13:16 ` [PATCH 2/2] PCI/AER: Clean up version indentation " Johan Hovold
@ 2024-02-02 23:24 ` Bjorn Helgaas
  2024-02-20  8:04   ` Johan Hovold
  2 siblings, 1 reply; 6+ messages in thread
From: Bjorn Helgaas @ 2024-02-02 23:24 UTC (permalink / raw
  To: Johan Hovold; +Cc: Bjorn Helgaas, Rajat Jain, linux-pci, linux-kernel

On Fri, Feb 02, 2024 at 02:16:33PM +0100, Johan Hovold wrote:
> Some AER attribute paths were changed in the final revision of the
> series adding them but the ABI documentation was never updated to match.
> 
> Included is also a related white space cleanup after a commit fixing the
> 'KernelVersion' field name.
> 
> Johan
> 
> 
> Johan Hovold (2):
>   PCI/AER: Fix rootport attribute paths in ABI docs
>   PCI/AER: Clean up version indentation in ABI docs
> 
>  .../testing/sysfs-bus-pci-devices-aer_stats    | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

Applied to pci/aer for v6.9, thanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] PCI/AER: Fix rootport attribute paths in ABI docs
  2024-02-02 23:24 ` [PATCH 0/2] PCI/AER: Fix rootport attribute paths " Bjorn Helgaas
@ 2024-02-20  8:04   ` Johan Hovold
  2024-02-20 16:32     ` Bjorn Helgaas
  0 siblings, 1 reply; 6+ messages in thread
From: Johan Hovold @ 2024-02-20  8:04 UTC (permalink / raw
  To: Bjorn Helgaas
  Cc: Johan Hovold, Bjorn Helgaas, Rajat Jain, linux-pci, linux-kernel

Hi Bjorn,

On Fri, Feb 02, 2024 at 05:24:35PM -0600, Bjorn Helgaas wrote:
> On Fri, Feb 02, 2024 at 02:16:33PM +0100, Johan Hovold wrote:

> > Johan Hovold (2):
> >   PCI/AER: Fix rootport attribute paths in ABI docs
> >   PCI/AER: Clean up version indentation in ABI docs

> Applied to pci/aer for v6.9, thanks!

I noticed that these have not shown up in linux-next yet. Did you forget
to push the branch?

Johan

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] PCI/AER: Fix rootport attribute paths in ABI docs
  2024-02-20  8:04   ` Johan Hovold
@ 2024-02-20 16:32     ` Bjorn Helgaas
  0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Helgaas @ 2024-02-20 16:32 UTC (permalink / raw
  To: Johan Hovold
  Cc: Johan Hovold, Bjorn Helgaas, Rajat Jain, linux-pci, linux-kernel

On Tue, Feb 20, 2024 at 09:04:13AM +0100, Johan Hovold wrote:
> Hi Bjorn,
> 
> On Fri, Feb 02, 2024 at 05:24:35PM -0600, Bjorn Helgaas wrote:
> > On Fri, Feb 02, 2024 at 02:16:33PM +0100, Johan Hovold wrote:
> 
> > > Johan Hovold (2):
> > >   PCI/AER: Fix rootport attribute paths in ABI docs
> > >   PCI/AER: Clean up version indentation in ABI docs
> 
> > Applied to pci/aer for v6.9, thanks!
> 
> I noticed that these have not shown up in linux-next yet. Did you forget
> to push the branch?

Indeed I did forget.  Updated and pushed, thanks!

Bjorn

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-02-20 16:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-02 13:16 [PATCH 0/2] PCI/AER: Fix rootport attribute paths in ABI docs Johan Hovold
2024-02-02 13:16 ` [PATCH 1/2] " Johan Hovold
2024-02-02 13:16 ` [PATCH 2/2] PCI/AER: Clean up version indentation " Johan Hovold
2024-02-02 23:24 ` [PATCH 0/2] PCI/AER: Fix rootport attribute paths " Bjorn Helgaas
2024-02-20  8:04   ` Johan Hovold
2024-02-20 16:32     ` Bjorn Helgaas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.