From: Cyril Hrubis <chrubis@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] ioctl_fiemap01: New test for fiemap ioctl()
Date: Mon, 15 Jan 2024 16:23:35 +0100 [thread overview]
Message-ID: <ZaVN90UDAhOKlCSP@yuki> (raw)
In-Reply-To: <20231018054357.29035-1-wegao@suse.com>
Hi!
> +static void print_extens(struct fiemap *fiemap)
> +{
> +
> + tst_res(TINFO, "File extent count: %u", fiemap->fm_mapped_extents);
> + for (unsigned int i = 0; i < fiemap->fm_mapped_extents; ++i) {
> + tst_res(TINFO, "Extent %u: Logical offset: %llu, Physical offset: %llu, flags: %u, Length: %llu",
^
This would probably be better TDEBUG that has
been recently introduced.
> + i + 1,
> + fiemap->fm_extents[i].fe_logical,
> + fiemap->fm_extents[i].fe_physical,
> + fiemap->fm_extents[i].fe_flags,
> + fiemap->fm_extents[i].fe_length);
> + }
> +}
> +
> +static void verify_ioctl(void)
> +{
> + int fd;
> + struct fiemap *fiemap;
> +
> + fd = SAFE_OPEN(TESTFILE, O_RDWR | O_CREAT, 0644);
> +
> + fiemap = SAFE_MALLOC(sizeof(struct fiemap) + sizeof(struct fiemap_extent) * NUM_EXTENT);
> + fiemap->fm_start = 0;
> + fiemap->fm_length = ~0ULL;
> + fiemap->fm_extent_count = 1;
> +
> + fiemap->fm_flags = -1;
> + TST_EXP_FAIL(ioctl(fd, FS_IOC_FIEMAP, fiemap), EBADR);
> +
> + fiemap->fm_flags = 0;
> + SAFE_IOCTL(fd, FS_IOC_FIEMAP, fiemap);
> + print_extens(fiemap);
> + if (fiemap->fm_mapped_extents == 0)
> + tst_res(TPASS, "Check fiemap iotct step1 pass");
This is missing the TFAIL branch, also "step1 pass" is not good enough
description of the test, we should really describe what we were testing
for.
> + SAFE_WRITE(SAFE_WRITE_ANY, fd, buf, getpagesize());
> + SAFE_IOCTL(fd, FS_IOC_FIEMAP, fiemap);
> + print_extens(fiemap);
> + if ((fiemap->fm_mapped_extents == 1) && (fiemap->fm_extents[0].fe_physical == 0))
> + tst_res(TPASS, "Check fiemap iotct step2 pass");
Here as well.
> + fiemap->fm_flags = FIEMAP_FLAG_SYNC;
> + SAFE_IOCTL(fd, FS_IOC_FIEMAP, fiemap);
> + print_extens(fiemap);
> + if ((fiemap->fm_extent_count == 1) &&
> + (fiemap->fm_extents[0].fe_flags == FIEMAP_EXTENT_LAST) &&
> + (fiemap->fm_extents[0].fe_physical > 0) &&
> + (fiemap->fm_extents[0].fe_length == (__u64)getpagesize()))
> + tst_res(TPASS, "Check fiemap iotct step3 pass");
And here as well.
> + fiemap->fm_extent_count = NUM_EXTENT;
> + srand(time(NULL));
> + SAFE_LSEEK(fd, FILE_OFFSET, SEEK_SET);
> + SAFE_WRITE(SAFE_WRITE_ALL, fd, buf, getpagesize());
> + SAFE_IOCTL(fd, FS_IOC_FIEMAP, fiemap);
> + print_extens(fiemap);
> + if ((fiemap->fm_extent_count == NUM_EXTENT) &&
> + (fiemap->fm_extents[NUM_EXTENT - 1].fe_flags == FIEMAP_EXTENT_LAST) &&
> + (fiemap->fm_extents[NUM_EXTENT - 1].fe_physical > 0) &&
> + (fiemap->fm_extents[NUM_EXTENT - 1].fe_length == (__u64)getpagesize()))
> + tst_res(TPASS, "Check fiemap iotct step4 pass");
And here as well.
> + free(fiemap);
> + close(fd);
SAFE_CLOSE() plase.
I suppose that we have to unlink the file so that the test work with -i
2.
> +}
> +
> +static void setup(void)
> +{
> + buf = SAFE_MALLOC(getpagesize());
> +}
> +
> +static void cleanup(void)
> +{
> + free(buf);
> +}
> +
> +static struct tst_test test = {
> + .setup = setup,
> + .cleanup = cleanup,
> + .test_all = verify_ioctl,
> + .needs_root = 1,
> + .needs_tmpdir = 1,
> +};
> --
> 2.35.3
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-01-15 15:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 5:43 [LTP] [PATCH v1] ioctl_fiemap01: New test for fiemap ioctl() Wei Gao via ltp
2024-01-15 15:23 ` Cyril Hrubis [this message]
2024-01-18 7:32 ` [LTP] [PATCH v2] " Wei Gao via ltp
2024-02-28 17:07 ` Petr Vorel
2024-03-29 8:28 ` Wei Gao via ltp
2024-03-29 21:32 ` Petr Vorel
2024-03-31 2:15 ` Wei Gao via ltp
2024-03-31 2:17 ` [LTP] [PATCH v3] " Wei Gao via ltp
2024-04-03 9:28 ` Petr Vorel
2024-04-15 10:17 ` Wei Gao via ltp
2024-04-15 12:17 ` Petr Vorel
2024-04-15 11:46 ` [LTP] [PATCH v4] " Wei Gao via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaVN90UDAhOKlCSP@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.