From: Simon Horman <horms@kernel.org>
To: Wenjun Wu <wenjun1.wu@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
xuejun.zhang@intel.com, madhu.chittim@intel.com,
qi.z.zhang@intel.com, anthony.l.nguyen@intel.com
Subject: Re: [PATCH iwl-next v2 4/5] iavf: Add devlink port function rate API support
Date: Tue, 8 Aug 2023 22:49:38 +0200 [thread overview]
Message-ID: <ZNKqYlC86siUsRzd@vergenet.net> (raw)
In-Reply-To: <20230808015734.1060525-5-wenjun1.wu@intel.com>
On Tue, Aug 08, 2023 at 09:57:33AM +0800, Wenjun Wu wrote:
> From: Jun Zhang <xuejun.zhang@intel.com>
>
> To allow user to configure queue based parameters, devlink port function
> rate api functions are added for setting node tx_max and tx_share
> parameters.
>
> iavf rate tree with root node and queue nodes is created and registered
> with devlink rate when iavf adapter is configured.
>
> Signed-off-by: Jun Zhang <xuejun.zhang@intel.com>
...
> +/**
> + * iavf_update_queue_tx_max - sets tx max parameter
> + * @adapter: iavf adapter struct instance
> + * @node: iavf rate node struct instance
> + * @bw: bandwidth in bytes per second
> + * @extack: extended netdev ack structure
> + *
> + * This function sets max BW limit.
> + */
> +static int iavf_update_queue_tx_max(struct iavf_adapter *adapter,
> + struct iavf_dev_rate_node *node,
> + u64 bw, struct netlink_ext_ack *extack)
> +{
> + /* Keep in kbps */
> + node->tx_max_temp = div_u64(bw, IAVF_RATE_DIV_FACTOR);
> + if (ADV_LINK_SUPPORT(adapter)) {
> + if (node->tx_max_temp / 1000 > adapter->link_speed_mbps)
> + return -EINVAL;
> + }
> +
> + node->tx_update_flag |= IAVF_FLAG_TX_MAX_UPDATED;
> +
> + return iavf_check_update_config(adapter, node);
> +}
> +
> +/**
> + * iavf_devlink_rate_node_tx_max_set - devlink_rate API for setting tx max
> + * @rate_node: devlink rate struct instance
Hi Jun Zhang,
Please describe all the parameters of iavf_devlink_rate_node_tx_max_set
in it's kernel doc.
./scripts/kernel-doc -none is your friend here.
> + *
> + * This function implements rate_node_tx_max_set function of devlink_ops
> + */
> +static int iavf_devlink_rate_node_tx_max_set(struct devlink_rate *rate_node,
> + void *priv, u64 tx_max,
> + struct netlink_ext_ack *extack)
...
--
pw-bot: changes-requested
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Wenjun Wu <wenjun1.wu@intel.com>
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
qi.z.zhang@intel.com, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 4/5] iavf: Add devlink port function rate API support
Date: Tue, 8 Aug 2023 22:49:38 +0200 [thread overview]
Message-ID: <ZNKqYlC86siUsRzd@vergenet.net> (raw)
In-Reply-To: <20230808015734.1060525-5-wenjun1.wu@intel.com>
On Tue, Aug 08, 2023 at 09:57:33AM +0800, Wenjun Wu wrote:
> From: Jun Zhang <xuejun.zhang@intel.com>
>
> To allow user to configure queue based parameters, devlink port function
> rate api functions are added for setting node tx_max and tx_share
> parameters.
>
> iavf rate tree with root node and queue nodes is created and registered
> with devlink rate when iavf adapter is configured.
>
> Signed-off-by: Jun Zhang <xuejun.zhang@intel.com>
...
> +/**
> + * iavf_update_queue_tx_max - sets tx max parameter
> + * @adapter: iavf adapter struct instance
> + * @node: iavf rate node struct instance
> + * @bw: bandwidth in bytes per second
> + * @extack: extended netdev ack structure
> + *
> + * This function sets max BW limit.
> + */
> +static int iavf_update_queue_tx_max(struct iavf_adapter *adapter,
> + struct iavf_dev_rate_node *node,
> + u64 bw, struct netlink_ext_ack *extack)
> +{
> + /* Keep in kbps */
> + node->tx_max_temp = div_u64(bw, IAVF_RATE_DIV_FACTOR);
> + if (ADV_LINK_SUPPORT(adapter)) {
> + if (node->tx_max_temp / 1000 > adapter->link_speed_mbps)
> + return -EINVAL;
> + }
> +
> + node->tx_update_flag |= IAVF_FLAG_TX_MAX_UPDATED;
> +
> + return iavf_check_update_config(adapter, node);
> +}
> +
> +/**
> + * iavf_devlink_rate_node_tx_max_set - devlink_rate API for setting tx max
> + * @rate_node: devlink rate struct instance
Hi Jun Zhang,
Please describe all the parameters of iavf_devlink_rate_node_tx_max_set
in it's kernel doc.
./scripts/kernel-doc -none is your friend here.
> + *
> + * This function implements rate_node_tx_max_set function of devlink_ops
> + */
> +static int iavf_devlink_rate_node_tx_max_set(struct devlink_rate *rate_node,
> + void *priv, u64 tx_max,
> + struct netlink_ext_ack *extack)
...
--
pw-bot: changes-requested
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-08-08 20:49 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 2:10 [Intel-wired-lan] [PATCH iwl-next v1 0/5] iavf: Add devlink and devlink rate support Wenjun Wu
2023-07-27 2:10 ` [Intel-wired-lan] [PATCH iwl-next v1 1/5] virtchnl: support queue rate limit and quanta size configuration Wenjun Wu
2023-07-31 22:22 ` Tony Nguyen
2023-08-01 9:24 ` Wu, Wenjun1
2023-07-27 2:10 ` [Intel-wired-lan] [PATCH iwl-next v1 2/5] ice: Support VF " Wenjun Wu
2023-07-31 22:23 ` Tony Nguyen
2023-08-01 9:30 ` Wu, Wenjun1
2023-07-27 2:10 ` [Intel-wired-lan] [PATCH iwl-next v1 3/5] iavf: Add devlink and devlink port support Wenjun Wu
2023-07-27 2:10 ` [Intel-wired-lan] [PATCH iwl-next v1 4/5] iavf: Add devlink port function rate API support Wenjun Wu
2023-07-27 2:10 ` [Intel-wired-lan] [PATCH iwl-next v1 5/5] iavf: Add VIRTCHNL Opcodes Support for Queue bw Setting Wenjun Wu
2023-07-31 22:21 ` [Intel-wired-lan] [PATCH iwl-next v1 0/5] iavf: Add devlink and devlink rate support Tony Nguyen
2023-08-01 18:43 ` Zhang, Xuejun
2023-08-08 1:57 ` [PATCH iwl-next v2 " Wenjun Wu
2023-08-08 1:57 ` [Intel-wired-lan] " Wenjun Wu
2023-08-08 1:57 ` [PATCH iwl-next v2 1/5] virtchnl: support queue rate limit and quanta size configuration Wenjun Wu
2023-08-08 1:57 ` [Intel-wired-lan] " Wenjun Wu
2023-08-08 1:57 ` [PATCH iwl-next v2 2/5] ice: Support VF " Wenjun Wu
2023-08-08 1:57 ` [Intel-wired-lan] " Wenjun Wu
2023-08-16 16:54 ` Brett Creeley
2023-08-16 16:54 ` [Intel-wired-lan] " Brett Creeley
2023-08-08 1:57 ` [PATCH iwl-next v2 3/5] iavf: Add devlink and devlink port support Wenjun Wu
2023-08-08 1:57 ` [Intel-wired-lan] " Wenjun Wu
2023-08-16 17:11 ` Brett Creeley
2023-08-16 17:11 ` [Intel-wired-lan] " Brett Creeley
2023-08-08 1:57 ` [PATCH iwl-next v2 4/5] iavf: Add devlink port function rate API support Wenjun Wu
2023-08-08 1:57 ` [Intel-wired-lan] " Wenjun Wu
2023-08-08 20:49 ` Simon Horman [this message]
2023-08-08 20:49 ` Simon Horman
2023-08-09 18:43 ` Zhang, Xuejun
2023-08-09 18:43 ` Zhang, Xuejun
2023-08-16 17:27 ` Brett Creeley
2023-08-16 17:27 ` [Intel-wired-lan] " Brett Creeley
2023-08-08 1:57 ` [PATCH iwl-next v2 5/5] iavf: Add VIRTCHNL Opcodes Support for Queue bw Setting Wenjun Wu
2023-08-08 1:57 ` [Intel-wired-lan] " Wenjun Wu
2023-08-08 20:54 ` Simon Horman
2023-08-08 20:54 ` Simon Horman
2023-08-09 18:44 ` [Intel-wired-lan] " Zhang, Xuejun
2023-08-09 18:44 ` Zhang, Xuejun
2023-08-16 17:32 ` Brett Creeley
2023-08-16 17:32 ` [Intel-wired-lan] " Brett Creeley
2023-08-16 3:33 ` [PATCH iwl-next v3 0/5] iavf: Add devlink and devlink rate support Wenjun Wu
2023-08-16 3:33 ` [Intel-wired-lan] " Wenjun Wu
2023-08-16 3:33 ` [PATCH iwl-next v3 1/5] virtchnl: support queue rate limit and quanta size configuration Wenjun Wu
2023-08-16 3:33 ` [Intel-wired-lan] " Wenjun Wu
2023-08-16 3:33 ` [PATCH iwl-next v3 2/5] ice: Support VF " Wenjun Wu
2023-08-16 3:33 ` [Intel-wired-lan] " Wenjun Wu
2023-08-16 3:33 ` [PATCH iwl-next v3 3/5] iavf: Add devlink and devlink port support Wenjun Wu
2023-08-16 3:33 ` [Intel-wired-lan] " Wenjun Wu
2023-08-16 3:33 ` [PATCH iwl-next v3 4/5] iavf: Add devlink port function rate API support Wenjun Wu
2023-08-16 3:33 ` [Intel-wired-lan] " Wenjun Wu
2023-08-16 3:33 ` [PATCH iwl-next v3 5/5] iavf: Add VIRTCHNL Opcodes Support for Queue bw Setting Wenjun Wu
2023-08-16 3:33 ` [Intel-wired-lan] " Wenjun Wu
2023-08-16 9:14 ` Simon Horman
2023-08-16 9:14 ` [Intel-wired-lan] " Simon Horman
2023-08-22 3:39 ` [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support Wenjun Wu
2023-08-22 3:39 ` [Intel-wired-lan] " Wenjun Wu
2023-08-22 3:39 ` [PATCH iwl-next v4 1/5] virtchnl: support queue rate limit and quanta size configuration Wenjun Wu
2023-08-22 3:39 ` [Intel-wired-lan] " Wenjun Wu
2023-08-22 3:40 ` [PATCH iwl-next v4 2/5] ice: Support VF " Wenjun Wu
2023-08-22 3:40 ` [Intel-wired-lan] " Wenjun Wu
2023-08-22 3:40 ` [PATCH iwl-next v4 3/5] iavf: Add devlink and devlink port support Wenjun Wu
2023-08-22 3:40 ` [Intel-wired-lan] " Wenjun Wu
2023-08-22 3:40 ` [PATCH iwl-next v4 4/5] iavf: Add devlink port function rate API support Wenjun Wu
2023-08-22 3:40 ` [Intel-wired-lan] " Wenjun Wu
2023-08-22 3:40 ` [PATCH iwl-next v4 5/5] iavf: Add VIRTCHNL Opcodes Support for Queue bw Setting Wenjun Wu
2023-08-22 3:40 ` [Intel-wired-lan] " Wenjun Wu
2023-08-22 6:12 ` [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support Jiri Pirko
2023-08-22 6:12 ` [Intel-wired-lan] " Jiri Pirko
2023-08-22 15:12 ` Jakub Kicinski
2023-08-22 15:12 ` Jakub Kicinski
2023-08-22 15:34 ` [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support' Jiri Pirko
2023-08-22 15:34 ` [Intel-wired-lan] " Jiri Pirko
2023-08-23 19:13 ` Zhang, Xuejun
2023-08-24 7:04 ` Jiri Pirko
2023-08-24 7:04 ` [Intel-wired-lan] " Jiri Pirko
2023-08-28 22:46 ` Zhang, Xuejun
2023-08-28 22:46 ` [Intel-wired-lan] " Zhang, Xuejun
2023-11-17 5:52 ` Zhang, Xuejun
2023-11-17 5:52 ` Zhang, Xuejun
2023-11-17 11:21 ` Jiri Pirko
2023-11-17 11:21 ` Jiri Pirko
2023-11-21 9:04 ` Paolo Abeni
2023-11-21 9:04 ` Paolo Abeni
2023-11-18 16:48 ` Jakub Kicinski
2023-11-18 16:48 ` Jakub Kicinski
2023-11-22 22:19 ` Zhang, Xuejun
2023-11-22 22:19 ` Zhang, Xuejun
2023-11-23 3:22 ` Jakub Kicinski
2023-11-23 3:22 ` Jakub Kicinski
2023-11-28 0:15 ` Zhang, Xuejun
2023-11-28 0:15 ` Zhang, Xuejun
2023-11-28 1:43 ` Jakub Kicinski
2023-11-28 1:43 ` Jakub Kicinski
2023-12-14 20:29 ` Paolo Abeni
2023-12-14 20:29 ` Paolo Abeni
2023-12-15 1:46 ` Jakub Kicinski
2023-12-15 1:46 ` Jakub Kicinski
2023-12-15 11:06 ` Paolo Abeni
2023-12-15 11:06 ` Paolo Abeni
2023-12-15 11:47 ` Paolo Abeni
2023-12-15 11:47 ` Paolo Abeni
2023-12-15 12:30 ` Jiri Pirko
2023-12-15 12:30 ` Jiri Pirko
2023-12-15 22:41 ` Jakub Kicinski
2023-12-15 22:41 ` Jakub Kicinski
2023-12-18 20:12 ` Paolo Abeni
2023-12-18 20:12 ` Paolo Abeni
2023-12-18 21:33 ` Jakub Kicinski
2023-12-18 21:33 ` Jakub Kicinski
2023-12-15 12:22 ` Jiri Pirko
2023-12-15 12:22 ` Jiri Pirko
2023-10-18 9:05 ` Paolo Abeni
2023-10-18 9:05 ` [Intel-wired-lan] " Paolo Abeni
2023-08-23 21:39 ` Zhang, Xuejun
2023-08-23 21:39 ` Zhang, Xuejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNKqYlC86siUsRzd@vergenet.net \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=qi.z.zhang@intel.com \
--cc=wenjun1.wu@intel.com \
--cc=xuejun.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.