* [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name
@ 2021-08-11 18:02 Lucas De Marchi
2021-08-11 18:02 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_edid: fix string padding Lucas De Marchi
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Lucas De Marchi @ 2021-08-11 18:02 UTC (permalink / raw
To: igt-dev; +Cc: kunal1.joshi, petri.latvala, Simon Ser
Byte 26 in a edid struct is supposed to be "Blue and white
least-significant 2 bits", not "black and white". Rename the field
accordingly.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
lib/igt_edid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_edid.h b/lib/igt_edid.h
index 7c2ce123..aac2f4a2 100644
--- a/lib/igt_edid.h
+++ b/lib/igt_edid.h
@@ -350,7 +350,7 @@ struct edid {
uint8_t features;
/* Color characteristics */
uint8_t red_green_lo;
- uint8_t black_white_lo;
+ uint8_t blue_white_lo;
uint8_t red_x;
uint8_t red_y;
uint8_t green_x;
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] lib/igt_edid: fix string padding
2021-08-11 18:02 [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name Lucas De Marchi
@ 2021-08-11 18:02 ` Lucas De Marchi
2021-08-11 18:20 ` Simon Ser
2021-08-12 7:51 ` Petri Latvala
2021-08-11 18:12 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name Simon Ser
` (2 subsequent siblings)
3 siblings, 2 replies; 8+ messages in thread
From: Lucas De Marchi @ 2021-08-11 18:02 UTC (permalink / raw
To: igt-dev; +Cc: kunal1.joshi, petri.latvala, Simon Ser
While checking a fix for the warning
[2/390] Compiling C object lib/libigt-igt_edid_c.a.p/igt_edid.c.o
In file included from /usr/include/string.h:519,
from ../lib/igt_edid.c:29:
In function ‘strncpy’,
inlined from ‘detailed_timing_set_string’ at ../lib/igt_edid.c:186:2:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:95:10: warning: ‘__builtin_strncpy’ specified bound 13 equals destination size [-Wstringop-truncation]
95 | return __builtin___strncpy_chk (__dest, __src, __len,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
96 | __glibc_objsize (__dest));
| ~~~~~~~~~~~~~~~~~~~~~~~~~
... I noticed we were not following the spec to the letter.
According to EDID 1.3 data format, EDID Other Monitor Descriptors has the this
information for bytes 5-17: "Defined by descriptor type. If text, code page 437
text, terminated (if less than 13 bytes) with LF and padded with SP."
So, while fixing the warning, also guarantee we correctly pad the field.
The only caller sets it to "IGT", so previously we would set the field
would alway be 'IGT\n\0\0\0\0\0\0\0\0\0', since all the callers
zero-initialize the struct.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
lib/igt_edid.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/lib/igt_edid.c b/lib/igt_edid.c
index 6fe984d9..df346c4c 100644
--- a/lib/igt_edid.c
+++ b/lib/igt_edid.c
@@ -31,6 +31,7 @@
#include <time.h>
#include <xf86drmMode.h>
+#include "igt_aux.h"
#include "igt_core.h"
#include "igt_edid.h"
@@ -183,10 +184,14 @@ void detailed_timing_set_string(struct detailed_timing *dt,
np->type = type;
- strncpy(ds->str, str, sizeof(ds->str));
- len = strlen(str);
+ len = min(strlen(str), sizeof(ds->str));
+ memcpy(ds->str, str, len);
+
if (len < sizeof(ds->str))
- ds->str[len] = '\n';
+ ds->str[len++] = '\n';
+
+ while (len < sizeof(ds->str))
+ ds->str[len++] = ' ';
}
/**
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name
2021-08-11 18:02 [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name Lucas De Marchi
2021-08-11 18:02 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_edid: fix string padding Lucas De Marchi
@ 2021-08-11 18:12 ` Simon Ser
2021-08-11 20:28 ` Lucas De Marchi
2021-08-11 18:54 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2021-08-11 21:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 1 reply; 8+ messages in thread
From: Simon Ser @ 2021-08-11 18:12 UTC (permalink / raw
To: Lucas De Marchi; +Cc: igt-dev, kunal1.joshi, petri.latvala
Reviewed-by: Simon Ser <contact@emersion.fr>
Can you also send a patch to fix the kernel? struct edid comes from
include/drm/drm_edid.h.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] lib/igt_edid: fix string padding
2021-08-11 18:02 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_edid: fix string padding Lucas De Marchi
@ 2021-08-11 18:20 ` Simon Ser
2021-08-12 7:51 ` Petri Latvala
1 sibling, 0 replies; 8+ messages in thread
From: Simon Ser @ 2021-08-11 18:20 UTC (permalink / raw
To: Lucas De Marchi; +Cc: igt-dev, kunal1.joshi, petri.latvala
This patch LGTM as well.
Reviewed-by: Simon Ser <contact@emersion.fr>
Thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib/igt_edid: fix edid field name
2021-08-11 18:02 [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name Lucas De Marchi
2021-08-11 18:02 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_edid: fix string padding Lucas De Marchi
2021-08-11 18:12 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name Simon Ser
@ 2021-08-11 18:54 ` Patchwork
2021-08-11 21:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-08-11 18:54 UTC (permalink / raw
To: Lucas De Marchi; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 2028 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/2] lib/igt_edid: fix edid field name
URL : https://patchwork.freedesktop.org/series/93607/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10468 -> IGTPW_6116
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/index.html
Known issues
------------
Here are the changes found in IGTPW_6116 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- {fi-tgl-dsi}: [DMESG-FAIL][1] ([i915#1993]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/fi-tgl-dsi/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/fi-tgl-dsi/igt@i915_selftest@live@execlists.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1993]: https://gitlab.freedesktop.org/drm/intel/issues/1993
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3717]: https://gitlab.freedesktop.org/drm/intel/issues/3717
Participating hosts (41 -> 35)
------------------------------
Additional (1): fi-dg1-1
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus bat-jsl-1
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6170 -> IGTPW_6116
CI-20190529: 20190529
CI_DRM_10468: 699475ca117e572b6ecd75c864a945786c8cc3ed @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6116: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/index.html
IGT_6170: d4ff2b4ab88d62a1888cb0316e70a1729fe4a685 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/index.html
[-- Attachment #2: Type: text/html, Size: 2424 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name
2021-08-11 18:12 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name Simon Ser
@ 2021-08-11 20:28 ` Lucas De Marchi
0 siblings, 0 replies; 8+ messages in thread
From: Lucas De Marchi @ 2021-08-11 20:28 UTC (permalink / raw
To: Simon Ser; +Cc: igt-dev, kunal1.joshi, petri.latvala
On Wed, Aug 11, 2021 at 06:12:17PM +0000, Simon Ser wrote:
>Reviewed-by: Simon Ser <contact@emersion.fr>
>
>Can you also send a patch to fix the kernel? struct edid comes from
>include/drm/drm_edid.h.
will do, thanks.
Lucas De Marchi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib/igt_edid: fix edid field name
2021-08-11 18:02 [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name Lucas De Marchi
` (2 preceding siblings ...)
2021-08-11 18:54 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
@ 2021-08-11 21:35 ` Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2021-08-11 21:35 UTC (permalink / raw
To: Lucas De Marchi; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 30284 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/2] lib/igt_edid: fix edid field name
URL : https://patchwork.freedesktop.org/series/93607/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10468_full -> IGTPW_6116_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/index.html
Known issues
------------
Here are the changes found in IGTPW_6116_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_create@create-massive:
- shard-iclb: NOTRUN -> [DMESG-WARN][1] ([i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb4/igt@gem_create@create-massive.html
* igt@gem_ctx_persistence@idempotent:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-snb5/igt@gem_ctx_persistence@idempotent.html
* igt@gem_ctx_persistence@legacy-engines-hang@render:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2410])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-glk8/igt@gem_ctx_persistence@legacy-engines-hang@render.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk6/igt@gem_ctx_persistence@legacy-engines-hang@render.html
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][5] -> [TIMEOUT][6] ([i915#2369] / [i915#3063] / [i915#3648])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-tglb7/igt@gem_eio@unwedge-stress.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb3/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: NOTRUN -> [FAIL][7] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl3/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl1/igt@gem_exec_fair@basic-none@vecs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl3/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb7/igt@gem_exec_fair@basic-pace@vecs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb3/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][12] -> [FAIL][13] ([i915#2849])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: [PASS][14] -> [DMESG-WARN][15] ([i915#118] / [i915#95]) +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-glk5/igt@gem_exec_whisper@basic-queues-all.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk5/igt@gem_exec_whisper@basic-queues-all.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#1888] / [i915#307] / [i915#3468])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-glk6/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk7/igt@gem_mmap_gtt@cpuset-basic-small-copy-odd.html
* igt@gem_render_copy@y-tiled-to-vebox-linear:
- shard-iclb: NOTRUN -> [SKIP][18] ([i915#768]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb2/igt@gem_render_copy@y-tiled-to-vebox-linear.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy@fixed:
- shard-iclb: NOTRUN -> [SKIP][19] ([i915#3922])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy@fixed.html
- shard-tglb: NOTRUN -> [SKIP][20] ([i915#3922])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy@fixed.html
* igt@gem_userptr_blits@unsync-overlap:
- shard-iclb: NOTRUN -> [SKIP][21] ([i915#3297])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb2/igt@gem_userptr_blits@unsync-overlap.html
* igt@gen9_exec_parse@bb-chained:
- shard-iclb: NOTRUN -> [SKIP][22] ([i915#2856])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb2/igt@gen9_exec_parse@bb-chained.html
* igt@i915_pm_backlight@bad-brightness:
- shard-glk: NOTRUN -> [SKIP][23] ([fdo#109271]) +67 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk4/igt@i915_pm_backlight@bad-brightness.html
* igt@i915_pm_dc@dc5-dpms:
- shard-kbl: NOTRUN -> [FAIL][24] ([i915#545])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl6/igt@i915_pm_dc@dc5-dpms.html
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: NOTRUN -> [FAIL][25] ([i915#454])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb1/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][26] ([i915#579]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb1/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-tglb: NOTRUN -> [SKIP][27] ([i915#579])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb1/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: NOTRUN -> [DMESG-WARN][28] ([i915#118] / [i915#95])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk9/igt@kms_big_fb@linear-32bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-180:
- shard-kbl: [PASS][29] -> [INCOMPLETE][30] ([i915#155] / [i915#2295])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl7/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl6/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-glk: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#3777]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
- shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3777])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl3/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3777]) +4 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][34] ([fdo#109271]) +240 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl3/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#110723]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb4/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#111615])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb2/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#109278] / [i915#3886]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb8/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#3886])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl2/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3886]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk6/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3886]) +11 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl1/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][41] ([i915#3689]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb7/igt@kms_ccs@pipe-d-ccs-on-another-bo-y_tiled_ccs.html
* igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][42] ([fdo#109271]) +97 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl7/igt@kms_ccs@pipe-d-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +7 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl2/igt@kms_chamelium@dp-hpd-for-each-pipe.html
* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +18 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl7/igt@kms_chamelium@dp-mode-timings.html
* igt@kms_chamelium@hdmi-crc-single:
- shard-glk: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk7/igt@kms_chamelium@hdmi-crc-single.html
* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109284] / [fdo#111827]) +8 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb4/igt@kms_chamelium@hdmi-hpd-enable-disable-mode.html
* igt@kms_chamelium@vga-frame-dump:
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#109284] / [fdo#111827]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb7/igt@kms_chamelium@vga-frame-dump.html
* igt@kms_color@pipe-d-ctm-0-25:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109278] / [i915#1149])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb7/igt@kms_color@pipe-d-ctm-0-25.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-snb: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +21 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-snb2/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_content_protection@uevent:
- shard-kbl: NOTRUN -> [FAIL][50] ([i915#2105])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl1/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109278] / [fdo#109279]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb7/igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding.html
* igt@kms_cursor_crc@pipe-c-cursor-512x512-onscreen:
- shard-tglb: NOTRUN -> [SKIP][52] ([fdo#109279] / [i915#3359])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb8/igt@kms_cursor_crc@pipe-c-cursor-512x512-onscreen.html
* igt@kms_cursor_crc@pipe-c-cursor-dpms:
- shard-apl: [PASS][53] -> [FAIL][54] ([i915#3444])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-dpms.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl7/igt@kms_cursor_crc@pipe-c-cursor-dpms.html
- shard-kbl: [PASS][55] -> [FAIL][56] ([i915#3444])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-dpms.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-dpms.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: NOTRUN -> [DMESG-WARN][57] ([i915#180]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109278]) +23 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb3/igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement.html
- shard-tglb: NOTRUN -> [SKIP][59] ([i915#3319])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb3/igt@kms_cursor_crc@pipe-d-cursor-32x32-rapid-movement.html
* igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][60] ([i915#3359]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-max-size-rapid-movement.html
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109274] / [fdo#109278]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb5/igt@kms_cursor_legacy@cursora-vs-flipb-atomic.html
* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-glk: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#533]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk6/igt@kms_cursor_legacy@pipe-d-single-bo.html
* igt@kms_flip@2x-flip-vs-rmfb:
- shard-tglb: NOTRUN -> [SKIP][63] ([fdo#111825]) +8 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb7/igt@kms_flip@2x-flip-vs-rmfb.html
* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-iclb: NOTRUN -> [SKIP][64] ([fdo#109274]) +4 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb8/igt@kms_flip@2x-modeset-vs-vblank-race-interruptible.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [PASS][65] -> [DMESG-WARN][66] ([i915#180])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-apl6/igt@kms_flip@flip-vs-suspend@c-dp1.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-kbl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#2672])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109280]) +13 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb8/igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt.html
* igt@kms_hdmi_inject@inject-audio:
- shard-kbl: [PASS][69] -> [SKIP][70] ([fdo#109271])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl3/igt@kms_hdmi_inject@inject-audio.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl7/igt@kms_hdmi_inject@inject-audio.html
- shard-iclb: [PASS][71] -> [SKIP][72] ([i915#433])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb8/igt@kms_hdmi_inject@inject-audio.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb3/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_hdr@static-toggle-dpms:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#1187])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb7/igt@kms_hdr@static-toggle-dpms.html
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#1187])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb8/igt@kms_hdr@static-toggle-dpms.html
* igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109289]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb8/igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c.html
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109289])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb2/igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#533]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl3/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-kbl: [PASS][78] -> [DMESG-WARN][79] ([i915#180]) +3 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][80] ([fdo#108145] / [i915#265]) +4 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
- shard-glk: NOTRUN -> [FAIL][81] ([fdo#108145] / [i915#265])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk1/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][82] ([fdo#108145] / [i915#265]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#658]) +4 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#658])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#658]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][86] -> [SKIP][87] ([fdo#109642] / [fdo#111068] / [i915#658])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb8/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109441]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb3/igt@kms_psr@psr2_cursor_render.html
* igt@kms_psr@psr2_dpms:
- shard-tglb: NOTRUN -> [FAIL][89] ([i915#132] / [i915#3467]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb1/igt@kms_psr@psr2_dpms.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][90] -> [SKIP][91] ([fdo#109441]) +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb8/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-d-query-forked-hang:
- shard-snb: NOTRUN -> [SKIP][92] ([fdo#109271]) +398 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-snb5/igt@kms_vblank@pipe-d-query-forked-hang.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#533]) +3 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl7/igt@kms_vblank@pipe-d-wait-idle.html
* igt@nouveau_crc@pipe-a-source-rg:
- shard-iclb: NOTRUN -> [SKIP][94] ([i915#2530]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb5/igt@nouveau_crc@pipe-a-source-rg.html
* igt@prime_nv_pcopy@test_semaphore:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109291]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb8/igt@prime_nv_pcopy@test_semaphore.html
- shard-tglb: NOTRUN -> [SKIP][96] ([fdo#109291])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb7/igt@prime_nv_pcopy@test_semaphore.html
* igt@sysfs_clients@fair-3:
- shard-iclb: NOTRUN -> [SKIP][97] ([i915#2994])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb4/igt@sysfs_clients@fair-3.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#2994]) +4 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl7/igt@sysfs_clients@fair-7.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][99] ([i915#2846]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl1/igt@gem_exec_fair@basic-deadline.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [FAIL][101] ([i915#2842]) -> [PASS][102] +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-glk3/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk7/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][103] ([i915#2842]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb1/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][105] ([i915#2842]) -> [PASS][106] +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-glk: [DMESG-WARN][107] ([i915#118] / [i915#95]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-glk4/igt@gem_exec_whisper@basic-contexts-forked-all.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-glk3/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][109] ([i915#2190]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-tglb6/igt@gem_huc_copy@huc-copy.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-tglb5/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [FAIL][111] ([i915#307]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb7/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb3/igt@gem_mmap_gtt@cpuset-big-copy-xy.html
* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-iclb: [DMESG-WARN][113] ([i915#3621]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb1/igt@kms_big_fb@linear-32bpp-rotate-0.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb3/igt@kms_big_fb@linear-32bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [DMESG-WARN][115] ([i915#180]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-kbl: [FAIL][117] ([i915#2546]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-badstride.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][119] ([fdo#109441]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb1/igt@kms_psr@psr2_primary_blt.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
* igt@prime_vgem@sync@rcs0:
- shard-iclb: [INCOMPLETE][121] ([i915#409]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb1/igt@prime_vgem@sync@rcs0.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb7/igt@prime_vgem@sync@rcs0.html
#### Warnings ####
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][123] ([i915#658]) -> [SKIP][124] ([i915#2920]) +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-iclb: [SKIP][125] ([i915#2920]) -> [SKIP][126] ([i915#658])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb7/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130]) ([i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363]) -> ([FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl6/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl3/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl3/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-kbl2/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl1/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl3/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl1/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl3/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl1/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-kbl3/igt@runner@aborted.html
- shard-iclb: ([FAIL][137], [FAIL][138], [FAIL][139]) ([i915#1814] / [i915#2426] / [i915#3002] / [i915#3690] / [i915#409]) -> ([FAIL][140], [FAIL][141]) ([i915#3002])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb1/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb3/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-iclb1/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb4/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-iclb8/igt@runner@aborted.html
- shard-apl: ([FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145]) ([i915#180] / [i915#3002] / [i915#3363]) -> ([FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149]) ([i915#1610] / [i915#180] / [i915#1814] / [i915#2292] / [i915#3002] / [i915#3363])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-apl1/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-apl1/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-apl7/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10468/shard-apl2/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl1/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/shard-apl6/ig
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6116/index.html
[-- Attachment #2: Type: text/html, Size: 34128 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] lib/igt_edid: fix string padding
2021-08-11 18:02 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_edid: fix string padding Lucas De Marchi
2021-08-11 18:20 ` Simon Ser
@ 2021-08-12 7:51 ` Petri Latvala
1 sibling, 0 replies; 8+ messages in thread
From: Petri Latvala @ 2021-08-12 7:51 UTC (permalink / raw
To: Lucas De Marchi; +Cc: igt-dev, kunal1.joshi, Simon Ser
On Wed, Aug 11, 2021 at 11:02:17AM -0700, Lucas De Marchi wrote:
> While checking a fix for the warning
>
> [2/390] Compiling C object lib/libigt-igt_edid_c.a.p/igt_edid.c.o
> In file included from /usr/include/string.h:519,
> from ../lib/igt_edid.c:29:
> In function ‘strncpy’,
> inlined from ‘detailed_timing_set_string’ at ../lib/igt_edid.c:186:2:
> /usr/include/x86_64-linux-gnu/bits/string_fortified.h:95:10: warning: ‘__builtin_strncpy’ specified bound 13 equals destination size [-Wstringop-truncation]
> 95 | return __builtin___strncpy_chk (__dest, __src, __len,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 96 | __glibc_objsize (__dest));
> | ~~~~~~~~~~~~~~~~~~~~~~~~~
>
> ... I noticed we were not following the spec to the letter.
> According to EDID 1.3 data format, EDID Other Monitor Descriptors has the this
> information for bytes 5-17: "Defined by descriptor type. If text, code page 437
> text, terminated (if less than 13 bytes) with LF and padded with SP."
> So, while fixing the warning, also guarantee we correctly pad the field.
> The only caller sets it to "IGT", so previously we would set the field
> would alway be 'IGT\n\0\0\0\0\0\0\0\0\0', since all the callers
> zero-initialize the struct.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> lib/igt_edid.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/lib/igt_edid.c b/lib/igt_edid.c
> index 6fe984d9..df346c4c 100644
> --- a/lib/igt_edid.c
> +++ b/lib/igt_edid.c
> @@ -31,6 +31,7 @@
> #include <time.h>
> #include <xf86drmMode.h>
>
> +#include "igt_aux.h"
> #include "igt_core.h"
> #include "igt_edid.h"
>
> @@ -183,10 +184,14 @@ void detailed_timing_set_string(struct detailed_timing *dt,
>
> np->type = type;
>
> - strncpy(ds->str, str, sizeof(ds->str));
> - len = strlen(str);
> + len = min(strlen(str), sizeof(ds->str));
> + memcpy(ds->str, str, len);
> +
> if (len < sizeof(ds->str))
> - ds->str[len] = '\n';
> + ds->str[len++] = '\n';
> +
> + while (len < sizeof(ds->str))
> + ds->str[len++] = ' ';
> }
Ah, much better than my own scuffed attempt at this earlier, thanks.
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-08-12 7:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-11 18:02 [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name Lucas De Marchi
2021-08-11 18:02 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_edid: fix string padding Lucas De Marchi
2021-08-11 18:20 ` Simon Ser
2021-08-12 7:51 ` Petri Latvala
2021-08-11 18:12 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_edid: fix edid field name Simon Ser
2021-08-11 20:28 ` Lucas De Marchi
2021-08-11 18:54 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2021-08-11 21:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.