From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC5FEC49EA6 for ; Sat, 26 Jun 2021 18:40:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18D8861C29 for ; Sat, 26 Jun 2021 18:40:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18D8861C29 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F013782C34; Sat, 26 Jun 2021 20:40:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="aYh005H5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4FD2582C36; Sat, 26 Jun 2021 20:40:26 +0200 (CEST) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C8EAA82C2E for ; Sat, 26 Jun 2021 20:40:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wm1-x330.google.com with SMTP id p8-20020a7bcc880000b02901dbb595a9f1so8007653wma.2 for ; Sat, 26 Jun 2021 11:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=o9RB6DOMVOs4caPDaa7lw+CJ8rLbgCVXXCkcuCIlhww=; b=aYh005H53k1oTS2haGQEPg6baJZH29rrgR00I+peK/1W4LYukFk2k5XmGQWf6EhpCZ W2lKiOorzr7RqWZSu9GsxNjhiK+XQfnyeIkfqh4bZkFLWYg8XFtL5ldDzL8VH6lWI0fK JgZ7QWMLmqMg4G1g9L+TJy2AS6ShHB+9o/cbex4R+KXkWRXwUpCK9bkkiHccP9PNTB2g sfnvaw0qobY8MhHY01MRS3qq1E9PFb3ls3FAN1uW8zDrBVUK96/Uo8frCcvDEa8vzUkn 9tGQhwFJXevnsmc9qPgDLYUQPe7T0v4RP1pTo//821m4b6j0xBnIzudmtGIJro1KU2E2 UB0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o9RB6DOMVOs4caPDaa7lw+CJ8rLbgCVXXCkcuCIlhww=; b=jz8fZ1F5iQ9r1vEVrVvvVurYFkYgWbYH/9+EjvDdKTPjMXoIzYwhgvjaMrK6LrFPTs zankh5gFx+nkBpFXSMOcd9JLmPZuq+jlTMP9NMMRa0ykCJF1POTfsAjYW7bSRd92Tj+x dYrT2d/7jVNCa8y5lBT6dxw7M0ExwLcx8JuWa76j/qJWDL6a50GWpbBn70noczaaXy8I 2NX/QiAaZWUeKb4SAc8GPGyM99GD+yhiAmajGXg/aT/xU1dgsOXLqIIQwa1nX/eitwWm WTqlAW3MI/3tX3v0k3cwzaTbk0OyaW7ixEMk4EWURCWmNFLkuAWM8eH3xNCl9oSWB8wU TqKw== X-Gm-Message-State: AOAM53004c6qkn3CF7NrVAicEpCgOSHmBCyvedyM+1NWI5YXkdks7AtB /Gl+Z25Lcb4JoTaYr5b/rDeoJg== X-Google-Smtp-Source: ABdhPJyLcYbQ41OneDJnNEcbOfxNVPygeuHjPqrvQm0IuEqwYCIaV1GjPoWDVfx/epg31F/zO+eMOg== X-Received: by 2002:a1c:ddd6:: with SMTP id u205mr17772453wmg.63.1624732823422; Sat, 26 Jun 2021 11:40:23 -0700 (PDT) Received: from enceladus (athedsl-419796.home.otenet.gr. [79.131.191.210]) by smtp.gmail.com with ESMTPSA id f19sm9259897wre.48.2021.06.26.11.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Jun 2021 11:40:22 -0700 (PDT) Date: Sat, 26 Jun 2021 21:40:20 +0300 From: Ilias Apalodimas To: Simon Glass Cc: Heinrich Schuchardt , Bin Meng , Christian Gmeiner , U-Boot Mailing List Subject: Re: [PATCH] smbios: Fix BIOS Characteristics Extension Byte 2 Message-ID: References: <20210609151448.828133-1-ilias.apalodimas@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, > > t->bios_characteristics_ext1 = BIOS_CHARACTERISTICS_EXT1_ACPI; [...] > > #endif > > #ifdef CONFIG_EFI_LOADER > > Can you please drop this #ifdef while you are here - should use IS_ENABLED() > I think Heinrich already merged those and sent a request to Tom. Regardless I'll send a follow up chaning this as well > > - t->bios_characteristics_ext1 |= BIOS_CHARACTERISTICS_EXT1_UEFI; > > + t->bios_characteristics_ext2 |= BIOS_CHARACTERISTICS_EXT2_UEFI; > > #endif > > - t->bios_characteristics_ext2 = BIOS_CHARACTERISTICS_EXT2_TARGET; > > + t->bios_characteristics_ext2 |= BIOS_CHARACTERISTICS_EXT2_TARGET; > > > > /* bios_major_release has only one byte, so drop century */ > > t->bios_major_release = U_BOOT_VERSION_NUM % 100; > > -- > > 2.32.0.rc0 > > > > Regards, > Simon Cheers /Ilias