From: Clayton Casciato <majortomtosourcecontrol@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] apci: sysfs: Fixed void function style code issues
Date: Tue, 15 Jun 2021 22:11:32 -0600 [thread overview]
Message-ID: <YMl59Ez79goPxgW7@fedora> (raw)
In-Reply-To: <CAJZ5v0g1iO2_+Pp9j2Y366acnwfgPv9tLDH0PWFHKw+HFWULEw@mail.gmail.com>
On Mon, Jun 14, 2021 at 05:30:25PM +0200, Rafael J. Wysocki wrote:
> On Sat, Jun 12, 2021 at 10:10 PM Clayton Casciato
> <majortomtosourcecontrol@gmail.com> wrote:
> >
> > Fixed coding style issues.
> >
> > Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com>
> > ---
> > drivers/acpi/sysfs.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
> > index d25927195d6d..d6626aba4a6a 100644
> > --- a/drivers/acpi/sysfs.c
> > +++ b/drivers/acpi/sysfs.c
> > @@ -582,8 +582,6 @@ static void delete_gpe_attr_array(void)
> > kfree(counter_attrs);
> > }
> > kfree(all_attrs);
> > -
> > - return;
> > }
> >
> > static void gpe_count(u32 gpe_number)
> > @@ -598,8 +596,6 @@ static void gpe_count(u32 gpe_number)
> > else
> > all_counters[num_gpes + ACPI_NUM_FIXED_EVENTS +
> > COUNT_ERROR].count++;
> > -
> > - return;
> > }
> >
> > static void fixed_event_count(u32 event_number)
> > @@ -612,8 +608,6 @@ static void fixed_event_count(u32 event_number)
> > else
> > all_counters[num_gpes + ACPI_NUM_FIXED_EVENTS +
> > COUNT_ERROR].count++;
> > -
> > - return;
> > }
> >
> > static void acpi_global_event_handler(u32 event_type, acpi_handle device,
> > @@ -914,8 +908,6 @@ static void __exit interrupt_stats_exit(void)
> > sysfs_remove_group(acpi_kobj, &interrupt_stats_attr_group);
> >
> > delete_gpe_attr_array();
> > -
> > - return;
> > }
> >
> > static ssize_t
> > --
>
> Applied as 5.14 material with edited subject and changelog.
>
> Thanks!
I'm not sure how to find the edits.
Did you note them for transparency or would you recommend I do something
different in the future?
These are my first patches and any feedback you'd be willing to provide
would be appreciated.
Thank you, Rafael!
prev parent reply other threads:[~2021-06-16 4:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 20:09 [PATCH] apci: sysfs: Fixed void function style code issues Clayton Casciato
2021-06-14 15:30 ` Rafael J. Wysocki
2021-06-16 4:11 ` Clayton Casciato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMl59Ez79goPxgW7@fedora \
--to=majortomtosourcecontrol@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.