From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Caleb Connolly <caleb@connolly.tech>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/4] input: add Qualcomm QPNP haptics driver
Date: Sun, 13 Jun 2021 12:11:21 -0500 [thread overview]
Message-ID: <YMY8OcMrDh2D4qVg@yoga> (raw)
In-Reply-To: <b821c5d4-f406-f4bf-638b-59fb20bc2f36@connolly.tech>
On Sun 13 Jun 11:24 CDT 2021, Caleb Connolly wrote:
> Hi Bjorn,
>
> Thanks a lot for your feedback.
>
> On 13/06/2021 5:09 am, Bjorn Andersson wrote:
> > On Sat 12 Jun 15:54 CDT 2021, Caleb Connolly wrote:
> >
> >> Add support for the haptics found in pmi8998 and related PMICs.
> >> Based on the ff-memless interface. Currently this driver provides
> >> a partial implementation of hardware features.
> >>
> >> This driver only supports LRAs (Linear Resonant Actuators) in the "buffer"
> >> mode with a single wave pattern.
> >>
> >> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
> >
> > Please use a cover letter when posting multiple patches.
> I'm not sure why the cover letter didn't make it to your inbox, here's a
> link:
> https://lore.kernel.org/linux-arm-msm/20210612205405.1233588-1-caleb@connolly.tech/
It arrived later, for some reason. Sorry for the fuzz.
> >
> >> ---
> >> drivers/input/misc/Kconfig | 11 +
> >> drivers/input/misc/Makefile | 1 +
> >> drivers/input/misc/qpnp-haptics.c | 1022 +++++++++++++++++++++++++++++
> >> 3 files changed, 1034 insertions(+)
> >> create mode 100644 drivers/input/misc/qpnp-haptics.c
> >>
> >> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> >> index 498cde376981..b5ba03e6cf58 100644
> >> --- a/drivers/input/misc/Kconfig
> >> +++ b/drivers/input/misc/Kconfig
> >> @@ -186,6 +186,17 @@ config INPUT_PMIC8XXX_PWRKEY
> >> To compile this driver as a module, choose M here: the
> >> module will be called pmic8xxx-pwrkey.
> >>
> >> +config INPUT_QPNP_HAPTICS
> >
> > No-one knows what "QPNP" really is, so please name this
> > "INPUT_QCOM_SPMI_HAPTICS"
> >
> >> + tristate "Qualcomm QPNP HAPTICS"
> >> + depends on ARCH_QCOM
> >
> > "depends on SPMI" makes sense here.
> >
> >> + select INPUT_FF_MEMLESS
> >> + help
> >> + This option enables support for the haptics found in pmi8998 and
> >> + related PMICs. Based on the ff-memless interface.
> >> +
> >> + To compile this driver as module, choose M here: the
> >> + module will be called qpnp-haptics.
> >> +
> >> config INPUT_SPARCSPKR
> >> tristate "SPARC Speaker support"
> >> depends on PCI && SPARC64
> >> diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile
> >> index f593beed7e05..c43290163db0 100644
> >> --- a/drivers/input/misc/Makefile
> >> +++ b/drivers/input/misc/Makefile
> >> @@ -65,6 +65,7 @@ obj-$(CONFIG_INPUT_PMIC8XXX_PWRKEY) += pmic8xxx-pwrkey.o
> >> obj-$(CONFIG_INPUT_POWERMATE) += powermate.o
> >> obj-$(CONFIG_INPUT_PWM_BEEPER) += pwm-beeper.o
> >> obj-$(CONFIG_INPUT_PWM_VIBRA) += pwm-vibra.o
> >> +obj-$(CONFIG_INPUT_QPNP_HAPTICS) += qpnp-haptics.o
> >> obj-$(CONFIG_INPUT_RAVE_SP_PWRBUTTON) += rave-sp-pwrbutton.o
> >> obj-$(CONFIG_INPUT_RB532_BUTTON) += rb532_button.o
> >> obj-$(CONFIG_INPUT_REGULATOR_HAPTIC) += regulator-haptic.o
> >> diff --git a/drivers/input/misc/qpnp-haptics.c b/drivers/input/misc/qpnp-haptics.c
> >
> > Again, qcom-spmi-haptics.c
> >
> >> new file mode 100644
> >> index 000000000000..daa7a18ffc7d
> >> --- /dev/null
> >> +++ b/drivers/input/misc/qpnp-haptics.c
> >> @@ -0,0 +1,1022 @@
> >> +// SPDX-License-Identifier: GPL-2.0-only
> >> +/*
> >> + * Copyright (c) 2021, Caleb Connolly <caleb@connolly.tech>
> >> + * Qualcomm Plug and Play haptics driver for pmi8998 and related PMICs.
> >> + * Based on ./pm8xxx-vibrator.c
> >
> > Enough "based on" to warrant carrying some copyrights?
> Hmm, I only stole the input device parts, so perhaps not.
Then I think you can drop this comment as well.
Regards,
Bjorn
prev parent reply other threads:[~2021-06-13 17:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 20:54 input: Introduce QPNP (Qualcomm Plug n Play) haptics found on qcom PMICs Caleb Connolly
2021-06-12 20:54 ` [PATCH 1/4] dt-bindings: input: add Qualcomm QPNP haptics driver Caleb Connolly
2021-06-13 4:18 ` Bjorn Andersson
2021-06-14 13:39 ` Rob Herring
2021-06-12 20:54 ` [PATCH 2/4] " Caleb Connolly
2021-06-13 4:09 ` Bjorn Andersson
2021-06-13 16:24 ` Caleb Connolly
2021-06-13 17:11 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMY8OcMrDh2D4qVg@yoga \
--to=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.