From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Caleb Connolly <caleb@connolly.tech>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: pmi8998: introduce qpnp haptics
Date: Sat, 12 Jun 2021 23:22:24 -0500 [thread overview]
Message-ID: <YMWIABGYJlDEd+c9@yoga> (raw)
In-Reply-To: <20210612205405.1233588-4-caleb@connolly.tech>
On Sat 12 Jun 15:54 CDT 2021, Caleb Connolly wrote:
> Add bindings for Qualcomm QPNP haptics, setting default values used on
> most devices.
>
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
> ---
> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index d230c510d4b7..ccf64c1898d4 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -1,4 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0
> +#include <dt-bindings/input/qcom,qpnp-haptics.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/spmi/spmi.h>
>
> @@ -41,5 +42,20 @@ lab: lab {
> interrupt-names = "sc-err", "ocp";
> };
> };
> +
> + qpnp_haptics: qcom,haptics@c000 {
Also, please label this pmi8998_haptics, to make it easier to find where
it's defined when looking at the .dts.
Thanks,
Bjorn
> + compatible = "qcom,qpnp-haptics";
> + reg = <0xc000 0x100>;
> +
> + interrupts = <0x3 0xc0 0x0 IRQ_TYPE_EDGE_BOTH>,
> + <0x3 0xc0 0x1 IRQ_TYPE_EDGE_BOTH>;
> + interrupt-names = "short", "play";
> +
> + qcom,wave-shape = <HAP_WAVE_SINE>;
> + qcom,play-mode = <HAP_PLAY_BUFFER>;
> + qcom,brake-pattern = <0x3 0x3 0x2 0x1>;
> +
> + status = "disabled";
> + };
> };
> };
> --
> 2.31.1
>
>
prev parent reply other threads:[~2021-06-13 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 20:54 [PATCH 3/4] arm64: dts: qcom: pmi8998: introduce qpnp haptics Caleb Connolly
2021-06-13 4:21 ` Bjorn Andersson
2021-06-13 4:22 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMWIABGYJlDEd+c9@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=caleb@connolly.tech \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.