From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EECFC48BE0 for ; Fri, 11 Jun 2021 08:54:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EB52613C3 for ; Fri, 11 Jun 2021 08:54:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EB52613C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BAD226E874; Fri, 11 Jun 2021 08:54:38 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A7826E874; Fri, 11 Jun 2021 08:54:37 +0000 (UTC) IronPort-SDR: Q9GayliTAOO5+O7lpyD5OTXPBcBBkJ06T4V5QLahExNE6fTKTlpHEbnOMIIbH9srO0BLvGE8sC h7Exp8TPg5GA== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="203655245" X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="203655245" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 01:54:36 -0700 IronPort-SDR: +ymItIaFr5iG13sDsC15ksfQ3edEWSkEP1szTvNLaRSlqBOHnUzKlvtAS7JAQ3j5uPpqkKSrF3 kb/En17ggAwg== X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="403155412" Received: from anunitax-mobl1.gar.corp.intel.com (HELO intel.com) ([10.254.36.102]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 01:54:35 -0700 Date: Fri, 11 Jun 2021 04:54:32 -0400 From: Rodrigo Vivi To: Zbigniew =?utf-8?Q?Kempczy=C5=84ski?= Message-ID: References: <20210610103955.67802-1-zbigniew.kempczynski@intel.com> <20210611060900.GA3298@zkempczy-mobl2> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210611060900.GA3298@zkempczy-mobl2> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Lucas De Marchi , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gRnJpLCBKdW4gMTEsIDIwMjEgYXQgMDg6MDk6MDBBTSArMDIwMCwgWmJpZ25pZXcgS2VtcGN6 ecWEc2tpIHdyb3RlOgo+IE9uIFRodSwgSnVuIDEwLCAyMDIxIGF0IDEwOjM2OjEyQU0gLTA0MDAs IFJvZHJpZ28gVml2aSB3cm90ZToKPiA+IE9uIFRodSwgSnVuIDEwLCAyMDIxIGF0IDEyOjM5OjU1 UE0gKzAyMDAsIFpiaWduaWV3IEtlbXBjennFhHNraSB3cm90ZToKPiA+ID4gV2UgaGF2ZSBlc3Rh Ymxpc2hlZCBwcmV2aW91c2x5IHdlIHN0b3AgdXNpbmcgcmVsb2NhdGlvbnMgc3RhcnRpbmcKPiA+ ID4gZnJvbSBnZW4xMiBwbGF0Zm9ybXMgd2l0aCBUaWdlcmxha2UgYXMgYW4gZXhjZXB0aW9uLiBX ZSBrZWVwIHRoaXMKPiA+ID4gc3RhdGVtZW50IGJ1dCB3ZSB3YW50IHRvIGVuYWJsZSByZWxvY2F0 aW9ucyBjb25kaXRpb25hbGx5IGZvcgo+ID4gPiBSb2NrZXRsYWtlIGFuZCBBbGRlcmxha2UgdW5k ZXIgcmVxdWlyZV9mb3JjZV9wcm9iZSBmbGFnIHNldC4KPiA+ID4gCj4gPiA+IEtlZXBpbmcgcmVs b2NhdGlvbnMgdW5kZXIgcmVxdWlyZV9mb3JjZV9wcm9iZSBmbGFnIGlzIGludGVyaW0gc29sdXRp b24KPiA+ID4gdW50aWwgSUdUcyB3aWxsIGJlIHJld3JpdHRlbiB0byB1c2Ugc29mdHBpbi4KPiA+ IAo+ID4gaG1tLi4uIHRvIGJlIHJlYWxseSBob25lc3QgSSdtIG5vdCBzbyBoYXBweSB0aGF0IHdl IGFyZSBpbnRyb2R1Y2luZwo+ID4gYSBuZXcgY3JpdGVyaWEgdG8gdGhlIGZvcmNlX3Byb2JlLgo+ ID4gCj4gPiBUaGUgY3JpdGVyaWEgd2FzIHRvIGhhdmUgYSBmdW5jdGlvbmFsIGRyaXZlciBhbmQg bm90IHRvIHRyYWNrIHVhcGkuCj4gPiAKPiA+IEJ1dCBvbiB0aGUgb3RoZXIgaGFuZCBJIGRvIHJl Y29nbml6ZSB0aGF0IHRoZSBjdXJyZW50IGRlZmluaXRpb24KPiA+IG9mIHRoZSBmbGFnIGFsbG93 cyB0aGF0LCBiZWNhdXNlIHdlIGhhdmUgZXN0YWJsaXNoZWQgdGhhdCB3aXRoCj4gPiB0aGlzIGJl aGF2aW9yLCB0aGUgImRyaXZlciBmb3IgbmV3IEludGVsIGdyYXBoaWNzIGRldmljZXMgdGhhdAo+ ID4gYXJlIHJlY29nbml6ZWQgYnV0IG5vdCBwcm9wZXJseSBzdXBwb3J0ZWQgYnkgdGhpcyBrZXJu ZWwgdmVyc2lvbiIKPiA+IChhcyBzdGF0ZWQgaW4gdGhlIEtjb25maWcgZm9yIHRoZSBEUk1fSTkx NV9GT1JDRV9QUk9CRSkuCj4gPiAKPiA+IEhvd2V2ZXIuLi4KPiA+IAo+ID4gPiAKPiA+ID4gdjI6 IC0gcmVtb3ZlIGlubGluZSBmcm9tIGZ1bmN0aW9uIGRlZmluaXRpb24gKEphbmkpCj4gPiA+ICAg ICAtIGZpeCBpbmRlbnRhdGlvbgo+ID4gPiAKPiA+ID4gdjM6IGNoYW5nZSB0byBHUkFQSElDU19W RVIoKSAoWmJpZ25pZXcpCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBaYmlnbmlldyBLZW1w Y3p5xYRza2kgPHpiaWduaWV3LmtlbXBjenluc2tpQGludGVsLmNvbT4KPiA+ID4gQ2M6IERhdmUg QWlybGllIDxhaXJsaWVkQHJlZGhhdC5jb20+Cj4gPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5p ZWwudmV0dGVyQGludGVsLmNvbT4KPiA+ID4gQ2M6IEphc29uIEVrc3RyYW5kIDxqYXNvbkBqbGVr c3RyYW5kLm5ldD4KPiA+ID4gQWNrZWQtYnk6IERhdmUgQWlybGllIDxhaXJsaWVkQHJlZGhhdC5j b20+Cj4gPiA+IC0tLQo+ID4gPiAgLi4uL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fZXhlY2J1 ZmZlci5jICAgIHwgMjQgKysrKysrKysrKysrKysrLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQs IDE5IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ2VtL2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiA+ID4gaW5kZXggYThh YmM5YWY1ZmY0Li4zMGM0ZjA1NDllYTAgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2dlbS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvZ2VtL2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+ID4gPiBAQCAtNDkxLDE2ICs0OTEs MzAgQEAgZWJfdW5yZXNlcnZlX3ZtYShzdHJ1Y3QgZWJfdm1hICpldikKPiA+ID4gIAlldi0+Zmxh Z3MgJj0gfl9fRVhFQ19PQkpFQ1RfUkVTRVJWRUQ7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gK3N0 YXRpYyBib29sIHBsYXRmb3JtX2hhc19yZWxvY3NfZW5hYmxlZChjb25zdCBzdHJ1Y3QgaTkxNV9l eGVjYnVmZmVyICplYikKPiA+ID4gK3sKPiA+ID4gKwkvKgo+ID4gPiArCSAqIFJlbG9jYXRpb25z IGFyZSBkaXNhbGxvd2VkIHN0YXJ0aW5nIGZyb20gZ2VuMTIgd2l0aCBUaWdlcmxha2UKPiA+ID4g KwkgKiBhcyBhbiBleGNlcHRpb24uIFdlIGFsbG93IHRlbXBvcmFyaWx5IHVzZSByZWxvY2F0aW9u cyBmb3IgUm9ja2V0bGFrZQo+ID4gPiArCSAqIGFuZCBBbGRlcmxha2Ugd2hlbiByZXF1aXJlX2Zv cmNlX3Byb2JlIGZsYWcgaXMgc2V0Lgo+ID4gPiArCSAqLwo+ID4gPiArCWlmIChHUkFQSElDU19W RVIoZWItPmk5MTUpIDwgMTIgfHwgSVNfVElHRVJMQUtFKGViLT5pOTE1KSkKPiA+ID4gKwkJcmV0 dXJuIHRydWU7Cj4gPiA+ICsKPiA+ID4gKwlpZiAoSU5URUxfSU5GTyhlYi0+aTkxNSktPnJlcXVp cmVfZm9yY2VfcHJvYmUgJiYKPiA+ID4gKwkgICAgKElTX1JPQ0tFVExBS0UoZWItPmk5MTUpCj4g PiAKPiA+IFRoaXMgc2hpcCBoYXMgc2FpbGVkLi4uIFJLTCBpcyBub3QgcHJvdGVjdGVkIGJ5IHRo aXMgZmxhZyBhbnkgbG9uZ2VyLgo+ID4gU2hvdWxkIHRoaXMgYmUgb24gdGhlIFRHTCBzaWRlIG5v dz8KPiAKPiArTHVjYXMKPiAKPiBJIHRoaW5rIG5vLCBSS0wgaGFzIHJlbG9jYXRpb25zIGRpc2Fi bGVkIHNvIHdlIGNhbm5vdCBwdXQgaXQgdG8gVEdMIHNpZGUuCj4gU28gaWYgUktMIGlzIGFscmVh ZHkgcmVsZWFzZWQgdGhlbiBwdXR0aW5nIGl0IHVuZGVyIHJlcXVpcmVfZm9yY2VfcHJvYmUgCj4g ZmxhZyBpcyB3cm9uZyBhbmQgb25seSBJIGNhbiBkbyBpcyB0byByZW1vdmUgaXQgZnJvbSB0aGF0 IGNvbmRpdGlvbi4gCj4gVGhlcmUncyBubyBvcHRpb24gdG8gdW5ibG9jayBSS0wgb24gSUdUIENJ IHVudGlsIHdlIHJld3JpdGUgYWxsIHRoZSB0ZXN0cy4KPiBXZSBoYXZlIHRvIHJlbHkgdGhlbiBv biBBREwqIHdpdGggcmVxdWlyZV9mb3JjZV9wcm9iZSBmbGFnIHRvIGNoZWNrIGhvdwo+IEFETCB3 aWxsIHdvcmsgd2l0aCByZWxvY2F0aW9ucy4gCgpTby4uLiBJJ20gY29uZnVzZWQgbm93LiBJJ20g bWlzc2luZyB0aGUgcG9pbnQgb2YgdGhpcyBwYXRjaCB0aGVuLgpJIHRob3VnaHQgdGhlIHJlYXNv biB3YXMgdG8gcHJvdGVjdCBmcm9tIGFueSB1c2VyIHNwYWNlIHRvIGF0dGVtcHQgdG8KdXNlIHRo ZSByZWxvY2F0aW9uLCB1bmxlc3MgdXNpbmcgdGhlIGZvcmNlX3Byb2JlIHRlbXBvcmFyaWx5IG9u bHkgZm9yCnRoZXNlIHBsYXRmb3Jtcy4KQnV0IGlmIEknbSB1bmRlcnN0YW5kaW5nIGNvcnJlY3Rs eSBub3cgaXQgaXMgb25seSB0byBzaWxlbmNlIENJPyEKSXMgdGhhdCB0aGUgY2FzZT8KSXMgdGhl IENJIG5vaXNlIHNvIGJhZD8KCj4gCj4gPiAKPiA+ID4gIHx8IElTX0FMREVSTEFLRV9TKGViLT5p OTE1KSB8fAo+ID4gPiArCSAgICAgSVNfQUxERVJMQUtFX1AoZWItPmk5MTUpKSkKPiA+IAo+ID4g SG93IHRvIGVuc3VyZSB0aGF0IHdlIHdpbGwgZWFzaWx5IGNhdGNoIHRoaXMgd2hlbiByZW1vdmlu ZyB0aGUKPiA+IGZsYWc/Cj4gPiAKPiA+IEkgbWVhbiwgc2hvdWxkIHdlIGhhdmUgYSBHRU1fQlVH IG9yIGRybV9lcnIgbWVzc2FnZSB3aGVuIHRoZXNlCj4gPiBwbGF0Zm9ybXMgaW4gdGhpcyBsaXN0 IGhhcyBub3QgdGhlIHJlcXVpcmVkX2ZvcmNlX3Byb2JlPwo+IAo+IEkgZG9uJ3QgdGhpbmsgd2Ug bmVlZCBHRU1fQlVHKCkvZHJtX2VycigpIC0gd2hlbiBJR1QgdGVzdHMgd2lsbCBzdXBwb3J0Cj4g Ym90aCAtIHJlbG9jICsgbm8tcmVsb2MgLSB0aGVuIGNvbmRpdGlvbiB3aWxsIGJlIGxpbWl0ZWQg dG86Cj4gCj4gICAgICAgICBpZiAoR1JBUEhJQ1NfVkVSKGViLT5pOTE1KSA8IDEyIHx8IElTX1RJ R0VSTEFLRShlYi0+aTkxNSkpCj4gICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwo+ICAKPiAg ICAgICAgIHJldHVybiBmYWxzZTsKPiAKPiBzbyByZXF1aXJlX2ZvcmNlX3Byb2JlIGNvbmRpdGlv biB3aWxsIGJlIGRlbGV0ZWQgYW5kIHdlIHdvbid0IG5lZWQgaXQKPiBhbnltb3JlIChJR1RzIHdp bGwgYmUgcmVhZHkpLgoKeWVzLi4uCmJ1dCB0aGVuLCB3aGVuIHdlIHJlbW92ZSB0aGUgZmxhZyB3 ZSB3aWxsIGZvcmdldCB0byBjb21lIGhlcmUgYW5kIHJlbW92ZQp0aGlzIGNoZWNrLgoKT2gsIGFu ZCBJIGp1c3QgdGhvdWdodCB0aGF0IHdlIG1pZ2h0IG5lZWQgZHJtX2Vycm9yIHdoZW4gdGhlIHBy b3RlY3Rpb24KZG9lc24ndCBleGlzdCBmb3IgdGhlIHBsYXRmb3JtLCBidXQgYWxzbyBhIGRybV9p bmZvIHRvIHRoZSB1c2VyIHRvIHRlbGwKdGhpcyBpcyBhIHRlbXBvcmFyeSBhY2NlcHRlZCBiZWhh dmlvciwgYnV0IHRoYXQgd2lsbCBiZSByZW1vdmVkIGxhdGVyCgpUaGUgY29uY2VybiBpcyBpZiBh bnkgb3RoZXIgdXNlcnNwYWNlIHdhcyB1c2luZyB0aGUgZmxhZyBhbmQgc3VkZGVudGx5IG1vdmUg dG8gYQp2ZXJzaW9uIHdpdGhvdXQgdGhlIGZsYWcsIGl0IHdvdWxkIGJlIGNvbnNpZGVyZWQgYSBy ZWdyZXNzaW9uLi4uCgo+IAo+IC0tCj4gWmJpZ25pZXcKPiAKPiA+IAo+ID4gPiArCQlyZXR1cm4g dHJ1ZTsKPiA+ID4gKwo+ID4gPiArCXJldHVybiBmYWxzZTsKPiA+ID4gK30KPiA+ID4gKwo+ID4g PiAgc3RhdGljIGludAo+ID4gPiAgZWJfdmFsaWRhdGVfdm1hKHN0cnVjdCBpOTE1X2V4ZWNidWZm ZXIgKmViLAo+ID4gPiAgCQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2V4ZWNfb2JqZWN0MiAqZW50cnks Cj4gPiA+ICAJCXN0cnVjdCBpOTE1X3ZtYSAqdm1hKQo+ID4gPiAgewo+ID4gPiAtCS8qIFJlbG9j YXRpb25zIGFyZSBkaXNhbGxvd2VkIGZvciBhbGwgcGxhdGZvcm1zIGFmdGVyIFRHTC1MUC4gIFRo aXMKPiA+ID4gLQkgKiBhbHNvIGNvdmVycyBhbGwgcGxhdGZvcm1zIHdpdGggbG9jYWwgbWVtb3J5 Lgo+ID4gPiAtCSAqLwo+ID4gPiAtCWlmIChlbnRyeS0+cmVsb2NhdGlvbl9jb3VudCAmJgo+ID4g PiAtCSAgICBHUkFQSElDU19WRVIoZWItPmk5MTUpID49IDEyICYmICFJU19USUdFUkxBS0UoZWIt Pmk5MTUpKQo+ID4gPiArCWlmIChlbnRyeS0+cmVsb2NhdGlvbl9jb3VudCAmJiAhcGxhdGZvcm1f aGFzX3JlbG9jc19lbmFibGVkKGViKSkKPiA+ID4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gPiA+ICAK PiA+ID4gIAlpZiAodW5saWtlbHkoZW50cnktPmZsYWdzICYgZWItPmludmFsaWRfZmxhZ3MpKQo+ ID4gPiAtLSAKPiA+ID4gMi4yNi4wCj4gPiA+IAo+ID4gPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4g PiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B664DC48BD1 for ; Fri, 11 Jun 2021 08:54:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 779C2613C3 for ; Fri, 11 Jun 2021 08:54:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 779C2613C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E7566EE3E; Fri, 11 Jun 2021 08:54:39 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A7826E874; Fri, 11 Jun 2021 08:54:37 +0000 (UTC) IronPort-SDR: Q9GayliTAOO5+O7lpyD5OTXPBcBBkJ06T4V5QLahExNE6fTKTlpHEbnOMIIbH9srO0BLvGE8sC h7Exp8TPg5GA== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="203655245" X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="203655245" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 01:54:36 -0700 IronPort-SDR: +ymItIaFr5iG13sDsC15ksfQ3edEWSkEP1szTvNLaRSlqBOHnUzKlvtAS7JAQ3j5uPpqkKSrF3 kb/En17ggAwg== X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="403155412" Received: from anunitax-mobl1.gar.corp.intel.com (HELO intel.com) ([10.254.36.102]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 01:54:35 -0700 Date: Fri, 11 Jun 2021 04:54:32 -0400 From: Rodrigo Vivi To: Zbigniew =?utf-8?Q?Kempczy=C5=84ski?= Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms Message-ID: References: <20210610103955.67802-1-zbigniew.kempczynski@intel.com> <20210611060900.GA3298@zkempczy-mobl2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210611060900.GA3298@zkempczy-mobl2> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Lucas De Marchi , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 11, 2021 at 08:09:00AM +0200, Zbigniew Kempczyński wrote: > On Thu, Jun 10, 2021 at 10:36:12AM -0400, Rodrigo Vivi wrote: > > On Thu, Jun 10, 2021 at 12:39:55PM +0200, Zbigniew Kempczyński wrote: > > > We have established previously we stop using relocations starting > > > from gen12 platforms with Tigerlake as an exception. We keep this > > > statement but we want to enable relocations conditionally for > > > Rocketlake and Alderlake under require_force_probe flag set. > > > > > > Keeping relocations under require_force_probe flag is interim solution > > > until IGTs will be rewritten to use softpin. > > > > hmm... to be really honest I'm not so happy that we are introducing > > a new criteria to the force_probe. > > > > The criteria was to have a functional driver and not to track uapi. > > > > But on the other hand I do recognize that the current definition > > of the flag allows that, because we have established that with > > this behavior, the "driver for new Intel graphics devices that > > are recognized but not properly supported by this kernel version" > > (as stated in the Kconfig for the DRM_I915_FORCE_PROBE). > > > > However... > > > > > > > > v2: - remove inline from function definition (Jani) > > > - fix indentation > > > > > > v3: change to GRAPHICS_VER() (Zbigniew) > > > > > > Signed-off-by: Zbigniew Kempczyński > > > Cc: Dave Airlie > > > Cc: Daniel Vetter > > > Cc: Jason Ekstrand > > > Acked-by: Dave Airlie > > > --- > > > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 24 +++++++++++++++---- > > > 1 file changed, 19 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > > > index a8abc9af5ff4..30c4f0549ea0 100644 > > > --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > > > +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > > > @@ -491,16 +491,30 @@ eb_unreserve_vma(struct eb_vma *ev) > > > ev->flags &= ~__EXEC_OBJECT_RESERVED; > > > } > > > > > > +static bool platform_has_relocs_enabled(const struct i915_execbuffer *eb) > > > +{ > > > + /* > > > + * Relocations are disallowed starting from gen12 with Tigerlake > > > + * as an exception. We allow temporarily use relocations for Rocketlake > > > + * and Alderlake when require_force_probe flag is set. > > > + */ > > > + if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915)) > > > + return true; > > > + > > > + if (INTEL_INFO(eb->i915)->require_force_probe && > > > + (IS_ROCKETLAKE(eb->i915) > > > > This ship has sailed... RKL is not protected by this flag any longer. > > Should this be on the TGL side now? > > +Lucas > > I think no, RKL has relocations disabled so we cannot put it to TGL side. > So if RKL is already released then putting it under require_force_probe > flag is wrong and only I can do is to remove it from that condition. > There's no option to unblock RKL on IGT CI until we rewrite all the tests. > We have to rely then on ADL* with require_force_probe flag to check how > ADL will work with relocations. So... I'm confused now. I'm missing the point of this patch then. I thought the reason was to protect from any user space to attempt to use the relocation, unless using the force_probe temporarily only for these platforms. But if I'm understanding correctly now it is only to silence CI?! Is that the case? Is the CI noise so bad? > > > > > > || IS_ALDERLAKE_S(eb->i915) || > > > + IS_ALDERLAKE_P(eb->i915))) > > > > How to ensure that we will easily catch this when removing the > > flag? > > > > I mean, should we have a GEM_BUG or drm_err message when these > > platforms in this list has not the required_force_probe? > > I don't think we need GEM_BUG()/drm_err() - when IGT tests will support > both - reloc + no-reloc - then condition will be limited to: > > if (GRAPHICS_VER(eb->i915) < 12 || IS_TIGERLAKE(eb->i915)) > return true; > > return false; > > so require_force_probe condition will be deleted and we won't need it > anymore (IGTs will be ready). yes... but then, when we remove the flag we will forget to come here and remove this check. Oh, and I just thought that we might need drm_error when the protection doesn't exist for the platform, but also a drm_info to the user to tell this is a temporary accepted behavior, but that will be removed later The concern is if any other userspace was using the flag and suddently move to a version without the flag, it would be considered a regression... > > -- > Zbigniew > > > > > > + return true; > > > + > > > + return false; > > > +} > > > + > > > static int > > > eb_validate_vma(struct i915_execbuffer *eb, > > > struct drm_i915_gem_exec_object2 *entry, > > > struct i915_vma *vma) > > > { > > > - /* Relocations are disallowed for all platforms after TGL-LP. This > > > - * also covers all platforms with local memory. > > > - */ > > > - if (entry->relocation_count && > > > - GRAPHICS_VER(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915)) > > > + if (entry->relocation_count && !platform_has_relocs_enabled(eb)) > > > return -EINVAL; > > > > > > if (unlikely(entry->flags & eb->invalid_flags)) > > > -- > > > 2.26.0 > > > > > > _______________________________________________ > > > Intel-gfx mailing list > > > Intel-gfx@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx