From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH 1/2] tests: migration-test: Still run the rest even if uffd missing
Date: Thu, 10 Jun 2021 19:56:00 +0100 [thread overview]
Message-ID: <YMJgQOgRjO8xvLIR@work-vm> (raw)
In-Reply-To: <20210610005239.265588-2-peterx@redhat.com>
* Peter Xu (peterx@redhat.com) wrote:
> Currently we'll skip the whole migration-test if uffd missing.
>
> It's a bit harsh - we can still run the rest besides postcopy! Enable them
> when we still can.
>
> It'll happen more frequently now after kernel UFFD_USER_MODE_ONLY introduced in
> commit 37cd0575b8510159, as qemu test normally requires kernel faults. One
> alternative is we disable kvm and create the uffd with UFFD_USER_MODE_ONLY for
> all postcopy tests, however to be simple for now just skip postcopy tests only
> by default. If we wanna run them use "sudo" or root, they'll still work. In
> all cases, it's still better than running nothing for migration-test.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Ouch! Yes; that check was originally in a standalone test file for
postcopy that's then morphed into the full test over a few years.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> tests/qtest/migration-test.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 2b028df6875..d9225f58d4d 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -1376,10 +1376,6 @@ int main(int argc, char **argv)
>
> g_test_init(&argc, &argv, NULL);
>
> - if (!ufd_version_check()) {
> - return g_test_run();
> - }
> -
> /*
> * On ppc64, the test only works with kvm-hv, but not with kvm-pr and TCG
> * is touchy due to race conditions on dirty bits (especially on PPC for
> @@ -1416,8 +1412,11 @@ int main(int argc, char **argv)
>
> module_call_init(MODULE_INIT_QOM);
>
> - qtest_add_func("/migration/postcopy/unix", test_postcopy);
> - qtest_add_func("/migration/postcopy/recovery", test_postcopy_recovery);
> + if (ufd_version_check()) {
> + qtest_add_func("/migration/postcopy/unix", test_postcopy);
> + qtest_add_func("/migration/postcopy/recovery", test_postcopy_recovery);
> + }
> +
> qtest_add_func("/migration/bad_dest", test_baddest);
> qtest_add_func("/migration/precopy/unix", test_precopy_unix);
> qtest_add_func("/migration/precopy/tcp", test_precopy_tcp);
> --
> 2.31.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-06-10 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 0:52 [PATCH 0/2] tests: migration-test: Fix agressive test skip, add dirty ring test Peter Xu
2021-06-10 0:52 ` [PATCH 1/2] tests: migration-test: Still run the rest even if uffd missing Peter Xu
2021-06-10 18:56 ` Dr. David Alan Gilbert [this message]
2021-06-10 0:52 ` [PATCH 2/2] tests: migration-test: Add dirty ring test Peter Xu
2021-06-10 19:01 ` Dr. David Alan Gilbert
2021-06-10 19:32 ` Peter Xu
2021-06-14 17:55 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMJgQOgRjO8xvLIR@work-vm \
--to=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.