From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE3B3C47082 for ; Mon, 7 Jun 2021 03:53:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EA97611C0 for ; Mon, 7 Jun 2021 03:53:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EA97611C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lq6Jw-0008UO-MW for qemu-devel@archiver.kernel.org; Sun, 06 Jun 2021 23:53:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lq6Hr-0003bm-CY; Sun, 06 Jun 2021 23:50:51 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:39197) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lq6Hk-0002cA-47; Sun, 06 Jun 2021 23:50:50 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4Fyzt20Mlmz9sT6; Mon, 7 Jun 2021 13:50:33 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1623037834; bh=mYiL7+HGRHdMvi7TritmoVZp1mIbao+FnfZXcNKJBjQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iU3yODHllWBszQdcVVgTXI6tpyKZ90lHC2ge0hFLQZj47FkgA7mKpVcYXMKFEe011 nqX/XYj53Tew/nYFiLTZX4D+TXG134TciKlgwTqjDGe3EgVZwzqjEU5Ijd2J7LaBL+ qtv6XmM6KopeZ/wXOEvLa2YSoHzauT5nW3TBHCEg= Date: Mon, 7 Jun 2021 12:23:08 +1000 From: David Gibson To: Daniel Henrique Barboza Subject: Re: [PATCH v2 1/2] qapi/machine.json: add DEVICE_UNPLUG_ERROR QAPI event Message-ID: References: <20210604200353.1206897-1-danielhb413@gmail.com> <20210604200353.1206897-2-danielhb413@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VsykvSp1eq8g+vVN" Content-Disposition: inline In-Reply-To: <20210604200353.1206897-2-danielhb413@gmail.com> Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --VsykvSp1eq8g+vVN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 04, 2021 at 05:03:52PM -0300, Daniel Henrique Barboza wrote: > At this moment we only provide one event to report a hotunplug error, > MEM_UNPLUG_ERROR. As of Linux kernel 5.12 and QEMU 6.0.0, the pseries > machine is now able to report unplug errors for other device types, such > as CPUs. >=20 > Instead of creating a (device_type)_UNPLUG_ERROR for each new device, > create a generic DEVICE_UNPLUG_ERROR event that can be used by all > unplug errors in the future. >=20 > Signed-off-by: Daniel Henrique Barboza Reviewed-by: David Gibson > --- > qapi/machine.json | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) >=20 > diff --git a/qapi/machine.json b/qapi/machine.json > index 58a9c86b36..f0c7e56be0 100644 > --- a/qapi/machine.json > +++ b/qapi/machine.json > @@ -1274,3 +1274,26 @@ > ## > { 'event': 'MEM_UNPLUG_ERROR', > 'data': { 'device': 'str', 'msg': 'str' } } > + > +## > +# @DEVICE_UNPLUG_ERROR: > +# > +# Emitted when a device hot unplug error occurs. > +# > +# @device: device name > +# > +# @msg: Informative message > +# > +# Since: 6.1 > +# > +# Example: > +# > +# <- { "event": "DEVICE_UNPLUG_ERROR" > +# "data": { "device": "dimm1", > +# "msg": "Memory hotunplug rejected by the guest for devi= ce dimm1" > +# }, > +# "timestamp": { "seconds": 1615570772, "microseconds": 202844 } } > +# > +## > +{ 'event': 'DEVICE_UNPLUG_ERROR', > + 'data': { 'device': 'str', 'msg': 'str' } } --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --VsykvSp1eq8g+vVN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmC9gwoACgkQbDjKyiDZ s5KHDA/8DEKArfmHskHudLGbSUoZI0ykU9fvCmlzXeLY+litQZ8ZRb/uqilYKnW/ waCxb8oJ2afuynFKH8hZ5brfKJz8I+gqyGr8CIjvTV3ffJ1r8Ki77Z13ZV9soxvS SnoVbzgxcx4SpYfJYOfkIlceWt/01MBMbpjl5tBjbuNSH9Pra97RVQqaOnLZitej cnjgXuz3KhaHLIPMdhzocddZqwtBqE843zC9ZKkTGI/GKfaQ8vTMMeE9WVelZFJT MpougBRvUYS9DPi7XbHd1xwq3eYQW2+7BjtoEnbDkYYbDDgpySMI7MODh/B52fYD SionyOTHJwWzbSMaBag68d7PwEbsyrrvSoE3d2zxuoLYWZYBmOZoZV2k5lIVvq1C ilhmZ5L0biqO6u/wlWayUzlGCBV5B4RqUigFR1ZDVVIJwscVooIOz7oesDRKZzY6 rqpBCb11USs+wFwwLQM674qsK+S/ZE0ZxTkIop1KO3UyzQPsuCx53t15XbKG5iB6 gzqQg4LXIbgvpC5EV7nm2CVdbDOU+gXX0eEsW+wgCDCmVISpBgdQmtxaBu4AH+qT notBN8uX2S+O9+dmeRNswFXXs7dNVTwBxA/SYrJVMruhVtzzKOxRRsVmuMY/jWSQ +h9YpYXvYt6QQAP2yPWxPd5iRRT447uMibPlSDZKFOue0UuFdR0= =7oHl -----END PGP SIGNATURE----- --VsykvSp1eq8g+vVN--