From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A84D4C4707E for ; Sat, 22 May 2021 10:27:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C8BF61131 for ; Sat, 22 May 2021 10:27:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230367AbhEVK2r (ORCPT ); Sat, 22 May 2021 06:28:47 -0400 Received: from msg-2.mailo.com ([213.182.54.12]:46844 "EHLO msg-2.mailo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230164AbhEVK2o (ORCPT ); Sat, 22 May 2021 06:28:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1621679054; bh=pntNiNl8/Dy7MmFkZk90RCYekpUw7OpnE3Bh9rZfsrs=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=Ntbz0bvETVPb0AyKaKgAeslcMbFFk96gBIBfjhpZnBmFyJJNVTMXpIU5moLBCHuXU DrHgo9EtIoxtYOIEA6RlCgHHHA5EFefYnZkImM9Awpq2EYxffbHK9kRYTXLq4xZfNR e9AReyCIhZwK9Fv/sOURTwlcKlLniHkj1Hfs892w= Received: by 192.168.90.16 [192.168.90.16] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sat, 22 May 2021 12:24:14 +0200 (CEST) X-EA-Auth: Tbm0ZmgWJ2lRn83pNiRISkvsn2jiX5I1Pm4oL+z5hTnUI1vLy1APkXX+TLRcfHhthKDWrWBPIwpyshC0UipINY1FVWqqdgXh Date: Sat, 22 May 2021 15:54:06 +0530 From: Deepak R Varma To: Dan Carpenter Cc: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 3/5] staging: media: atomisp: code formatting changes sh_css_params.c Message-ID: References: <6bc123d66150ccaa6dc6fdf2f11c8669e2f493e2.1619850663.git.drv@mailo.com> <20210521105222.GJ1955@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210521105222.GJ1955@kadam> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 01:52:22PM +0300, Dan Carpenter wrote: > On Sat, May 01, 2021 at 12:16:07PM +0530, Deepak R Varma wrote: > > @@ -1562,8 +1544,10 @@ ia_css_isp_3a_statistics_map_allocate( > > base_ptr = me->data_ptr; > > > > me->size = isp_stats->size; > > - /* GCC complains when we assign a char * to a void *, so these > > - * casts are necessary unfortunately. */ > > + /* > > + * GCC complains when we assign a char * to a void *, so these > > + * casts are necessary unfortunately. > > + */ > > Not related to your patch, but assigning a char pointer to a void > pointer is fine and GCC will not complain. The problem is that > me->dmem_stats is not a void pointer. Someone should delete that > nonsense comment. I agree. Well caught. I will remove these comments and send v2. Waiting for feedback on other patches of this series. deepak. > > > me->dmem_stats = (void *)base_ptr; > > me->vmem_stats_hi = (void *)(base_ptr + isp_stats->dmem_size); > > me->vmem_stats_lo = (void *)(base_ptr + isp_stats->dmem_size + > > regards, > dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_50,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B3AC2B9F2 for ; Sat, 22 May 2021 10:27:22 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80AAD61131 for ; Sat, 22 May 2021 10:27:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80AAD61131 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mailo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 32112400F4; Sat, 22 May 2021 10:27:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nYK_KmVejuTF; Sat, 22 May 2021 10:27:20 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 3533D402D2; Sat, 22 May 2021 10:27:20 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 217AB1BF873 for ; Sat, 22 May 2021 10:27:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1DF9C83C27 for ; Sat, 22 May 2021 10:27:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=mailo.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CVWfAPOmKnsB for ; Sat, 22 May 2021 10:27:18 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by smtp1.osuosl.org (Postfix) with ESMTPS id 181B383C26 for ; Sat, 22 May 2021 10:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1621679054; bh=pntNiNl8/Dy7MmFkZk90RCYekpUw7OpnE3Bh9rZfsrs=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=Ntbz0bvETVPb0AyKaKgAeslcMbFFk96gBIBfjhpZnBmFyJJNVTMXpIU5moLBCHuXU DrHgo9EtIoxtYOIEA6RlCgHHHA5EFefYnZkImM9Awpq2EYxffbHK9kRYTXLq4xZfNR e9AReyCIhZwK9Fv/sOURTwlcKlLniHkj1Hfs892w= Received: by 192.168.90.16 [192.168.90.16] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sat, 22 May 2021 12:24:14 +0200 (CEST) X-EA-Auth: Tbm0ZmgWJ2lRn83pNiRISkvsn2jiX5I1Pm4oL+z5hTnUI1vLy1APkXX+TLRcfHhthKDWrWBPIwpyshC0UipINY1FVWqqdgXh Date: Sat, 22 May 2021 15:54:06 +0530 From: Deepak R Varma To: Dan Carpenter Subject: Re: [PATCH 3/5] staging: media: atomisp: code formatting changes sh_css_params.c Message-ID: References: <6bc123d66150ccaa6dc6fdf2f11c8669e2f493e2.1619850663.git.drv@mailo.com> <20210521105222.GJ1955@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210521105222.GJ1955@kadam> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Fri, May 21, 2021 at 01:52:22PM +0300, Dan Carpenter wrote: > On Sat, May 01, 2021 at 12:16:07PM +0530, Deepak R Varma wrote: > > @@ -1562,8 +1544,10 @@ ia_css_isp_3a_statistics_map_allocate( > > base_ptr = me->data_ptr; > > > > me->size = isp_stats->size; > > - /* GCC complains when we assign a char * to a void *, so these > > - * casts are necessary unfortunately. */ > > + /* > > + * GCC complains when we assign a char * to a void *, so these > > + * casts are necessary unfortunately. > > + */ > > Not related to your patch, but assigning a char pointer to a void > pointer is fine and GCC will not complain. The problem is that > me->dmem_stats is not a void pointer. Someone should delete that > nonsense comment. I agree. Well caught. I will remove these comments and send v2. Waiting for feedback on other patches of this series. deepak. > > > me->dmem_stats = (void *)base_ptr; > > me->vmem_stats_hi = (void *)(base_ptr + isp_stats->dmem_size); > > me->vmem_stats_lo = (void *)(base_ptr + isp_stats->dmem_size + > > regards, > dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel