From: Jacky Chou <jacky_chou@aspeedtech.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: "joe.hershberger@ni.com" <joe.hershberger@ni.com>,
"rfried.dev@gmail.com" <rfried.dev@gmail.com>,
"trini@konsulko.com" <trini@konsulko.com>,
"michal.simek@amd.com" <michal.simek@amd.com>,
"marek.vasut+renesas@mailbox.org"
<marek.vasut+renesas@mailbox.org>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
BMC-SW <BMC-SW@aspeedtech.com>
Subject: 回覆: [PATCH] net: phy: ncsi: Correct the endian of the checksum
Date: Sun, 3 Mar 2024 02:14:43 +0000 [thread overview]
Message-ID: <SEYPR06MB513483FE06C897839C5E3E5E9D592@SEYPR06MB5134.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <da9231ac-1386-48fc-81b9-8e027cd5dff5@moroto.mountain>
Hi Dan Carpenter,
I have verified it on the little-endian platform, such as ASPEED AST2600.
I think put_unaligned_be32() and htonl() functions have no effect on big-endian platforms.
And keep put_unaligned_be32() to help access the unaligned memory, such as pchecksum variable.
Thanks,
Jacky
________________________________
寄件者: Dan Carpenter <dan.carpenter@linaro.org>
寄件日期: 2024年2月5日 下午 11:04
收件者: Jacky Chou <jacky_chou@aspeedtech.com>
副本: joe.hershberger@ni.com <joe.hershberger@ni.com>; rfried.dev@gmail.com <rfried.dev@gmail.com>; trini@konsulko.com <trini@konsulko.com>; michal.simek@amd.com <michal.simek@amd.com>; marek.vasut+renesas@mailbox.org <marek.vasut+renesas@mailbox.org>; u-boot@lists.denx.de <u-boot@lists.denx.de>; BMC-SW <BMC-SW@aspeedtech.com>
主旨: Re: [PATCH] net: phy: ncsi: Correct the endian of the checksum
On Mon, Feb 05, 2024 at 04:02:28PM +0800, Jacky Chou wrote:
> There is no need to perform the endian twice here.
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: f641a8ac93e0 ("phy: Add support for the NC-SI protocol")
How did this ever work? Was this always tested on big endian hardware
or was nothing verifying the checksums?
regards,
dan carpenter
next prev parent reply other threads:[~2024-03-03 3:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 8:02 [PATCH] net: phy: ncsi: Correct the endian of the checksum Jacky Chou
2024-02-05 15:04 ` Dan Carpenter
2024-03-03 2:14 ` Jacky Chou [this message]
2024-03-04 6:25 ` 回覆: " Dan Carpenter
2024-03-04 8:59 ` Jacky Chou
2024-03-04 10:26 ` Dan Carpenter
2024-03-28 15:08 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SEYPR06MB513483FE06C897839C5E3E5E9D592@SEYPR06MB5134.apcprd06.prod.outlook.com \
--to=jacky_chou@aspeedtech.com \
--cc=BMC-SW@aspeedtech.com \
--cc=dan.carpenter@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=michal.simek@amd.com \
--cc=rfried.dev@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.